cubetiq/code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vscode: Fix update check timeouts

Browse Source 
Forgot an extra 60 in the check interval and the notification timeout.
Very unfortunate. Check has been allowed every 168 minutes instead of
every week.
This commit is contained in:
Anmol Sethi 2020-11-25 11:50:38 -05:00
parent cc18175ce3
commit 0713fa900b
No known key found for this signature in database
GPG Key ID: 8CEF1878FF10ADEB
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ci/dev/vscode.patch
View File

@ -988,7 +988,7 @@ index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152
+ const lastNoti = storageService.getNumber('csLastUpdateNotification', StorageScope.GLOBAL); + const lastNoti = storageService.getNumber('csLastUpdateNotification', StorageScope.GLOBAL);
+ if (lastNoti) { + if (lastNoti) {
+ // Only remind them again after 1 week. + // Only remind them again after 1 week.
+ const timeout = 1000*60*24*7; + const timeout = 1000*60*60*24*7;
+ const threshold = lastNoti + timeout; + const threshold = lastNoti + timeout;
+ if (Date.now() < threshold) { + if (Date.now() < threshold) {
+ return; + return;
@ -1007,7 +1007,7 @@ index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152
+ logService.debug(`failed to check for update: ${error}`); + logService.debug(`failed to check for update: ${error}`);
+ }).finally(() => { + }).finally(() => {
+ // Check again every 6 hours. + // Check again every 6 hours.
+ setTimeout(updateLoop, 1000*60*6); + setTimeout(updateLoop, 1000*60*60*6);
+ }); + });
+ }; + };
+ +