From 277211c4ce0ca66af19c0ffb80a4d64dec4099b5 Mon Sep 17 00:00:00 2001
From: Anmol Sethi <hi@nhooyr.io>
Date: Fri, 6 Nov 2020 14:44:19 -0500
Subject: [PATCH] plugin: Make init and applications callbacks optional

---
 src/node/plugin.ts     | 6 ++++++
 typings/pluginapi.d.ts | 8 ++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/node/plugin.ts b/src/node/plugin.ts
index 77a4a827..899aa111 100644
--- a/src/node/plugin.ts
+++ b/src/node/plugin.ts
@@ -55,6 +55,9 @@ export class PluginAPI {
   public async applications(): Promise<Application[]> {
     const apps = new Array<Application>()
     for (const [, p] of this.plugins) {
+      if (!p.applications) {
+        continue
+      }
       const pluginApps = await p.applications()
 
       // Add plugin key to each app.
@@ -86,6 +89,9 @@ export class PluginAPI {
    */
   public mount(r: express.Router): void {
     for (const [, p] of this.plugins) {
+      if (!p.router) {
+        continue
+      }
       r.use(`${p.routerPath}`, p.router())
     }
   }
diff --git a/typings/pluginapi.d.ts b/typings/pluginapi.d.ts
index d0846a28..06ce35fb 100644
--- a/typings/pluginapi.d.ts
+++ b/typings/pluginapi.d.ts
@@ -129,8 +129,10 @@ export interface Plugin {
    * Returns the plugin's router.
    *
    * Mounted at <code-sever-root>/<plugin-path>
+   *
+   * If not present, the plugin provides no routes.
    */
-  router(): express.Router
+  router?(): express.Router
 
   /**
    * code-server uses this to collect the list of applications that
@@ -139,8 +141,10 @@ export interface Plugin {
    * refresh the list of applications
    *
    * Ensure this is as fast as possible.
+   *
+   * If not present, the plugin provides no applications.
    */
-  applications(): Application[] | Promise<Application[]>
+  applications?(): Application[] | Promise<Application[]>
 }
 
 /**