cubetiq/code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

proxy_agent.ts: Document why there is no $HTTPS_PROXY support

Browse Source
This commit is contained in:
Anmol Sethi 2020-12-04 13:50:10 -05:00
parent a021bf5d35
commit 58bbf2584a
No known key found for this signature in database
GPG Key ID: 8CEF1878FF10ADEB
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/node/proxy_agent.ts
View File

@ -19,7 +19,16 @@ import * as proxyagent from "proxy-agent"
* custom agent from the proxyAgent package.
*/
export function monkeyPatch(vscode: boolean): void {
if (!process.env.HTTP_PROXY) {
// We do not support HTTPS_PROXY here to avoid confusion. proxy-agent will automatically
// use the correct protocol to connect to the proxy depending on the requested URL.
//
// We could implement support ourselves to allow people to configure the proxy used for
// HTTPS vs HTTP but there doesn't seem to be much value in that.
//
// At least of right now, it'd just be plain confusing to support HTTPS_PROXY when proxy-agent
// will still use HTTP to hit it for HTTP requests.
const proxyURL = process.env.HTTP_PROXY || process.env.http_proxy
if (!proxyURL) {
return
}