From c56830022148ebbc1d7b01385f88c79c8ff8c592 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 29 Apr 2021 15:47:14 -0700 Subject: [PATCH 1/3] chore: clean up yarn.lock --- yarn.lock | 5 ----- 1 file changed, 5 deletions(-) diff --git a/yarn.lock b/yarn.lock index e5d6da78..f21e2f45 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3141,11 +3141,6 @@ eslint-plugin-import@^2.18.2: resolve "^1.17.0" tsconfig-paths "^3.9.0" -eslint-plugin-jest-playwright@^0.2.1: - version "0.2.1" - resolved "https://registry.yarnpkg.com/eslint-plugin-jest-playwright/-/eslint-plugin-jest-playwright-0.2.1.tgz#8778fee9d5915132a03d94370d3eea0a7ddd08f3" - integrity sha512-BicKUJUpVPsLbHN8c5hYaZn6pv8PCMjBGHXUfvlY1p75fh4APVfX2gTK14HuiR8/Bv3fKBQu5MTaqCro4E3OHg== - eslint-plugin-prettier@^3.1.0: version "3.4.0" resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.4.0.tgz#cdbad3bf1dbd2b177e9825737fe63b476a08f0c7" From 17f4c4c330e3e72548d7d448d88e812146570bd9 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 29 Apr 2021 16:22:21 -0700 Subject: [PATCH 2/3] fix(e2e): remove quotes from terminal type command --- test/e2e/terminal.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/terminal.test.ts b/test/e2e/terminal.test.ts index c4bb45b1..f92419c6 100644 --- a/test/e2e/terminal.test.ts +++ b/test/e2e/terminal.test.ts @@ -50,7 +50,7 @@ test.describe("Integrated Terminal", () => { await codeServer.focusTerminal() await page.waitForLoadState("load") - await page.keyboard.type(`echo '${testString}' > '${tmpFile}'`) + await page.keyboard.type(`echo ${testString} > ${tmpFile}`) await page.keyboard.press("Enter") // It may take a second to process await page.waitForTimeout(1000) From 7309ea9d10a09672f5d653e765751beb18579938 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 29 Apr 2021 16:27:19 -0700 Subject: [PATCH 3/3] fix(e2e): use one worker to reduce flakiness --- test/config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/test/config.ts b/test/config.ts index 6df0324e..53b592b7 100644 --- a/test/config.ts +++ b/test/config.ts @@ -52,6 +52,7 @@ const config: Config = { testDir: path.join(__dirname, "e2e"), // Search for tests in this directory. timeout: 60000, // Each test is given 60 seconds. retries: 3, // Retry failing tests 2 times + workers: 1, } if (process.env.CI) {