feat(register): add test when navigator undefined

test/constants.test.ts

@@ -1,6 +1,3 @@
-// Note: we need to import logger from the root
-// because this is the logger used in logError in ../src/common/util
-// import { logger } from "../node_modules/@coder/logger"
 import { commit, getPackageJson, version } from "../src/node/constants"
 import { loggerModule } from "./helpers"
 

test/register.test.ts

@@ -1,19 +1,17 @@
 import { JSDOM } from "jsdom"
 import { loggerModule } from "./helpers"
 
-// jest.mock is hoisted above the imports so we must use `require` here.
-jest.mock("@coder/logger", () => require("./helpers").loggerModule)
-
 describe("register", () => {
+  describe("when navigator and serviceWorker are defined", () => {
+    const mockRegisterFn = jest.fn()
+
+    beforeAll(() => {
       const { window } = new JSDOM()
       global.window = (window as unknown) as Window & typeof globalThis
       global.document = window.document
       global.navigator = window.navigator
       global.location = window.location
 
-  const mockRegisterFn = jest.fn()
-
-  beforeAll(() => {
       Object.defineProperty(global.navigator, "serviceWorker", {
         value: {
           register: mockRegisterFn,
@@ -21,6 +19,10 @@ describe("register", () => {
       })
     })
 
+    beforeEach(() => {
+      jest.mock("@coder/logger", () => loggerModule)
+    })
+
     afterEach(() => {
       mockRegisterFn.mockClear()
       jest.resetModules()
@@ -28,6 +30,12 @@ describe("register", () => {
 
     afterAll(() => {
       jest.restoreAllMocks()
+
+      // We don't want these to stay around because it can affect other tests
+      global.window = (undefined as unknown) as Window & typeof globalThis
+      global.document = (undefined as unknown) as Document & typeof globalThis
+      global.navigator = (undefined as unknown) as Navigator & typeof globalThis
+      global.location = (undefined as unknown) as Location & typeof globalThis
     })
 
     it("should register a ServiceWorker", () => {
@@ -56,4 +64,25 @@ describe("register", () => {
         `[Service Worker] registration: ${error.message} ${error.stack}`,
       )
     })
+  })
+
+  describe("when navigator and serviceWorker are NOT defined", () => {
+    let spy: jest.SpyInstance
+
+    beforeEach(() => {
+      spy = jest.spyOn(console, "error")
+    })
+
+    afterAll(() => {
+      jest.restoreAllMocks()
+    })
+
+    it("should log an error to the console", () => {
+      // Load service worker like you would in the browser
+      require("../src/browser/register")
+      expect(spy).toHaveBeenCalled()
+      expect(spy).toHaveBeenCalledTimes(1)
+      expect(spy).toHaveBeenCalledWith("[Service Worker] navigator is undefined")
+    })
+  })
 })