Refactor evaluations (#285)

* Replace evaluations with proxies and messages

* Return proxies synchronously

Otherwise events can be lost.

* Ensure events cannot be missed

* Refactor remaining fills

* Use more up-to-date version of util

For callbackify.

* Wait for dispose to come back before removing

This prevents issues with the "done" event not always being the last
event fired. For example a socket might close and then end, but only
if the caller called end.

* Remove old node-pty tests

* Fix emitting events twice on duplex streams

* Preserve environment when spawning processes

* Throw a better error if the proxy doesn't exist

* Remove rimraf dependency from ide

* Update net.Server.listening

* Use exit event instead of killed

Doesn't look like killed is even a thing.

* Add response timeout to server

* Fix trash

* Require node-pty & spdlog after they get unpackaged

This fixes an error when running in the binary.

* Fix errors in down emitter preventing reconnecting

* Fix disposing proxies when nothing listens to "error" event

* Refactor event tests to use jest.fn()

* Reject proxy call when disconnected

Otherwise it'll wait for the timeout which is a waste of time since we
already know the connection is dead.

* Use nbin for binary packaging

* Remove additional module requires

* Attempt to remove require for local bootstrap-fork

* Externalize fsevents

packages/protocol/src/proto/client_pb.d.ts

@@ -6,15 +6,10 @@ import * as node_pb from "./node_pb";
 import * as vscode_pb from "./vscode_pb";
 
 export class ClientMessage extends jspb.Message {
-  hasNewEval(): boolean;
-  clearNewEval(): void;
-  getNewEval(): node_pb.NewEvalMessage | undefined;
-  setNewEval(value?: node_pb.NewEvalMessage): void;
-
-  hasEvalEvent(): boolean;
-  clearEvalEvent(): void;
-  getEvalEvent(): node_pb.EvalEventMessage | undefined;
-  setEvalEvent(value?: node_pb.EvalEventMessage): void;
+  hasMethod(): boolean;
+  clearMethod(): void;
+  getMethod(): node_pb.MethodMessage | undefined;
+  setMethod(value?: node_pb.MethodMessage): void;
 
   hasPing(): boolean;
   clearPing(): void;
@@ -34,34 +29,42 @@ export class ClientMessage extends jspb.Message {
 
 export namespace ClientMessage {
   export type AsObject = {
-    newEval?: node_pb.NewEvalMessage.AsObject,
-    evalEvent?: node_pb.EvalEventMessage.AsObject,
+    method?: node_pb.MethodMessage.AsObject,
     ping?: node_pb.Ping.AsObject,
   }
 
   export enum MsgCase {
     MSG_NOT_SET = 0,
-    NEW_EVAL = 11,
-    EVAL_EVENT = 12,
-    PING = 13,
+    METHOD = 20,
+    PING = 21,
   }
 }
 
 export class ServerMessage extends jspb.Message {
-  hasEvalFailed(): boolean;
-  clearEvalFailed(): void;
-  getEvalFailed(): node_pb.EvalFailedMessage | undefined;
-  setEvalFailed(value?: node_pb.EvalFailedMessage): void;
+  hasFail(): boolean;
+  clearFail(): void;
+  getFail(): node_pb.FailMessage | undefined;
+  setFail(value?: node_pb.FailMessage): void;
 
-  hasEvalDone(): boolean;
-  clearEvalDone(): void;
-  getEvalDone(): node_pb.EvalDoneMessage | undefined;
-  setEvalDone(value?: node_pb.EvalDoneMessage): void;
+  hasSuccess(): boolean;
+  clearSuccess(): void;
+  getSuccess(): node_pb.SuccessMessage | undefined;
+  setSuccess(value?: node_pb.SuccessMessage): void;
 
-  hasEvalEvent(): boolean;
-  clearEvalEvent(): void;
-  getEvalEvent(): node_pb.EvalEventMessage | undefined;
-  setEvalEvent(value?: node_pb.EvalEventMessage): void;
+  hasEvent(): boolean;
+  clearEvent(): void;
+  getEvent(): node_pb.EventMessage | undefined;
+  setEvent(value?: node_pb.EventMessage): void;
+
+  hasCallback(): boolean;
+  clearCallback(): void;
+  getCallback(): node_pb.CallbackMessage | undefined;
+  setCallback(value?: node_pb.CallbackMessage): void;
+
+  hasPong(): boolean;
+  clearPong(): void;
+  getPong(): node_pb.Pong | undefined;
+  setPong(value?: node_pb.Pong): void;
 
   hasInit(): boolean;
   clearInit(): void;
@@ -73,11 +76,6 @@ export class ServerMessage extends jspb.Message {
   getSharedProcessActive(): vscode_pb.SharedProcessActiveMessage | undefined;
   setSharedProcessActive(value?: vscode_pb.SharedProcessActiveMessage): void;
 
-  hasPong(): boolean;
-  clearPong(): void;
-  getPong(): node_pb.Pong | undefined;
-  setPong(value?: node_pb.Pong): void;
-
   getMsgCase(): ServerMessage.MsgCase;
   serializeBinary(): Uint8Array;
   toObject(includeInstance?: boolean): ServerMessage.AsObject;
@@ -91,22 +89,24 @@ export class ServerMessage extends jspb.Message {
 
 export namespace ServerMessage {
   export type AsObject = {
-    evalFailed?: node_pb.EvalFailedMessage.AsObject,
-    evalDone?: node_pb.EvalDoneMessage.AsObject,
-    evalEvent?: node_pb.EvalEventMessage.AsObject,
+    fail?: node_pb.FailMessage.AsObject,
+    success?: node_pb.SuccessMessage.AsObject,
+    event?: node_pb.EventMessage.AsObject,
+    callback?: node_pb.CallbackMessage.AsObject,
+    pong?: node_pb.Pong.AsObject,
     init?: WorkingInitMessage.AsObject,
     sharedProcessActive?: vscode_pb.SharedProcessActiveMessage.AsObject,
-    pong?: node_pb.Pong.AsObject,
   }
 
   export enum MsgCase {
     MSG_NOT_SET = 0,
-    EVAL_FAILED = 13,
-    EVAL_DONE = 14,
-    EVAL_EVENT = 15,
+    FAIL = 13,
+    SUCCESS = 14,
+    EVENT = 19,
+    CALLBACK = 22,
+    PONG = 18,
     INIT = 16,
     SHARED_PROCESS_ACTIVE = 17,
-    PONG = 18,
   }
 }