From e243f6e36952cbe4d655cdbd77765b701feccd9f Mon Sep 17 00:00:00 2001
From: Asher <ash@coder.com>
Date: Tue, 3 Nov 2020 14:42:37 -0600
Subject: [PATCH] Return early when forking to reduce indentation

---
 src/node/vscode.ts | 46 ++++++++++++++++++++++++----------------------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/src/node/vscode.ts b/src/node/vscode.ts
index 6e050de2..c25b7e9b 100644
--- a/src/node/vscode.ts
+++ b/src/node/vscode.ts
@@ -74,30 +74,32 @@ export class VscodeProvider {
   }
 
   private fork(): Promise<cp.ChildProcess> {
-    if (!this._vscode) {
-      logger.debug("forking vs code...")
-      const vscode = cp.fork(path.join(this.serverRootPath, "fork"))
-      vscode.on("error", (error) => {
-        logger.error(error.message)
-        this._vscode = undefined
-      })
-      vscode.on("exit", (code) => {
-        logger.error(`VS Code exited unexpectedly with code ${code}`)
-        this._vscode = undefined
-      })
-
-      this._vscode = new Promise((resolve, reject) => {
-        vscode.once("message", (message: ipc.VscodeMessage) => {
-          logger.debug("got message from vs code", field("message", message))
-          return message.type === "ready"
-            ? resolve(vscode)
-            : reject(new Error("Unexpected response waiting for ready response"))
-        })
-        vscode.once("error", reject)
-        vscode.once("exit", (code) => reject(new Error(`VS Code exited unexpectedly with code ${code}`)))
-      })
+    if (this._vscode) {
+      return this._vscode
     }
 
+    logger.debug("forking vs code...")
+    const vscode = cp.fork(path.join(this.serverRootPath, "fork"))
+    vscode.on("error", (error) => {
+      logger.error(error.message)
+      this._vscode = undefined
+    })
+    vscode.on("exit", (code) => {
+      logger.error(`VS Code exited unexpectedly with code ${code}`)
+      this._vscode = undefined
+    })
+
+    this._vscode = new Promise((resolve, reject) => {
+      vscode.once("message", (message: ipc.VscodeMessage) => {
+        logger.debug("got message from vs code", field("message", message))
+        return message.type === "ready"
+          ? resolve(vscode)
+          : reject(new Error("Unexpected response waiting for ready response"))
+      })
+      vscode.once("error", reject)
+      vscode.once("exit", (code) => reject(new Error(`VS Code exited unexpectedly with code ${code}`)))
+    })
+
     return this._vscode
   }