Asher
021c084e43
Move log level defaults into setDefaults
...
This will allow cliArgs to be only the actual arguments the user passed
which will be used for some logic around opening in existing instances.
2020-10-09 16:57:42 -05:00
Asher
1902296702
Remove references to --open-in flag
2020-10-09 16:57:41 -05:00
Asher
bb1bf88439
Fix wrapper.start not actually waiting for anything
2020-10-09 16:57:41 -05:00
Asher
0a8e71c647
Refactor wrapper
...
- Immediately create ipcMain so it doesn't have to be a function which I
think feels cleaner.
- Move exit handling to a separate function to compensate (otherwise
the VS Code CLI for example won't be able to exit on its own).
- New isChild prop that is clearer than checking for parentPid (IMO).
- Skip all the checks that aren't necessary for the child process (like
--help, --version, etc).
- Since we check if we're the child in entry go ahead and move the
wrap code into entry as well since that's basically what it does.
- Use a single catch at the end of the entry.
- Split out the VS Code CLI and existing instance code into separate
functions.
2020-10-09 16:57:40 -05:00
Asher
6bdaada689
Move uncaught exception handler to wrapper
...
Feels more appropriate there to me.
2020-10-09 16:50:24 -05:00
Anmol Sethi
1e4e72aa5b
Merge pull request #2184 from nhooyr/link-flag-1547
...
cloud: Rename --coder-bind to --link
2020-10-09 13:53:55 -04:00
Anmol Sethi
fcfb03382a
cloud: Add mention of cloud repo
2020-10-09 12:57:48 -04:00
Anmol Sethi
d67bd3f604
cloud: Rename --coder-bind to --link
2020-10-09 12:57:20 -04:00
Anmol Sethi
2d1de749f4
Unlink socket before using ( #2181 )
...
See https://stackoverflow.com/a/34881585/4283659
Closes #1538
2020-10-09 12:34:52 -04:00
Asher
c6c293d53a
Merge pull request #2147 from cdr/multi-plugin
2020-10-09 11:02:25 -05:00
Anmol Sethi
a5b6d080bd
Add CS_BETA and note --coder-bind is in beta
2020-10-09 07:50:51 -04:00
Anmol Sethi
9ff37977a8
Make --coder-bind disable HTTPS
2020-10-09 07:39:10 -04:00
Anmol Sethi
f5489cd3a0
Hide -coder-bind for now
2020-10-09 07:38:38 -04:00
Asher
c86d7398ab
Use system data directory for plugins
2020-10-08 16:18:31 -05:00
Anmol Sethi
3e28ab85a0
Add debug log for options passed to the agent
2020-10-07 17:40:19 -04:00
Anmol Sethi
85b0804be5
Remove cliArgs from main
...
No purpose when all the args are in the args parameter.
We only need configArgs for bindAddrFromAllSources.
2020-10-07 17:40:19 -04:00
Anmol Sethi
df3089f3ad
coder-cloud: Use consolidated bind command
2020-10-07 17:40:19 -04:00
Anmol Sethi
bfe731f4f3
Ensure socket is undefined with --coder-bind
2020-10-07 16:16:01 -04:00
Anmol Sethi
c4f1c053bf
Show valid values for --auth in --help
...
See https://github.com/nhooyr/code-server/pull/1/files#r485847134
2020-10-07 15:58:30 -04:00
Anmol Sethi
4b3c089630
Remove dead code
2020-10-07 15:58:30 -04:00
Anmol Sethi
1c16814a89
Update coder-bind docs
2020-10-07 15:58:30 -04:00
Anmol Sethi
c3c24fe4d2
Fixes for @ammarb
2020-10-07 15:58:30 -04:00
Anmol Sethi
22c4a7e10f
Make linking and starting code-server to the cloud a single command
2020-10-07 15:58:30 -04:00
Anmol Sethi
0aa98279d6
Fixes for CI
2020-10-07 15:58:30 -04:00
Anmol Sethi
55a7e8b56f
Implement automatic cloud proxying
2020-10-07 15:58:30 -04:00
Anmol Sethi
916e24e109
Add support for multiline descriptions
2020-10-07 15:58:30 -04:00
Anmol Sethi
c7c62daa67
Remove unused code in optionDescriptions
2020-10-07 15:58:30 -04:00
Anmol Sethi
579bb94a6c
Add coder cloud expose command
2020-10-07 15:58:30 -04:00
Asher
a44b4455f5
Read plugin name from package.json
2020-10-07 12:54:48 -05:00
Asher
c2ac126a50
Log all plugin errors as errors
2020-10-07 12:25:42 -05:00
Asher
ddda280df4
Rename plugin vars and make both colon-separated
...
Only one was colon separated but now they both are.
2020-10-07 12:18:57 -05:00
Asher
7a982555a8
Add version to plugin load log
2020-09-30 15:52:40 -05:00
Asher
e64b186527
Add variables to better customize plugin directories
2020-09-30 15:52:39 -05:00
Asher
11eaf0b470
Fix being unable to use [::] for the host
...
Fixes #1582 .
2020-09-30 12:49:36 -05:00
Asher
8b5deac92b
Fix 80 getting dropped from bind-addr
2020-09-30 11:57:23 -05:00
Asher
9d87c5328c
Add robots.txt ( #2080 )
...
Closes #1886 .
2020-09-14 17:34:48 -05:00
Anmol Sethi
cc5ed1eb57
Allow installing extensions from the CLI while $VSCODE_IPC_HOOK_CLI
...
Closes #2083
2020-09-11 11:49:22 -04:00
Asher
0a2328c1f6
Don't require auth for healthz ( #2055 )
...
* Don't require authentication for healthz endpoint
* Add FAQ entry for /healthz
2020-09-08 13:59:01 -05:00
Asher
617cd38c71
Fix my bad conflict resolution from the github ui
2020-08-31 11:10:12 -05:00
Jacob Goldman
75c8fdeed2
Added /healthz JSON response for heartbeat data. #1940 ( #1984 )
2020-08-31 10:29:12 -05:00
Asher
ce8577b1c3
Remove open-in flag ( #2013 )
2020-08-27 15:04:37 -05:00
shayne
ceb2265b14
Allow opening files, folders, and workspaces in existing code-server from CLI ( #1994 )
...
Add initial support for opening files / folders in running code-server instance.
Current limitations:
- unable to open a file in a new window, only folders
- unable to use addMode feature
- others...
2020-08-27 13:06:21 -05:00
Anmol Sethi
864a9e7bd6
Merge pull request #1999 from cdr/update
...
Update dependencies in package.json
2020-08-27 13:17:18 -04:00
Asher
eebb8bb314
Add proposed API flag ( #2002 )
...
Co-authored-by: giddyuptiger <65830808+giddyuptiger@users.noreply.github.com>
2020-08-26 14:18:40 -05:00
Anmol Sethi
ebbb1187da
Update remaining dependencies
2020-08-26 14:27:30 -04:00
Anmol Sethi
c8f63b61c4
Fix fmt and lint
2020-08-26 14:21:37 -04:00
Asher
e237589f2e
Update VS Code to 1.48.0 ( #1982 )
2020-08-25 13:06:41 -05:00
Asher
74910ffcdf
Hotswap on SIGUSR1 ( #1970 )
2020-08-17 14:17:55 -05:00
Asher
3c90b1e327
Merge pull request #1969 from cdr/qol
...
qol changes
2020-08-17 14:17:29 -05:00
Asher
0dcf469725
Add @version information to --help
...
This mimics a recent change in VS Code's help. See #1965 .
2020-08-13 18:08:35 -05:00
Asher
d8568ebaa9
Enforce import order
2020-08-13 17:11:35 -05:00
Asher
f7790c9719
Remove unused deep merge code
2020-08-13 17:11:34 -05:00
Asher
150d37868a
Enforce strict equals
2020-08-13 17:11:33 -05:00
Asher
de568d446b
Add cookie domain debug logs
...
To help debug login issues.
2020-08-13 17:06:32 -05:00
Asher
7d02f34f71
Merge pull request #1934 from cdr/plugin
...
Add plugin system for adding http endpoints
2020-08-13 16:59:44 -05:00
G r e y
6e27869c09
Add str param to plural util
...
Adds a str param to common/util::plural for pluralizing a string.
Applies plural to entry.ts.
2020-08-09 00:06:18 -05:00
Asher
9b979ac869
Document code-server injection
2020-08-05 13:00:37 -05:00
Asher
543d64268d
Simplify valid path check
2020-08-05 13:00:34 -05:00
Asher
fd36f8c168
Use error log level for plugin load failure
2020-08-05 13:00:33 -05:00
Asher
361e7103ea
Enable loading external plugins
2020-07-31 17:42:48 -05:00
Asher
bac948ea6f
Add plugin system
2020-07-31 15:08:02 -05:00
Asher
5370f7876d
Merge pull request #1927 from cdr/dead-code
...
Remove dead code
2020-07-31 12:25:56 -05:00
futengda
ecb9bb2428
refactor: write lastVisited
and query
at the same time
...
In addition, the `settings.write` method now uses shallow merge by default
2020-07-31 12:25:20 +08:00
Asher
e86c066438
Add helper functions to make some code clearer
2020-07-30 12:14:31 -05:00
futengda
b6e791f7d0
refactor: write route.query via settings.write
...
I added a shallow parameter, because the query should not be extends, but should be replaced directly.
2020-07-30 16:54:02 +08:00
Asher
2fa5037859
Log output to disk
2020-07-29 18:48:07 -05:00
Asher
7c2ca7d03e
Add the ability to prepend to the proxy path
...
This is for applications like Jupyter that aren't base path agnostic.
2020-07-29 18:48:06 -05:00
Asher
c67d31580f
Include details if any in JSON requests
2020-07-29 18:48:05 -05:00
Asher
58bd7008b4
Make dispose async
2020-07-29 18:48:04 -05:00
Asher
554b6d6fcf
Remove apply portion of update endpoint
...
It can still be used to check for updates but will not apply them.
For now also remove the update check loop in VS Code since it's
currently unused (update check is hardcoded off right now) and won't
work anyway since it also applies the update which now won't work. In
the future we should integrate the check into the browser update
service.
2020-07-29 18:48:02 -05:00
fxxjdedd
5ba650bb6f
feat: persist route query to local
...
Provide a way for the shell script running in the docker container to get the url query.
2020-07-28 20:14:52 +08:00
Asher
e8f6d30055
Make providers endpoint-agnostic
...
A provider can now be registered on multiple endpoints (or potentially
moved if needed).
2020-07-27 12:00:48 -05:00
Asher
2819fd51e2
Remove unused endpoints
...
- dashboard
- app api
2020-07-27 12:00:42 -05:00
Anmol Sethi
c00f931500
Remove zip library dependency
2020-06-03 18:24:59 -04:00
Anmol Sethi
85ad7e4fb4
Remove duplicate log
...
Also confirmed that #1750 is fixed.
2020-06-03 15:45:17 -04:00
Anmol Sethi
11d7932968
Stop bundling libraries in release
...
- Instead we now use CentOS 7 for the static build to guarantee
that we only depend on libc v2.17
- For macOS we now pull in a static node binary and bundle that instead.
2020-06-03 15:45:16 -04:00
Anmol Sethi
2c2a6498af
Parse config file in entry
...
This way setting --data-dir and --extension-dir in the config file
will work for --install--extension and whatnot.
2020-06-03 15:45:16 -04:00
Anmol Sethi
7ab47b3d83
Trim LD_LIBRARY_PATH on startup
2020-06-03 15:45:16 -04:00
Anmol Sethi
9d0dcf3c44
Fix extension install path for CLI
...
Closes #1713
2020-05-27 14:28:40 -04:00
Anmol Sethi
8053ec6872
Allow user-data-dir and extension-dir in config.yaml
...
Closes #1676
2020-05-19 00:41:27 -04:00
Asher
f7f11ad6c2
Fix paths from Windows client to non-Windows server
...
Fixes #1659
Fixes #1642
2020-05-18 15:06:11 -05:00
Anmol Sethi
6a25b3bfa0
Document structure better
...
Closes #1648
2020-05-17 16:53:08 -04:00
Anmol Sethi
73b2ff0945
$PORT should always override port in --bind-addr
2020-05-14 22:33:12 -04:00
Anmol Sethi
40778b15ca
Add code-server version into VS Code about
...
Closes #1506
2020-05-14 22:33:12 -04:00
Anmol Sethi
c69346a9a7
Add FAQ entry on the config file
2020-05-14 18:35:35 -04:00
Anmol Sethi
5651201643
Copy old macOS data directory if applicable
2020-05-14 06:12:33 -04:00
Anmol Sethi
a0a77e379e
Add doc/guide.md
2020-05-14 05:24:23 -04:00
Anmol Sethi
c0d6eb4664
Improve password handling
...
- Error out if auth is enabled but no password is passed in
- Indicate password location on login page
2020-05-12 19:59:55 -04:00
Anmol Sethi
1e432b25ea
Comment on hash(password)
2020-05-12 19:59:54 -04:00
Anmol Sethi
d6ea9d78f6
Configuration file bug fixes based on @code-asher's review
2020-05-12 19:59:54 -04:00
Anmol Sethi
d288131a33
Fix lint errors
2020-05-12 19:59:54 -04:00
Anmol Sethi
e02d94ad2f
Allow password authentication in the config file
2020-05-12 19:59:54 -04:00
Anmol Sethi
4f67f4e096
Disable automatic updates
2020-05-12 19:59:54 -04:00
Anmol Sethi
00d164b67f
Add default config file and improve config/data directory detection
2020-05-12 19:59:54 -04:00
Anmol Sethi
c5179c2a06
Add support for a YAML config file
2020-05-12 19:59:53 -04:00
Anmol Sethi
be032cf735
Add NPM package, debs, rpms and refactor CI/build process
...
Closes many issues that I'll prune after adding more docs
for users.
2020-05-06 20:25:52 -04:00
Asher
0a2f06b296
Update diff command in readme
2020-05-05 12:33:08 -05:00
Anmol Sethi
1898dea314
Unset $PASSWORD after grabbing it
...
Closes #1583
2020-05-04 22:41:21 -04:00
Asher
fd36a99a4c
Update vscode patch notes and bump version
2020-04-29 15:22:11 -05:00
Asher
a2b69c8f3f
Fix inconsistencies in log flags and env var
...
- Fix priority to match the commented behavior.
- Ignore bogus LOG_LEVEL values.
2020-04-28 17:57:55 -05:00
Anmol Sethi
a96606e589
Fix mention of host/port in docs
2020-04-28 18:29:25 -04:00
Anmol Sethi
37184f456c
Merge pull request #1562 from cdr/bindaddr
...
Deprecate --host and --port in favour of --bind-addr
2020-04-28 14:33:38 -04:00
Anmol Sethi
5accf3fe5f
Add basic rate limiting to login endpoint
...
Closes #1320
2020-04-28 14:21:08 -04:00
Anmol Sethi
af28885ea6
Deprecate --host and --port in favour of --bind-addr
2020-04-28 14:19:24 -04:00
Anmol Sethi
d0d5461a67
Remove SSH server
...
Closes #1502
2020-04-27 09:27:45 -04:00
Asher
27ba64c7e4
Improve request error handling
...
See #1532 for more context.
- Errored JSON requests will get back the error in JSON instead of using
the status text. This seems better to me because it seems more correct
to utilize the response body over hijacking the status text. The
caller is expecting JSON anyway. Worst of all I never actually set the
status text like I thought I did so it wasn't working to begin with.
- Allow the update error to propagate for JSON update requests. It was
caught to show the error inline instead of an error page when using
the update page but for JSON requests it meant there was no error and
no error code so it looked like it succeeded.
- Make errors for failed requests to GitHub less incomprehensible.
Previously they would just be the code which is no context at all.
2020-04-17 15:16:10 -05:00
Asher
974d4cb8fc
Allow specifying a workspace on the command line
...
Fixes #1535 .
2020-04-16 11:56:46 -05:00
Asher
28e91ba70c
Fix domain issues when setting the cookie
...
Fixes #1507 .
2020-04-13 16:14:40 -05:00
Asher
5aded14b87
Merge pull request #1453 from cdr/proxy
...
HTTP proxy
2020-04-08 12:44:29 -05:00
Asher
a288351ad4
Respond when proxy errors
...
Otherwise the request will just hang.
2020-04-08 11:54:18 -05:00
Asher
a5c35af81b
Fix encoding issues with folder and workspace params
...
The raw value is now passed back to VS Code so it can do the parsing
with its own URI class rather than trying to parse using Node's url
module first since that has no guarantee of working the same way. It
also lets us keep the vscode-remote bit internal to VS Code.
Removed the logic that keeps trying paths until it finds a valid one
because it seems confusing to open a path and silently get some other
path instead of an error for the one you tried to open. Now it'll just
use exactly what you specified or fail trying.
Fixes #1488 . The problem here was that url.parse was encoding the spaces
then the validation failed looking for a literal %20.
2020-04-07 15:18:19 -05:00
Asher
d1445a8135
Back up code-server directory when updating
2020-04-02 16:21:48 -05:00
Asher
a5d1d3b90e
Move proxy logic into main HTTP server
...
This makes the code much more internally consistent (providers just
return payloads, include the proxy provider).
2020-04-02 13:40:29 -05:00
Asher
aaa6c279a1
Use Set for proxy domains
2020-04-02 13:40:28 -05:00
Asher
498becd11f
Use route.fullPath when adding trailing slash
...
There's no need to specially construct the path.
2020-04-02 13:40:27 -05:00
Asher
411c61fb02
Create helper for determining if route is the root
2020-04-02 13:40:26 -05:00
Asher
74a0bacdcf
Rename hxxp to isHttp
2020-04-02 13:40:25 -05:00
Asher
e7e7b0ffb7
Fix redirects through subpath proxy
2020-04-02 13:40:25 -05:00
Asher
fd339a7433
Include query parameters when proxying
2020-04-02 13:40:24 -05:00
Asher
561b6343c8
Ensure a trailing slash on subpath proxy
2020-04-02 13:40:23 -05:00
Asher
737a8f5965
Catch proxy errors
...
Otherwise they'll crash code-server.
2020-04-02 13:40:21 -05:00
Asher
c0dd29c591
Fix domains with ports & localhost subdomains
2020-04-02 13:40:20 -05:00
Asher
8aa5675ba2
Implement the actual proxy
2020-04-02 13:40:19 -05:00
Asher
2086648c87
Only handle exact domain matches
...
This simplifies the logic a bit.
2020-04-02 13:40:18 -05:00
Asher
3a98d856a5
Handle authentication with proxy
...
The cookie will be set for the proxy domain so it'll work for all of its
subdomains.
2020-04-02 13:40:17 -05:00
Asher
90fd1f7dd1
Add proxy provider
...
It'll be able to handle /proxy requests as well as subdomains.
2020-04-02 13:40:16 -05:00
Asher
77ad73d579
Set domain on cookie
...
This allows it to be used in subdomains.
2020-04-02 13:40:15 -05:00
Asher
13534fa0c0
Add proxy-domain flag
...
This will be used for proxying ports.
2020-04-02 13:40:14 -05:00
Asher
37299abcc9
Minor startup code improvements
...
- Add type to HTTP options.
- Fix certificate message always saying it was generated.
- Dedent output not directly related to the HTTP server.
- Remove unnecessary comma.
2020-04-02 13:40:13 -05:00
Asher
a4c0fd1fdc
Run ssh server listen after http
...
That way if they happen to conflict code-server doesn't crash.
2020-03-30 17:43:11 -05:00
Asher
6c104c016e
Prevent exiting when an exception is uncaught
2020-03-30 17:43:10 -05:00
Asher
599670136d
Output commit along with the version
2020-03-30 17:43:09 -05:00
Asher
ce637d318d
Add descriptions to SSH flags
2020-03-30 17:43:08 -05:00
Asher
0a5687bacf
Fix crash when unable to request an update
2020-03-25 15:00:35 -05:00
Asher
d1687c1533
Catch error when SSH server fails to start
2020-03-24 17:38:46 -05:00
Asher
b52fbb4cb9
Catch error when openssl isn't installed
2020-03-16 15:14:54 -05:00
Will O'Beirne
3463d56114
SSH server & endpoint
2020-03-16 15:14:53 -05:00
Asher
d192726e80
Simplify dashboard
2020-03-16 15:14:50 -05:00
Asher
d832f61d5b
Make client-side extensions work at any base
2020-03-16 12:04:09 -05:00
Asher
6cb228037b
Add base path to update endpoint from VS Code
...
This will make it work regardless of what the current URL happens to be.
Also move the telemetry setting into the options since we might as well
make use of it seeing as how we have to parse it for the base path
anyway.
2020-03-13 16:44:56 -05:00
Asher
a00fa85d77
Qualify extensions in help output as VS Code extensions
...
Also add a description for uninstall-extension and force.
2020-03-13 13:23:30 -05:00
Asher
57de78e12a
Add show-versions flag and add help for list-extensions
...
Closes #1417 .
2020-03-13 13:17:59 -05:00
Asher
2342443368
Set telemetry setting based on disable-telemetry flag
...
By design the disable-telemetry flag does not affect extension
telemetry, only the setting does, so disabling the setting when the flag
is set should cause extensions to also stop sending telemetry.
Fixes #1116 .
2020-03-13 12:36:57 -05:00
Asher
253cf1c438
Remove unnecessary return types
2020-03-11 16:06:32 -05:00
Asher
0b9a478289
Add connection type to websocket query parameters
...
This allows external services to distinguish between them.
2020-03-05 15:49:37 -06:00
Asher
1f6ff2f763
Show --install-extension in help menu
...
Also add --force so extensions can be updated without prompts.
Closes #1392 .
2020-03-05 10:42:49 -06:00
Asher
04542c99fd
Resolve passed-in directory
...
Makes relative paths work correctly.
2020-03-05 10:38:13 -06:00
Asher
308a84e6ec
Fix centos image for arm64
2020-03-04 13:12:03 -06:00
Asher
e0e019fbd5
Fix mime type for compressed client-side extensions
...
In Firefox using the gzip mime type will (probably correctly) cause it
not to decompress while in Chromium it still will (incorrectly).
2020-03-02 18:24:35 -06:00
Asher
77af2a5b0e
Fix worker require paths when behind proxy
2020-03-02 18:04:27 -06:00