Commit Graph

9 Commits

Author SHA1 Message Date
videlanicolas
3df771fbc4
Check the logged user instead of $USER (#3330)
* Check the logged user instead of $USER

Given that `sudo usermod --login "$DOCKER_USER" coder` and `sudo groupmod -n "$DOCKER_USER" coder` modify the container's disk it'll persist across restarts, but environment variables will be reset to whatever state they had at the end of `Dockerfile`. In this case, `$USER` is set to `coder`, so this branch will always be true.

By checking with the output of `whoami`, which gets it's information from `/etc/passwd`, we make sure to get the real logged user and not the one defined by $USER.

We also move `USER="$DOCKER_USER"` out of the branch, since we always want this to happen at entry-point. If we don't do this assignment, $USER will contain `coder` upon restart.

* Update entrypoint.sh

Check `$DOCKER_USER` was defined before copying it to `$USER`.
2021-05-11 10:26:38 -05:00
Joe Previte
d05389880a
chore: update formatting w/new prettier sh plugin 2021-03-15 15:36:31 -07:00
Anmol Sethi
32c5ed8a33
release-image: Ignore $DOCKER_USER on restart (#2458)
Closes #2267
2020-12-14 13:57:36 -05:00
Anmol Sethi
79443c14ff
release-image: Remap UID within the image before handling $DOCKER_USER (#2223)
If do not update the UID within the passwd database to match whatever
uid the container is being ran as, then sudo will not work when renaming
the user to match $DOCKER_USER as it will complain about the current
user being non-existent.
2020-10-23 12:07:08 -04:00
Anmol Sethi
4a3d2e5a94
Remove unnecessary whoami
Closes #2213
2020-10-21 16:40:25 -04:00
Anmol Sethi
ea105a9290
Fix release image entrypoint.sh 2020-10-12 04:26:36 -04:00
Anmol Sethi
eacca7d692
Unrelated fixes for CI 2020-10-07 15:58:30 -04:00
Anmol Sethi
9fb318cf15
docker: Fix $DOCKER_USER (#2057)
We do not try renaming $HOME anymore as there is no good way
to do it.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056
2020-09-03 18:38:40 -04:00
Anmol Sethi
4c4a7413a1
docker: Allow passing $DOCKER_USER to set the username in the container
Needs to be reflected in the documentation and the dockerhub description now.

Closes #881
2020-08-27 14:20:56 -04:00