Commit Graph

2800 Commits

Author SHA1 Message Date
Joe Previte
7ad536b5e9
feat(test): check login.ts when base missing 2021-07-02 14:57:16 -07:00
Joe Previte
b365830388
Merge pull request #3713 from cdr/jsjoeio-test-emitter
feat(test): try calling .dispose() x2 in emitter
2021-07-02 14:44:58 -07:00
Joe Previte
f3c4dcd074
feat(test): try calling .dispose() x2 in emitter 2021-07-02 14:27:12 -07:00
Joe Previte
58514c422f
Merge pull request #3711 from cdr/jsjoeio-fix-link
chore: fix broken link in install.sh
2021-07-02 13:15:08 -07:00
Joe Previte
002fa08222
chore: fix broken link in install.sh 2021-07-02 11:14:36 -07:00
Joe Previte
f8a1a1ce02
Merge pull request #3707 from cdr/jsjoeio-fix-alpine-install-script
fix: update install script for alpine
2021-07-02 10:45:14 -07:00
Joe Previte
908b2c8502
fix: use new docs links in install script 2021-07-02 10:29:49 -07:00
Joe Previte
5a6af17725
fix: modify install script for alpine 2021-07-01 15:50:31 -07:00
Joe Previte
1ff09b814e
Merge pull request #3706 from cdr/jsjoeio-update-docs-node-issues
docs(install): add troubleshooting node issues
2021-07-01 15:36:36 -07:00
Joe Previte
4ca4a26bec
docs(install): add troubleshooting node issues 2021-07-01 15:21:55 -07:00
Joe Previte
ad92287d7e
Merge pull request #3697 from cdr/jsjoeio-doc-env-requirements
docs(guide): add WebSockets to requirements
2021-07-01 14:50:53 -07:00
Joe Previte
975dd13d12
Merge pull request #3695 from cdr/jsjoeio-sanitize-error-msg
fix: escape error.message on login failure
2021-07-01 14:50:32 -07:00
Joe Previte
c0e123a801
fix(http): escape req.query.to in replaceTemplates 2021-07-01 10:43:37 -07:00
Joe Previte
2ba03c3424
docs: clarify redirect function in http.ts usage 2021-07-01 10:43:37 -07:00
Joe Previte
2092f82270
fixup! fix: escape error.message on login failure 2021-07-01 10:43:37 -07:00
Joe Previte
22a22a8f7a
fix: escape error.message on login failure 2021-07-01 10:43:37 -07:00
Joe Previte
c505fc45a8
feat: add escapeHtml function
This can be used to escape any special characters in a string with HTML before
sending from the server back to the client. This is important to prevent a
cross-site scripting attack.
2021-07-01 10:43:36 -07:00
Joe Previte
b009ad0633
docs(guide): add WebSockets to requirements 2021-07-01 10:37:32 -07:00
Joe Previte
faa896c12c
Merge pull request #3698 from cdr/jsjoeio-fix-argon-issue
fix(isHashMatch): check that hash starts with $
2021-07-01 10:33:29 -07:00
Joe Previte
4dcf3efeab
Merge pull request #3700 from cdr/jsjoeio-add-job-timeouts
fix: add timeouts to CI jobs
2021-07-01 09:59:52 -07:00
dependabot[bot]
bb1b129a24
chore(deps-dev): bump typescript from 4.3.4 to 4.3.5 (#3702)
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.4 to 4.3.5.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](https://github.com/Microsoft/TypeScript/compare/v4.3.4...v4.3.5)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-01 21:20:43 +05:30
Joe Previte
8695c874ed
fix: add timeouts to ci jobs 2021-06-30 15:16:55 -07:00
Joe Previte
7f12fab3ca
fix(isHashMatch): check that hash starts with $
Previously, we used argon2 to verify the hash with the password.

If the hash didn't start with a $, then it would enter the catch block.

Now we check the hash before trying to verify it and we also throw an Error if
the verify fails.

This makes the isHashMatch function more robust.
2021-06-30 15:00:21 -07:00
CoderErik
e9d4f877f9
Update links to careers page (#3696) 2021-06-30 11:14:04 -05:00
Ben Potter
d2f0e1738d
Merge pull request #3691 from cdr/bpmct/readme-fix
docs: fix relative link to guide
2021-06-29 16:57:13 -04:00
Joe Previte
df814aa39a
Merge pull request #3692 from elliott-king/patch-1
Fix broken link on docs site
2021-06-29 13:52:37 -07:00
Elliott King
33dbb7b707
Fix broken link on docs site
Links don't work on docs site unless they have md formatting.
2021-06-29 16:43:57 -04:00
Ben Potter
f194c14e6c
docs: fix relative guide link 2021-06-29 14:36:25 -04:00
Bruno Quaresma
6dbabc0951
docs: Update README to point to code-server docs site (#3684) 2021-06-29 15:25:22 -03:00
Asher
f92cbb7470
Merge pull request #3664 from code-asher/parallel-tests 2021-06-29 12:24:55 -05:00
Asher
2238d7391e
Fix occasional logout failure
It seems a dialog sometimes appears asking if you want to lose
changes (even though we have no changes; it seems based on timers in
some way). Playwright defaults to dismissing them (so quickly you might
not even see them) so accepting instead fixes navigation to the logout
page getting canceled.
2021-06-29 12:06:48 -05:00
Asher
43c6ffcb8f
Remove login steps from logout test
I figure login is already tested so we can skip this and just use the
cookie.
2021-06-29 12:06:47 -05:00
Asher
49c7cc6e8a
Retain failed e2e videos only 2021-06-29 12:06:46 -05:00
Asher
f2fa7701a9
Centralize credential handling
My thinking is that this may reduce the cognitive overhead for
developers writing new test suites.

This also allows us to perform different setup steps (like ensuring the
editor is visible when authenticated).
2021-06-29 12:06:45 -05:00
Asher
da4de439e0
Spawn a code-server instance for each test suite
This uses the current dev build by default but can be overidden with
CODE_SERVER_TEST_ENTRY (for example to test a release or some other
version).

Each instance has a separate state directory. This should make
parallelization work.

This also means you are no longer required to specify the password and
address yourself (or the extension directory once we add a test
extension). `yarn test:e2e` should just work as-is.

Lastly, it means the tests are no longer subject to yarn watch randomly
restarting.
2021-06-29 12:06:38 -05:00
Asher
49c44818d9
Move onLine to utilities
This way it can be used by the tests when spawning code-server on a
random port to look for the address.
2021-06-29 12:04:31 -05:00
Asher
add55ecd62
Import utils as a group in tests
This should simplify testing new utils a bit.
2021-06-29 12:03:38 -05:00
Asher
ba0364a522
Run each e2e test in a new workspace
The workspaces also have settings to prevent the welcome page from
appearing.
2021-06-29 12:03:37 -05:00
dependabot[bot]
4a47ce774d
chore(deps-dev): bump @typescript-eslint/parser from 4.28.0 to 4.28.1 (#3688)
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.28.0 to 4.28.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.28.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-29 21:34:51 +05:30
dependabot[bot]
4131b3fb05
chore(deps-dev): bump @typescript-eslint/eslint-plugin (#3689)
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.28.0 to 4.28.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.28.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-29 18:04:19 +05:30
dependabot[bot]
7e32b8fb86
chore(deps): bump ws from 7.4.6 to 7.5.1 (#3690)
Bumps [ws](https://github.com/websockets/ws) from 7.4.6 to 7.5.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/7.4.6...7.5.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-29 18:02:12 +05:30
Joe Previte
e1d291e59c
Merge pull request #3658 from cdr/jsjoeio/migrate-parcel
chore(dev): migrate away from parcel and replace with browserify
2021-06-28 12:04:10 -07:00
Joe Previte
6e1455da88
feat: add custom codecov 2021-06-28 11:41:48 -07:00
Joe Previte
b597519ab5
feat(test): add tests for src/browser/login 2021-06-28 11:41:48 -07:00
Joe Previte
be7ea8f3f7
refactor: migrate parcel to browserify
This also refactors a couple CSS stylesheets to be referenced directly in the
HTML files.

And it removes any CSS imports from src/browser files.
2021-06-28 11:41:45 -07:00
Joe Previte
df01808d4d
Merge pull request #3640 from cdr/jsjoeio/add-test-nlsConfig
refactor: add func and tests for getNlsConfiguration
2021-06-28 11:40:43 -07:00
Joe Previte
a7a6d7e22a
Merge pull request #3659 from cdr/jsjoeio/update-android-docs
docs(termux): add backspace workaround for android
2021-06-28 10:05:46 -07:00
Joe Previte
a355012560
Merge pull request #3660 from cdr/jsjoeio/docs-update-changelog-process
docs(MAINTAINING): update changelog process
2021-06-28 10:04:51 -07:00
dependabot[bot]
95536fafa9
chore(deps-dev): bump prettier from 2.3.1 to 2.3.2 (#3679)
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-28 22:07:28 +05:30
dependabot[bot]
9042bbae9a
chore(deps-dev): bump prettier-plugin-sh from 0.6.1 to 0.7.1 (#3680)
* chore(deps-dev): bump prettier-plugin-sh from 0.6.1 to 0.7.1

Bumps [prettier-plugin-sh](https://github.com/rx-ts/prettier) from 0.6.1 to 0.7.1.
- [Release notes](https://github.com/rx-ts/prettier/releases)
- [Changelog](https://github.com/rx-ts/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rx-ts/prettier/compare/prettier-plugin-sh@0.6.1...prettier-plugin-sh@0.7.1)

---
updated-dependencies:
- dependency-name: prettier-plugin-sh
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: reformat shell scripts

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Akash Satheesan <akash.satheesan@protonmail.com>
2021-06-28 22:06:55 +05:30