cubetiq/code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,333 Commits 10 Branches 48 Tags
bb0414e7bb37ba0e0bb280a6f3ace27fb16bcc06
Commit Graph

567 Commits

Author SHA1 Message Date
Asher
2fe3d57df3 Mount plugins before bodyParser 
Otherwise it consumes the body and plugins won't be able to do things
like proxy POST requests.
 2021-02-09 13:09:39 -06:00
Asher
c78f56b334 Expose HttpError to plugins 
This will let them throw and show nice errors more easily.
 2021-02-09 13:09:38 -06:00
Asher
22d194515a Expose replaceTemplates to plugins 
This is mainly so they can get relative paths in their HTML, in
particular code-server's static base so they can use the favicon and
service worker.
 2021-02-09 13:09:37 -06:00
Asher
36aad9bdab Move global express args definition 
This way tests that import the http utilities but not the routes won't
error due to missing types.
 2021-02-09 13:09:36 -06:00
Asher
5505959f7e Expose websocket server to plugins 
Same reasoning used when exposing Express.
 2021-02-09 13:09:34 -06:00
Asher
b13db3124b Add health websocket 
This is used by some of our services.
 2021-02-09 13:09:33 -06:00
Asher
f136a60093 Note that we immediately pause websockets 2021-02-09 13:09:32 -06:00
Asher
00cfd9bdf1 Add working directory to plugin config 2021-02-09 13:09:31 -06:00
Asher
3211eb1ce5 Expose log level to plugins 
In case they need to map it to something else.
 2021-02-09 13:09:30 -06:00
Asher
017b1cc633 Add deinit for plugins 2021-02-09 13:09:29 -06:00
Asher
3c6fac9ce4 Wait for inner process to exit 2021-02-09 13:09:28 -06:00
Asher
055e0ef9ec Provide WsRouter to plugins 2021-02-09 13:09:27 -06:00
Asher
fb37473e72 Load only test plugin during tests 
The other plugins in my path were causing the tests to fail.
 2021-02-09 12:20:30 -06:00
Asher
f6b04c7c29 Expose proxy server to plugins 2021-02-09 12:19:39 -06:00
Asher
a8e928798b Re-export express for plugins 2021-02-09 12:19:38 -06:00
Asher
5f1fab7d27 Re-export logger field for plugins 2021-02-09 12:19:36 -06:00
Joe Previte
719481e84e refactor: add getPackageJson fn in constants 2021-02-08 16:21:30 -07:00
Anmol Sethi
05a0f213a7 Update proxy path passthrough documentation 
Includes updated create-react-app docs.

Closes #2565
 2021-02-05 11:44:38 -05:00
Anmol Sethi
c08e3bb06d Add /absproxy to remove --proxy-path-passthrough 
See https://github.com/cdr/code-server/issues/2222#issuecomment-765235938

Makes way more sense.
 2021-02-05 11:44:34 -05:00
Anmol Sethi
58d72d53a1 routes/index.ts: register proxy routes before body-parser 
Any json or urlencoded request bodies were being consumed by body-parser
before they could be proxied. That's why requests without Content-Type
were proxied correctly as body-parser would not consume their body.

This allows the http-proxy package to passthrough the request body correctly
in all instances.

Closes #2377
 2021-02-01 11:08:40 -05:00
Anmol Sethi
f5cf3fd331 proxy.ts: Do not always rewrite redirects against the base path 
This breaks --proxy-path-passthrough

However, we still need this when that code is disabled as many apps will
issue absolute redirects and expect the proxy to rewrite as appropriate.

e.g. Go's http.Redirect will rewrite relative redirects as absolute!
See https://golang.org/pkg/net/http/#Redirect
 2021-02-01 11:08:40 -05:00
Joe Previte
646ee3ad7f refactor: correct type signature in app.ts 2021-01-21 10:11:56 -07:00
Joe Previte
6bf51caa17 fix(app.ts): resolve with server 2021-01-21 10:11:10 -07:00
Joe Previte
f13ba9401b fix(TS error): add void to promise in util 2021-01-21 10:11:10 -07:00
Anmol Sethi
28e98c0ee0 Merge pull request #2563 from cdr/proxy-path-passthrough-0bb9 
pathProxy.ts: Implement --proxy-path-passthrough
 2021-01-20 02:44:29 -05:00
Anmol Sethi
c32d8b155f heart.ts: Fix leak when server closes 
This had me very confused for quite a while until I did a binary search
inspection on route/index.ts. Only with the heart.beat line commented
out did my tests pass without leaking.

They weren't leaking fds but just this heartbeat timer and node of
course prints just fds that are active when it detects some sort of leak
I guess and that made the whole thing very confusing. These fds are not
leaked and will close when node's event loop detects there are no more
callbacks to run.

no of handles 3

tcp stream {
  fd: 20,
  readable: false,
  writable: true,
  address: {},
  serverAddr: null
}

tcp stream {
  fd: 22,
  readable: false,
  writable: true,
  address: {},
  serverAddr: null
}

tcp stream {
  fd: 23,
  readable: true,
  writable: false,
  address: {},
  serverAddr: null
}

It kept printing the above text again and again for 60s and then the
test binary times out I think. I'm not sure if it was node printing the
stuff above or if it was a mocha thing. But it was really confusing...

cc @code-asher for thoughts on what was going on.

edit: It was the leaked-handles import in socket.test.ts!!!
Not sure if we should keep it, this was really confusing and misleading.
 2021-01-20 02:06:44 -05:00
Anmol Sethi
5c06646f58 Formatting and linting fixes 2021-01-20 02:06:44 -05:00
Anmol Sethi
240c8e266e test: Implement integration.ts for near full stack integration testing 2021-01-20 02:06:44 -05:00
Anmol Sethi
d3074278ca app.ts: Fix createApp to log all http server errors 
cc @code-asher
 2021-01-20 02:06:43 -05:00
Anmol Sethi
ba4a24809c routes/index.ts: Correctly register wsErrorHandler 
express requires all 4 arguments to be declared for a error handler.
It's very unfortunate that our types do not handle this.
 2021-01-20 02:06:43 -05:00
Anmol Sethi
f169e3ac66 pathProxy.ts: Implement --proxy-path-passthrough 
Closes #2222
 2021-01-20 02:06:43 -05:00
Anmol Sethi
d234ddc1e1 vscode.ts: Fix close current folder 
Fixes VscodeProvider to correctly obey the ew parameter.

Based on changes by @rdbeach. See the previous commit.
 2021-01-18 11:29:18 -05:00
Robert Beach
28c7340608 Fix Close Folder/Workspace (#2532) 
When you choose to close the current folder, it doesn't close properly
because the lastVisiited setting is still use. This fixes that.
 2021-01-18 11:28:29 -05:00
Anmol Sethi
f15580b28a favicon: Add dark mode support 
Closes #2538

Works as expected on latest Firefox and Chromium.
 2021-01-11 12:54:25 -05:00
Anmol Sethi
693fdbefb4 browser: Add favicon.afdesign 
It requires git-lfs to pull down if you want to adjust the favicon and
also the affinity designer software available only on Windows and Mac.

Might be a good idea to switch to Figma at some point and commit a
.fig file.
 2021-01-08 23:03:34 -05:00
Asher
f763319bc3 Merge pull request #2160 from cdr/github-auth 
Fix GitHub auth
 2020-12-18 10:54:51 -08:00
Anmol Sethi
cb446666fa Merge pull request #2487 from cdr/proxy-docs-86d4 
proxy-agent: Use proxy-from-env and add docs
 2020-12-18 13:06:47 -05:00
Asher
5f7f7f1a92 Simplify query concatenation in URL callback 
Cases in URLs like ?&a=b or ?a=b& appear to be handled just fine.
 2020-12-18 11:31:25 -06:00
Asher
d14c2e5bb7 Swap negative check for positive check 2020-12-18 11:21:06 -06:00
Anmol Sethi
60c270aef5 cli: hashedPassword -> hashed-password (#2454) 
Capital letters in the CLI are evil.

cc @code-asher
 2020-12-18 12:20:38 -05:00
Anmol Sethi
ae902b9dd1 proxy_agent: Use proxy-from-env for robustness 
Now we support pretty much every variable under the sun along with
$NO_PROXY all correctly and with minimal code on our end.
 2020-12-18 11:10:07 -05:00
Anmol Sethi
94b4ba131e proxy_agent: Implement $HTTPS_PROXY 
Just convention, see https://golang.org/pkg/net/http/#ProxyFromEnvironment
 2020-12-18 10:39:31 -05:00
Anmol Sethi
ecb4d07364 proxy_agent: Improve documentation 2020-12-18 10:38:46 -05:00
Anmol Sethi
3efd515cdf proxy_agent: Fix very embarrassing mistake 2020-12-18 04:24:27 -05:00
Asher
58c1be57fa Implement callback endpoints 
VS Code uses these during the authentication flow.
 2020-12-17 15:49:36 -06:00
Asher
f8b782bd68 Move ignore-last-opened to ipc.d.ts 
This is so it can be used in VS Code. Don't tell anyone but I forgot to
run `yarn ci`.
 2020-12-15 11:14:21 -06:00
Joe Previte
cc584f86b9 Merge pull request #2435 from cdr/issue-2328-customize-go-home 
cli: add --home flag to customize "Go Home" button
 2020-12-15 09:52:39 -07:00
JammSpread
f4ca41329a Add --ignore-last-opened option (#2434) 
This allows bypassing the last opened behavior for certain cases where that's not desirable.

Fixes #1951
 2020-12-15 10:22:58 -06:00
Joe Previte
8daba6ca80 feat: add home as a cli option 2020-12-14 16:23:35 -07:00
Anmol Sethi
244afa402e routes: Redirect from /login when auth is disabled (#2456) 
Sometimes I start with auth but then disable. Now I can just reload the
login page in my browser to be greeted with code-server.
 2020-12-14 12:33:36 -05:00