Asher
29f302128a
Merge pull request #2800 from cdr/no-default-home
2021-03-02 10:13:10 -06:00
Asher
058e781b3f
Await newly promisified func
2021-03-01 16:39:57 -06:00
Asher
c7d59e81dd
Add tabIndex to extension help dismiss button
...
This makes it accessible via keyboard.
2021-03-01 13:39:34 -06:00
Asher
6dd8b63f4c
Add div for inner extension helper text
...
The theme callback would set innerHTML on the header which wipes out the
dismiss button. With an inner div we can replace the inner HTML without
worrying about other elements in the header.
Closes #2799 .
2021-03-01 13:31:36 -06:00
Asher
9da9ff2372
Remove .ignore
...
This is preventing my ripgrep from searching vscode.
2021-03-01 13:16:10 -06:00
Asher
f526ab87f8
Remove default home value
...
Closes #2742 .
2021-03-01 13:16:09 -06:00
Joe Previte
726f694268
Merge pull request #2719 from cdr/add-tests-register
...
feat(testing): add unit tests for register
2021-02-26 16:47:51 -07:00
Joe Previte
a83c909b16
fix: update deps import in coder.js
2021-02-26 16:46:20 -07:00
Joe Previte
8c14799797
refactor: add custom mock for serviceWorker test
2021-02-26 16:05:35 -07:00
Joe Previte
6b56e6572d
feat(testing): add serviceWorker tests
2021-02-26 16:00:18 -07:00
Joe Previte
9dea2e79a0
chore: fix lint issues
2021-02-26 15:48:04 -07:00
Joe Previte
36136fe70d
chore: formatting
2021-02-26 15:46:31 -07:00
Joe Previte
019fe3c270
docs(contributing): update updating vscode
2021-02-26 15:46:09 -07:00
Joe Previte
9ea18636d7
Merge branch 'master' into upgrade-vscode-1.53
2021-02-26 14:23:24 -07:00
Joe Previte
5f3afbf7a9
fix: refactor performance in vscode.html
2021-02-26 14:16:46 -07:00
Joe Previte
1bf3036597
fix(connection): onClose -> onDidDispose protocol
2021-02-26 12:55:04 -07:00
Joe Previte
52acb50ed7
fix: update WebSocketNodeSocket in protocol
2021-02-26 12:54:29 -07:00
Joe Previte
22e7173fa9
fix: update resolveCommonProperties in server
2021-02-26 12:54:03 -07:00
Joe Previte
ee0973c05a
feat: add logs to serviceWorker
2021-02-26 11:58:29 -07:00
Joe Previte
46226ea26b
chore(testing): add service-worker-mock
2021-02-26 11:58:29 -07:00
Joe Previte
80a180079e
feat: add test for catching errors in Emitter
2021-02-26 11:58:29 -07:00
Joe Previte
b232dcbd4a
feat(register): add test when navigator undefined
2021-02-26 11:58:28 -07:00
Joe Previte
e6a324b484
refactor: update mocking logger in register test
2021-02-26 11:58:28 -07:00
Joe Previte
cb4185b360
refactor: use loggerModule in util
2021-02-26 11:58:28 -07:00
Joe Previte
1c737f1f93
refactor: hoist jest.mock in constants
2021-02-26 11:55:17 -07:00
Joe Previte
1470ff203a
refactor: dont use actual logger in helper
2021-02-26 11:55:17 -07:00
Joe Previte
711abd8d84
refactor: move loggerModule into helpers
2021-02-26 11:55:00 -07:00
Joe Previte
027e8e5adf
refactor: use LogModule from Asher in tests
2021-02-26 11:51:52 -07:00
Joe Previte
a44a51462c
refactor: use same syntax as logger spy
2021-02-26 11:51:52 -07:00
Joe Previte
7ef630f7a4
refactor(register): use logError instead of logger
2021-02-26 11:51:52 -07:00
Joe Previte
38891de0d9
feat(test): add test handleRegisterServiceWorker
2021-02-26 11:51:52 -07:00
Joe Previte
21f577d471
refactor: add handleRegisterServiceWorker fn
2021-02-26 11:51:52 -07:00
Joe Previte
44b9874fbe
feat: test failure to register service worker
2021-02-26 11:51:52 -07:00
Joe Previte
a9f88affa9
refactor: use logger in serviceworker
2021-02-26 11:51:51 -07:00
Joe Previte
06aeca0a83
feat(testing): add register test
2021-02-26 11:51:51 -07:00
Joe Previte
72b05cacac
refactor: create registerServiceWorker fn
2021-02-26 11:51:51 -07:00
Joe Previte
28b440a4ba
feat: add cssStub to jest
2021-02-26 11:51:51 -07:00
Joe Previte
4f1f2c7171
fix: clean up comment in util.test.ts
2021-02-26 11:50:27 -07:00
Joe Previte
63733c31e9
Merge pull request #2779 from cdr/vapurrmaid/chore-doc-structure-links
...
docs(contributing): Update links
2021-02-26 09:33:51 -07:00
Joe Previte
eaee7ed69d
Merge pull request #2762 from cdr/ci-docs-homebrew
...
docs(ci): update release steps with homebrew bump
2021-02-26 09:31:41 -07:00
Joe Previte
99af11ecc3
docs: add homebrew bump to release steps
2021-02-25 16:51:43 -07:00
Joe Previte
0f18d1fddc
fix: update import in channel.ts getSystemShell
2021-02-25 16:44:08 -07:00
Joe Previte
b71c5061e1
chore: update electron types
2021-02-25 16:43:53 -07:00
Joe Previte
b7e112a78d
chore: reorder package.json lib/vscode
2021-02-25 16:43:45 -07:00
G r e y
ad89ffaa59
docs(contributing): Update links
2021-02-25 13:55:55 -06:00
Joe Previte
e002f14423
revert: turn off two rules in eslint for vscode
2021-02-25 12:41:15 -07:00
Joe Previte
c6e6f8e2b3
chore: add missing semicolon in channel.ts
2021-02-25 12:41:01 -07:00
Joe Previte
38f555e218
chore: fix lint issues in update-vscode
2021-02-25 12:40:49 -07:00
Joe Previte
169b51e453
chore: run yarn fmt
2021-02-25 12:32:05 -07:00
Joe Previte
1b9ed6eea3
chore: update yarn.lock for vscode
2021-02-25 12:31:20 -07:00
