Commit Graph

121 Commits

Author SHA1 Message Date
Asher
546dd9c278
Catch getLayoutMap error (#3518)
This might be causing issues with the PWA showing a blank screen with
MacOS.
2021-06-01 16:04:26 -05:00
Joe Previte
604491d333
fix: use correct command to Open Folder on Welcome page (#3437)
* chore: update CHANGELOG

* fix: use openFolder in welcomePage

In 1.56.2, they modified the WelcomePage use of OpenFileFolder in
src/vs/workbench/contrib/debug/browser/welcomeView.ts to only use on macOS +
Desktop (i.e. not Web). This caused the "Open Folder" to not work on macOS +
macOS-like environments.

Instead, we use OpenFolder which is a registered command and works as expected.
2021-05-21 19:27:50 +00:00
Asher
b49b1796e9
Add socket type to websocket connection query (#3391)
This was added a long time ago but accidentally lost when we reverted
the retry changes to this file after one of the VS Code updates that
added their own retry (we reverted everything not realizing we had other
unrelated changes in here).
2021-05-14 15:05:05 -05:00
Akash Satheesan
74fbb425f2
fix(lib/vscode): update to 1.56.1 (#3351) 2021-05-12 01:15:06 +05:30
Asher
5d5ecdc795
Merge pull request #3308 from code-asher/pty-host-service 2021-05-07 14:12:37 -05:00
Asher
51d294e163
Remove extension dir scan catch
Now that we are creating the directories these shouldn't error. If they
are somehow missing (if the user deletes them after VS Code starts for
example) then I think we should surface that to the user.
2021-05-07 12:31:43 -05:00
Asher
9ff29d17fb
Make sure directories exist
Fixes #3040.
2021-05-07 12:31:42 -05:00
Asher
c416e9b2c4
Use ptyHostService
Most of this was a straightforward replacement of our code with theirs
but I also removed `getDefaultShellAndArgs` since it seems the reference
implementation no longer does that either.

Fixes #2276.
2021-05-07 12:31:24 -05:00
Akash Satheesan
372a8f14c5 Squashed 'lib/vscode/' changes from 631dbe250bc..cfa2e218100
cfa2e218100 Make sure we actually update the local resource roots (#122957)
206524cbf6f Merge pull request #122941 from microsoft/roblou/fix122701
0ce07162f07 Use the scoped context key service for notebook editor context keys Fix #122701
4fbe56e36b3 Merge pull request #122933 from microsoft/aeschli/122466
32a743d2af9 [JSON] Schema not found error on opening package.json. For #122279
0676e9a727e Fix port theme color typo (#122915)
85f8ebf1687 Fix context on LabelTunnelAction (#122856)
5913f53cab5 Block windows/iframes from preventing the unload (#122835) (#122869)
acd78c82ac6 Ensure that notebook cell URIs work (#122747)
4e185d89863 Merge pull request #122764 from microsoft/roblou/fix122407
7eb7814b56c Try to block webviews from cancelling unloads (#122758)
25092105030 Hardcode keybinding string to fix #122407
b084e6f4a73 Fix currently active indicator preventing editor switching (#122742)
bc2373aaa54 Merge pull request #122732 from microsoft/r156_tabs
d7a86f269a8 Disable tabs by default

git-subtree-dir: lib/vscode
git-subtree-split: cfa2e218100323074ac1948c885448fdf4de2a7f
2021-05-06 22:08:24 +05:30
Akash Satheesan
a631d19636
Merge branch 'main' into vscode-1.56 2021-05-05 23:28:25 +05:30
Akash Satheesan
ce26ad7c30
refactor(lib/vscode): move commit to global constant 2021-05-05 23:24:21 +05:30
Akash Satheesan
8cb55b5719
refactor(lib/vscode): don't provide home indicator 2021-05-05 23:21:11 +05:30
Akash Satheesan
70bf7ed90b fix(lib/vscode): fix terminal channel 2021-05-05 22:21:30 +05:30
Akash Satheesan
f10b703e84 fix(lib/vscode): fix types in server.ts 2021-05-05 22:21:30 +05:30
Akash Satheesan
84e12bd587 fix(lib/vscode): add home to workbench.ts 2021-05-05 22:21:29 +05:30
Akash Satheesan
96fe3c2734 fix(lib/vscode): conflicts in productService.ts 2021-05-05 22:21:29 +05:30
Akash Satheesan
532ae1451f fix(lib/vscode): conflicts in menubarControl.ts 2021-05-05 22:21:29 +05:30
Akash Satheesan
81357cf4b0 chore(lib/vscode): update electron types 2021-05-05 22:21:29 +05:30
Asher
a48ac5080b
Share common util code with VS Code
This lets us re-use the normalized base path so when we expire/clear the
cookie we use the same base path.
2021-05-04 13:29:40 -05:00
Asher
08ab0afdb0
Revert old logout code
This reverts commit 947dd8561b, reversing
changes made to 24dc2080f9.
2021-05-04 13:29:38 -05:00
Asher
eee637a104
Remove dead client code 2021-05-04 13:29:37 -05:00
Asher
bea13dd630
Add logout command and menu options 2021-05-04 13:29:34 -05:00
Asher
e7a527514a
Add authed context key 2021-05-03 15:00:54 -05:00
Akash Satheesan
ec8894d6c4 chore(vscode): update to 1.56.0 2021-04-30 20:25:17 +05:30
Asher
16fc315afa
Catch socket close during protocol handshake
zlib errors can cause the protocol handshake to not reject (until the
timeout).
2021-04-21 11:48:46 -05:00
Asher
f0bafa387f
Move connection logic into connection class
- Moved everything I could into the class itself.
- Improve the logging situation a bit.
- Switch some trace logs to debug.
- Get debug port from message arguments.
2021-04-21 11:48:45 -05:00
Asher
ae6089f852
Improve protocol class
- Move destroy logic into the class itself
- Improve logging a bit
- Remove the record option; we should always do this when using
  permessage-deflate.
- Let debug port be null (it can be null in the message args).
- Add setSocket so we don't have to initiate a connection to set it.
- Move inflate bytes logic into the class itself.
2021-04-21 11:48:43 -05:00
Akash Satheesan
578b2de131
chore(lib/vscode): clean up comments 2021-04-16 00:39:02 +05:30
Akash Satheesan
bdf555a06e
fix(lib/vscode): refactor productService 2021-04-16 00:14:16 +05:30
Akash Satheesan
8ffb87dbc9
fix(lib/vscode): restore localizatizons support 2021-04-16 00:06:38 +05:30
Akash Satheesan
9f256cd87a
fix(lib/vscode): fix lint errors 2021-04-14 18:58:41 +05:30
Akash Satheesan
093743e365
fix(.../platform/terminal): fix compile, add notes 2021-04-14 18:58:17 +05:30
Asher
5ebb096db5
Get terminals working
- Instead of a single listener per terminal that handles all events VS
  Code now has a single listener per event that handles that event for
  all terminals.
- Refactor Terminal to extend TerminalProcess to avoid duplicating
  methods. This required some modifications to TerminalProcess to access
  the pid and title and to set the ID.
- Remove our async change to shutdown. This was necessary to avoid
  disposing too early but shutdown already calls dispose so it turns out
  we didn't need to call it ourselves.
- Rename methods to match the command strings.
- Fix getting system shell (uses process.env).
- Use a single bufferer. Since it already supports buffering for
  multiple terminals there's no need to have one per terminal.
- Remove replay/reconnect logic. It's broken and unused so there doesn't
  seem much point in trying to refactor it to fit the changes right now.

While terminals work now there are still a lot of todos.
2021-04-13 16:35:13 -05:00
Akash Satheesan
b1fb9f780b
fix(lib/vscode): add listProcesses to terminal channel 2021-04-09 20:20:49 +05:30
Akash Satheesan
feb7013b3a
fix(lib/vscode): rename terminal events 2021-04-09 19:16:00 +05:30
Akash Satheesan
f3b1076f1d
fix(lib/vscode): get vscode to compile 2021-04-09 17:50:11 +05:30
Akash Satheesan
5e63b7f53c
fix(lib/vscode): fix merge conflicts in localizationsService.ts 2021-04-09 17:49:14 +05:30
Akash Satheesan
448ba0ccf2
fix(lib/vscode): fix conflicts in environmentService.ts 2021-04-09 12:50:53 +05:30
Akash Satheesan
b73260d561
fix(lib/vscode): fix conflicts in sandbox.simpleservices.ts 2021-04-09 12:50:45 +05:30
Akash Satheesan
15a5d20edf
fix(lib/vscode): fix conflicts in extensionsScanner.ts 2021-04-09 12:39:27 +05:30
Akash Satheesan
4ab306efeb
fix(lib/vscode): fix conflicts in workbench/workbench.web.main.ts 2021-04-09 12:09:36 +05:30
Akash Satheesan
8fb96b9967 chore(vscode): update to 1.55.2 2021-04-09 11:32:27 +05:30
Joe Previte
f241e38907
chore: fix typo in extensionDownloader 2021-04-06 15:46:57 -07:00
Asher
101c2a01f1
Fix tsc watch restarting when it shouldn't
It seems reaching into lib/vscode for the types caused tsc to establish
watches that caused it to restart over and over while vscode was
building.

The strategy used here is to symlink it instead which is the same thing
we do for the proxy agent.
2021-04-01 10:58:56 -05:00
Akash Satheesan
8332a6abc9
fix(lib/vscode): remove native-keymap and keytar (#2961)
native-keymap and keytar are only used in the electron process,
so we don't need them. This allows us to drop our dependencies on
libx11-dev, libxkbfile-dev, and libsecret-dev.
2021-03-25 22:20:58 +05:30
Joe Previte
090687d057
feat: add e2e test for logout 2021-03-23 10:02:03 -07:00
Joe Previte
5cec6208d0
refactor: add cookie.ts to lib/vscode 2021-03-23 10:02:03 -07:00
Joe Previte
9f790fd2f3
feat(lib/vscode): add log out to application menu
This adds a new option to the Application Menu called Log out.

It deletes the code-server cookie and logs a user out.
2021-03-23 10:02:02 -07:00
Joe Previte
aae17cb749
fixup: fix comment in server.ts 2021-03-22 10:43:02 -07:00
Joe Previte
19c2f31f22
fixup: remove comment in server.ts 2021-03-22 10:37:44 -07:00