fix(dockerfile): explicitly create a volume and set permission for project dir (#471)

Signed-off-by: Kibo Hikari <enra@sayonika.moe>

.gitignore

@@ -1,6 +1,8 @@
-lib
+/lib
 node_modules
 dist
 out
 .DS_Store
 release
+.vscode
+.cache

.node-version

@@ -0,0 +1 @@
+8.15.0

.travis.yml

@@ -2,15 +2,16 @@ language: node_js
 node_js:
 - 8.15.0
 env:
-  - VSCODE_VERSION="1.32.0" MAJOR_VERSION="1" VERSION="$MAJOR_VERSION.$TRAVIS_BUILD_NUMBER-vsc$VSCODE_VERSION"
+  - VSCODE_VERSION="1.33.1" MAJOR_VERSION="1" VERSION="$MAJOR_VERSION.$TRAVIS_BUILD_NUMBER-vsc$VSCODE_VERSION"
 matrix:
   include:
   - os: linux
-    dist: ubuntu
+    dist: trusty
   - os: osx
 before_install:
 - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get install libxkbfile-dev
   libsecret-1-dev; fi
+- npm install -g yarn@1.12.3
 script:
 - scripts/build.sh
 before_deploy:
@@ -35,4 +36,8 @@ deploy:
   on:
     repo: codercom/code-server
     branch: master
-cache: yarn
+cache:
+  yarn: true
+  timeout: 1000
+  directories:
+  - .cache

Dockerfile

@@ -13,21 +13,42 @@ COPY . .
 
 # In the future, we can use https://github.com/yarnpkg/rfcs/pull/53 to make yarn use the node_modules
 # directly which should be fast as it is slow because it populates its own cache every time.
-RUN yarn && yarn task build:server:binary
+RUN yarn && NODE_ENV=production yarn task build:server:binary
 
 # We deploy with ubuntu so that devs have a familiar environment.
-FROM ubuntu:18.10
+FROM ubuntu:18.04
-WORKDIR /root/project
-COPY --from=0 /src/packages/server/cli-linux-x64 /usr/local/bin/code-server
-EXPOSE 8443
 
 RUN apt-get update && apt-get install -y \
 	openssl \
 	net-tools \
 	git \
-	locales
+	locales \
+	sudo \
+	dumb-init \
+	vim \
+	curl \
+	wget
+
 RUN locale-gen en_US.UTF-8
 # We unfortunately cannot use update-locale because docker will not use the env variables
 # configured in /etc/default/locale so we need to set it manually.
-ENV LANG=en_US.UTF-8
+ENV LC_ALL=en_US.UTF-8
-ENTRYPOINT ["code-server"]
+
+RUN adduser --gecos '' --disabled-password coder && \
+	echo "coder ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers.d/nopasswd
+
+USER coder
+# We create first instead of just using WORKDIR as when WORKDIR creates, the user is root.
+RUN mkdir -p /home/coder/project && \
+    chmod g+rw /home/coder/project;
+
+WORKDIR /home/coder/project
+
+# This assures we have a volume mounted even if the user forgot to do bind mount.
+# XXX: Workaround for GH-459 and for OpenShift compatibility.
+VOLUME [ "/home/coder/project" ]
+
+COPY --from=0 /src/packages/server/cli-linux-x64 /usr/local/bin/code-server
+EXPOSE 8443
+
+ENTRYPOINT ["dumb-init", "code-server"]

README.md

@@ -2,14 +2,14 @@
 
 [!["Open Issues"](https://img.shields.io/github/issues-raw/codercom/code-server.svg)](https://github.com/codercom/code-server/issues)
 [!["Latest Release"](https://img.shields.io/github/release/codercom/code-server.svg)](https://github.com/codercom/code-server/releases/latest)
-[![MIT license](https://img.shields.io/badge/license-MIT-green.svg)](#)
+[![MIT license](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/codercom/code-server/blob/master/LICENSE)
-[![Discord](https://discordapp.com/api/guilds/463752820026376202/widget.png)](https://discord.gg/zxSwN8Z)
+[![Discord](https://img.shields.io/discord/463752820026376202.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2)](https://discord.gg/zxSwN8Z)
 
 `code-server` is [VS Code](https://github.com/Microsoft/vscode) running on a remote server, accessible through the browser.
 
 Try it out:
 ```bash
-docker run -t -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" codercom/code-server code-server --allow-http --no-auth
+docker run -it -p 127.0.0.1:8443:8443 -v "${PWD}:/home/coder/project" codercom/code-server:1.621 --allow-http --no-auth
 ```
 
 - Code on your Chromebook, tablet, and laptop with a consistent dev environment.
@@ -23,10 +23,6 @@ docker run -t -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" codercom/code-ser
 
 ## Getting Started
 
-### Hosted
-
-[Try `code-server` now](https://coder.com/signup) for free at coder.com.
-
 ### Docker
 
 See docker oneliner mentioned above. Dockerfile is at [/Dockerfile](/Dockerfile).
@@ -57,14 +53,15 @@ How to [secure your setup](/doc/security/ssl.md).
 - Creating custom VS Code extensions and debugging them doesn't work.
 
 ### Future
-
+- **Stay up to date!** Get notified about new releases of code-server.
+  ![Screenshot](/doc/assets/release.gif)
 - Windows support.
 - Electron and Chrome OS applications to bridge the gap between local<->remote.
 - Run VS Code unit tests against our builds to ensure features work as expected.
 
-### Notes
+### Extensions
 
-- At the moment we can't use the official VSCode Marketplace. We've created a custom extension marketplace focused around open-sourced extensions. However, if you have access to the `.vsix` file, you can manually install the extension.
+At the moment we can't use the official VSCode Marketplace. We've created a custom extension marketplace focused around open-sourced extensions. However, if you have access to the `.vsix` file, you can manually install the extension.
 
 ## Contributing
 

build/tasks.ts

@@ -4,21 +4,22 @@ import * as fse from "fs-extra";
 import * as os from "os";
 import * as path from "path";
 import * as zlib from "zlib";
+import * as https from "https";
+import * as tar from "tar";
 
 const isWin = os.platform() === "win32";
 const libPath = path.join(__dirname, "../lib");
 const vscodePath = path.join(libPath, "vscode");
+const defaultExtensionsPath = path.join(libPath, "extensions");
 const pkgsPath = path.join(__dirname, "../packages");
-const defaultExtensionsPath = path.join(libPath, "VSCode-linux-x64/resources/app/extensions");
+const vscodeVersion = process.env.VSCODE_VERSION || "1.33.1";
-const vscodeVersion = process.env.VSCODE_VERSION || "1.32.0";
+const vsSourceUrl = `https://codesrv-ci.cdr.sh/vstar-${vscodeVersion}.tar.gz`;
 
 const buildServerBinary = register("build:server:binary", async (runner) => {
 	await ensureInstalled();
-	await copyForDefaultExtensions();
 	await Promise.all([
 		buildBootstrapFork(),
 		buildWeb(),
-		buildDefaultExtensions(),
 		buildServerBundle(),
 		buildAppBrowser(),
 	]);
@@ -129,97 +130,50 @@ const buildWeb = register("build:web", async (runner) => {
 	await runner.execute(isWin ? "npm.cmd" : "npm", ["run", "build"]);
 });
 
-const extDirPath = path.join("lib", "vscode-default-extensions");
-const copyForDefaultExtensions = register("build:copy-vscode", async (runner) => {
-	if (!fs.existsSync(defaultExtensionsPath)) {
-		await ensureClean();
-		await ensureInstalled();
-		await new Promise((resolve, reject): void => {
-			fse.remove(extDirPath, (err) => {
-				if (err) {
-					return reject(err);
-				}
-
-				resolve();
-			});
-		});
-		await new Promise((resolve, reject): void => {
-			fse.copy(vscodePath, extDirPath, (err) => {
-				if (err) {
-					return reject(err);
-				}
-
-				resolve();
-			});
-		});
-	}
-});
-
-const buildDefaultExtensions = register("build:default-extensions", async (runner) => {
-	if (!fs.existsSync(defaultExtensionsPath)) {
-		await copyForDefaultExtensions();
-		runner.cwd = extDirPath;
-		const resp = await runner.execute(isWin ? "npx.cmd" : "npx", [isWin ? "gulp.cmd" : "gulp", "vscode-linux-x64", "--max-old-space-size=32384"]);
-		if (resp.exitCode !== 0) {
-			throw new Error(`Failed to build default extensions: ${resp.stderr}`);
-		}
-	}
-});
-
 const ensureInstalled = register("vscode:install", async (runner) => {
-	await ensureCloned();
+	runner.cwd = libPath;
 
-	runner.cwd = vscodePath;
+	if (fs.existsSync(vscodePath) && fs.existsSync(defaultExtensionsPath)) {
-	const install = await runner.execute(isWin ? "yarn.cmd" : "yarn", []);
+		const pkgVersion = JSON.parse(fs.readFileSync(path.join(vscodePath, "package.json")).toString("utf8")).version;
-	if (install.exitCode !== 0) {
+		if (pkgVersion === vscodeVersion) {
-		throw new Error(`Failed to install vscode dependencies: ${install.stderr}`);
+			runner.cwd = vscodePath;
-	}
-});
 
-const ensureCloned = register("vscode:clone", async (runner) => {
+			const reset = await runner.execute("git", ["reset", "--hard"]);
-	if (fs.existsSync(vscodePath)) {
+			if (reset.exitCode !== 0) {
-		await ensureClean();
+				throw new Error(`Failed to clean git repository: ${reset.stderr}`);
-	} else {
+			}
-		fse.mkdirpSync(libPath);
+
-		runner.cwd = libPath;
+			return;
-		const clone = await runner.execute("git", ["clone", "https://github.com/microsoft/vscode", "--branch", vscodeVersion, "--single-branch", "--depth=1"]);
-		if (clone.exitCode !== 0) {
-			throw new Error(`Failed to clone: ${clone.exitCode}`);
 		}
 	}
 
-	runner.cwd = vscodePath;
+	fse.removeSync(libPath);
-	const checkout = await runner.execute("git", ["checkout", vscodeVersion]);
+	fse.mkdirpSync(libPath);
-	if (checkout.exitCode !== 0) {
-		throw new Error(`Failed to checkout: ${checkout.stderr}`);
-	}
-});
 
-const ensureClean = register("vscode:clean", async (runner) => {
+	await new Promise<void>((resolve, reject): void => {
-	runner.cwd = vscodePath;
+		https.get(vsSourceUrl, (res) => {
+			if (res.statusCode !== 200) {
+				return reject(res.statusMessage);
+			}
 
-	const status = await runner.execute("git", ["status", "--porcelain"]);
+			res.pipe(tar.x({
-	if (status.stdout.trim() !== "") {
+				C: libPath,
-		const clean = await runner.execute("git", ["clean", "-f", "-d", "-X"]);
+			}).on("finish", () => {
-		if (clean.exitCode !== 0) {
+				resolve();
-			throw new Error(`Failed to clean git repository: ${clean.stderr}`);
+			}).on("error", (err: Error) => {
-		}
+				reject(err);
-		const removeUnstaged = await runner.execute("git", ["checkout", "--", "."]);
+			}));
-		if (removeUnstaged.exitCode !== 0) {
+		}).on("error", (err) => {
-			throw new Error(`Failed to remove unstaged files: ${removeUnstaged.stderr}`);
+			reject(err);
-		}
+		});
-	}
+	});
-	const fetch = await runner.execute("git", ["fetch", "--prune"]);
-	if (fetch.exitCode !== 0) {
-		throw new Error(`Failed to fetch latest changes: ${fetch.stderr}`);
-	}
 });
 
 const ensurePatched = register("vscode:patch", async (runner) => {
 	if (!fs.existsSync(vscodePath)) {
 		throw new Error("vscode must be cloned to patch");
 	}
-	await ensureClean();
+	await ensureInstalled();
 
 	runner.cwd = vscodePath;
 	const patchPath = path.join(__dirname, "../scripts/vscode.patch");

doc/admin/install/aws.md

@@ -56,7 +56,7 @@ If you're just starting out, we recommend [installing code-server locally](../..
   > To ensure the connection between you and your server is encrypted view our guide on [securing your setup](../../security/ssl.md)
 - Finally, run
   ```
-  sudo ./code-server-linux -p 80
+  sudo ./code-server -p 80
   ```
 - When you visit the public IP for your AWS instance, you will be greeted   with this page. Code-server is using a self-signed SSL certificate for easy setup. To proceed to the IDE, click **"Advanced"**<img src ="../../assets/chrome_warning.png">
 - Then click **"proceed anyway"**<img src="../../assets/chrome_confirm.png">

doc/admin/install/digitalocean.md

@@ -39,7 +39,7 @@ If you're just starting out, we recommend [installing code-server locally](../..
   > To ensure the connection between you and your server is encrypted view our guide on [securing your setup](../../security/ssl.md)
 - Finally start the code-server
   ```
-  sudo ./code-server-linux -p 80
+  sudo ./code-server -p 80
   ```
     > For instructions on how to keep the server running after you end your SSH session please checkout [how to use systemd](https://www.linode.com/docs/quick-answers/linux/start-service-at-boot/) to start linux based services if they are killed
 - When you visit the public IP for your Digital Ocean instance, you will be greeted with this page. Code-server is using a self-signed SSL certificate for easy setup. To proceed to the IDE, click **"Advanced"**<img src ="../../assets/chrome_warning.png">

doc/admin/install/google_cloud.md

@@ -54,7 +54,7 @@ chmod +x code-server
 
 - Start the code-server
 ```
-sudo ./code-server-linux -p 80
+sudo ./code-server -p 80
 ```
 
 > For instructions on how to keep the server running after you end your SSH session please checkout [how to use systemd](https://www.linode.com/docs/quick-answers/linux/start-service-at-boot/) to start linux based services if they are killed

doc/self-hosted/index.md

@@ -6,7 +6,7 @@
 
 > NOTE: If you get stuck or need help, [file an issue](https://github.com/codercom/code-server/issues/new?&title=Improve+self-hosted+quickstart+guide), [tweet (@coderhq)](https://twitter.com/coderhq) or [email](mailto:support@coder.com?subject=Self-hosted%20quickstart%20guide).
 
-This document pertains to Coder specific implementations of VS Code. For documentation on how to use VS Code itself, please refer to the official [documentation for VS Code](https://code.visualstudio.com/docs) 
+This document pertains to Coder specific implementations of VS Code. For documentation on how to use VS Code itself, please refer to the official [documentation for VS Code](https://code.visualstudio.com/docs)
 
 It takes just a few minutes to get your own self-hosted server running. If you've got a machine running macOS, Windows, or Linux, you're ready to start the binary which listens on port `8443` by default.
 
@@ -58,19 +58,20 @@ OPTIONS
   Use `code-server -d (path/to/directory)` or `code-server --data-dir=(path/to/directory)`, excluding the parentheses to specify the root folder that VS Code will start in
 
   ### Host
-  By default, code-server will use `0.0.0.0` as its address. This can be changed by using `code-server -h` or `code-server --host=` followed by the address you want to use. 
+  By default, code-server will use `0.0.0.0` as its address. This can be changed by using `code-server -h` or `code-server --host=` followed by the address you want to use.
   > Example: `code-server -h 127.0.0.1`
 
   ### Open
-  You can have the server automatically open the VS Code in your browser on startup by using the `code server -o` or `code-server --open` flags
+  You can have the server automatically open the VS Code in your browser on startup by using the `code-server -o` or `code-server --open` flags
 
-  ### Port  
+  ### Port
-  By default, code-server will use `8443` as its port. This can be changed by using `code-server -p` or `code-server --port=` followed by the port you want to use. 
+  By default, code-server will use `8443` as its port. This can be changed by using `code-server -p` or `code-server --port=` followed by the port you want to use.
   > Example: `code-server -p 9000`
 
   ### Cert and Cert Key
   To encrypt the traffic between the browser and server use `code-server --cert=` followed by the path to your `.cer` file. Additionally, you can use certificate keys with `code-server --cert-key` followed by the path to your `.key` file.
 > Example (certificate and key): `code-server --cert /etc/letsencrypt/live/example.com/fullchain.cer --cert-key /etc/letsencrypt/live/example.com/fullchain.key`
+> Example (if you are using Letsencrypt or similar): `code-server --cert /etc/letsencrypt/live/example.com/fullchain.pem --cert-key /etc/letsencrypt/live/example.com/privkey.key`
 
 > To ensure the connection between you and your server is encrypted view our guide on [securing your setup](../security/ssl.md)
 

package.json

@@ -15,7 +15,9 @@
   "devDependencies": {
     "@types/fs-extra": "^5.0.4",
     "@types/node": "^10.12.18",
+    "@types/tar": "^4.0.0",
     "@types/trash": "^4.3.1",
+    "cache-loader": "^2.0.1",
     "cross-env": "^5.2.0",
     "crypto-browserify": "^3.12.0",
     "css-loader": "^2.1.0",
@@ -34,6 +36,8 @@
     "sass-loader": "^7.1.0",
     "string-replace-loader": "^2.1.1",
     "style-loader": "^0.23.1",
+    "tar": "^4.4.8",
+    "terser-webpack-plugin": "^1.2.3",
     "ts-loader": "^5.3.3",
     "ts-node": "^7.0.1",
     "tsconfig-paths": "^3.8.0",
@@ -42,6 +46,7 @@
     "typescript": "^3.2.2",
     "typescript-tslint-plugin": "^0.2.1",
     "uglifyjs-webpack-plugin": "^2.1.1",
+    "url-loader": "^1.1.2",
     "util": "^0.11.1",
     "webpack": "^4.28.4",
     "webpack-bundle-analyzer": "^3.0.3",

packages/app/browser/src/app.html

@@ -7,22 +7,24 @@
 </head>
 
 <body>
-	<div class="login">
+	<form id="login-form">
-		<div class="back"> <- Back </div>
+		<div class="login">
-		<h4 class="title">code-server</h4>
+			<div class="back">
-		<h2 class="subtitle">
+				<- Back </div> <h4 class="title">code-server</h4>
-			Enter server password
+					<h2 class="subtitle">
-		</h2>
+						Enter server password
-		<div class="mdc-text-field">
+					</h2>
-			<input type="password" id="password" class="mdc-text-field__input" required>
+						<div class="mdc-text-field">
-			<label class="mdc-floating-label" for="password">Password</label>
+							<input type="password" id="password" class="mdc-text-field__input" required>
-			<div class="mdc-line-ripple"></div>
+							<label class="mdc-floating-label" for="password">Password</label>
-		</div>
+							<div class="mdc-line-ripple"></div>
-		<button id="submit" class="mdc-button mdc-button--unelevated">
+						</div>
-			<span class="mdc-button__label">Enter IDE</span>
+						<button id="submit" class="mdc-button mdc-button--unelevated">
-		</button>
+							<span class="mdc-button__label">Enter IDE</span>
-		<div id="error-display"></div>
+						</button>
-	</div>
+					<div id="error-display"></div>
+			</div>
+	</form>
 </body>
 
 </html>

packages/app/browser/src/app.ts

@@ -20,11 +20,14 @@ window.addEventListener("message", (event) => {
 });
 
 const password = document.getElementById("password") as HTMLInputElement;
-const submit = document.getElementById("submit") as HTMLButtonElement;
+const form = document.getElementById("login-form") as HTMLFormElement;
-if (!submit) {
+
-	throw new Error("No submit button found");
+if (!form) {
+	throw new Error("No password form found");
 }
-submit.addEventListener("click", () => {
+
+form.addEventListener("submit", (e) => {
+	e.preventDefault();
 	document.cookie = `password=${password.value}`;
 	location.reload();
 });
@@ -38,4 +41,4 @@ const errorDisplay = document.getElementById("error-display") as HTMLDivElement;
 
 if (document.referrer === document.location.href && matches) {
 	errorDisplay.innerText = "Password is incorrect!";
-}
+}

packages/ide-api/api.d.ts

@@ -136,12 +136,17 @@ interface ICommandRegistry {
 	registerCommand(command: ICommand): IDisposable;
 }
 
+interface IStorageService {
+	save(): Promise<void>;
+}
+
 declare namespace ide {
 	export const client: {};
 
 	export const workbench: {
 		readonly statusbarService: IStatusbarService;
 		readonly notificationService: INotificationService;
+		readonly storageService: IStorageService;
 		readonly menuRegistry: IMenuRegistry;
 		readonly commandRegistry: ICommandRegistry;
 

packages/ide-api/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@coder/ide-api",
-	"version": "1.0.3",
+	"version": "1.0.4",
 	"typings": "api.d.ts",
 	"author": "Coder",
 	"license": "MIT",

packages/ide/src/client.ts

@@ -41,7 +41,16 @@ export abstract class IdeClient {
 		});
 
 		this.sharedProcessData = new Promise((resolve): void => {
-			client.onSharedProcessActive(resolve);
+			let d = client.onSharedProcessActive((data) => {
+				d.dispose();
+				d = client.onSharedProcessActive(() => {
+					d.dispose();
+					this.retry.notificationService.error(
+						new Error("Disconnected from shared process. Searching, installing, enabling, and disabling extensions will not work until the page is refreshed."),
+					);
+				});
+				resolve(data);
+			});
 		});
 
 		window.addEventListener("contextmenu", (event) => {
@@ -65,10 +74,6 @@ export abstract class IdeClient {
 		});
 	}
 
-	/**
-	 * Wrap a task in some logging, timing, and progress updates. Can optionally
-	 * wait on other tasks which won't count towards this task's time.
-	 */
 	public async task<T>(description: string, duration: number, task: () => Promise<T>): Promise<T>;
 	public async task<T, V>(description: string, duration: number, task: (v: V) => Promise<T>, t: Promise<V>): Promise<T>;
 	public async task<T, V1, V2>(description: string, duration: number, task: (v1: V1, v2: V2) => Promise<T>, t1: Promise<V1>, t2: Promise<V2>): Promise<T>;
@@ -76,6 +81,10 @@ export abstract class IdeClient {
 	public async task<T, V1, V2, V3, V4>(description: string, duration: number, task: (v1: V1, v2: V2, v3: V3, v4: V4) => Promise<T>, t1: Promise<V1>, t2: Promise<V2>, t3: Promise<V3>, t4: Promise<V4>): Promise<T>;
 	public async task<T, V1, V2, V3, V4, V5>(description: string, duration: number, task: (v1: V1, v2: V2, v3: V3, v4: V4, v5: V5) => Promise<T>, t1: Promise<V1>, t2: Promise<V2>, t3: Promise<V3>, t4: Promise<V4>, t5: Promise<V5>): Promise<T>;
 	public async task<T, V1, V2, V3, V4, V5, V6>(description: string, duration: number, task: (v1: V1, v2: V2, v3: V3, v4: V4, v5: V5, v6: V6) => Promise<T>, t1: Promise<V1>, t2: Promise<V2>, t3: Promise<V3>, t4: Promise<V4>, t5: Promise<V5>, t6: Promise<V6>): Promise<T>;
+	/**
+	 * Wrap a task in some logging, timing, and progress updates. Can optionally
+	 * wait on other tasks which won't count towards this task's time.
+	 */
 	public async task<T>(
 		description: string, duration: number = 100, task: (...args: any[]) => Promise<T>, ...after: Array<Promise<any>> // tslint:disable-line no-any
 	): Promise<T> {

packages/ide/src/fill/client.ts

@@ -11,7 +11,7 @@ class WebsocketConnection implements ReadWriteConnection {
 	private activeSocket: WebSocket | undefined;
 	private readonly messageBuffer = <Uint8Array[]>[];
 	private readonly socketTimeoutDelay = 60 * 1000;
-	private readonly retryName = "Socket";
+	private readonly retry = retry.register("Socket", () => this.connect());
 	private isUp: boolean = false;
 	private closed: boolean = false;
 
@@ -26,11 +26,14 @@ class WebsocketConnection implements ReadWriteConnection {
 	public readonly onMessage = this.messageEmitter.event;
 
 	public constructor() {
-		retry.register(this.retryName, () => this.connect());
+		this.retry.block();
-		retry.block(this.retryName);
+		this.retry.run();
-		retry.run(this.retryName);
 	}
 
+	/**
+	 * Send data across the socket. If closed, will error. If connecting, will
+	 * queue.
+	 */
 	public send(data: Buffer | Uint8Array): void {
 		if (this.closed) {
 			throw new Error("web socket is closed");
@@ -42,6 +45,9 @@ class WebsocketConnection implements ReadWriteConnection {
 		}
 	}
 
+	/**
+	 * Close socket connection.
+	 */
 	public close(): void {
 		this.closed = true;
 		this.dispose();
@@ -75,8 +81,8 @@ class WebsocketConnection implements ReadWriteConnection {
 				field("wasClean", event.wasClean),
 			);
 			if (!this.closed) {
-				retry.block(this.retryName);
+				this.retry.block();
-				retry.run(this.retryName);
+				this.retry.run();
 			}
 		});
 
@@ -108,15 +114,19 @@ class WebsocketConnection implements ReadWriteConnection {
 		}, this.socketTimeoutDelay);
 
 		await new Promise((resolve, reject): void => {
-			const onClose = (): void => {
+			const doReject = (): void => {
 				clearTimeout(socketWaitTimeout);
-				socket.removeEventListener("close", onClose);
+				socket.removeEventListener("error", doReject);
+				socket.removeEventListener("close", doReject);
 				reject();
 			};
-			socket.addEventListener("close", onClose);
+			socket.addEventListener("error", doReject);
+			socket.addEventListener("close", doReject);
 
-			socket.addEventListener("open", async () => {
+			socket.addEventListener("open", () => {
 				clearTimeout(socketWaitTimeout);
+				socket.removeEventListener("error", doReject);
+				socket.removeEventListener("close", doReject);
 				resolve();
 			});
 		});

packages/ide/src/fill/dialog.ts

@@ -132,7 +132,7 @@ export class Dialog {
 	public show(): void {
 		if (!this.cachedActiveElement) {
 			this.cachedActiveElement = document.activeElement as HTMLElement;
-			(document.getElementById("workbench.main.container") || document.body).appendChild(this.overlay);
+			(document.querySelector(".monaco-workbench") || document.body).appendChild(this.overlay);
 			document.addEventListener("keydown", this.onKeydown);
 			if (this.input) {
 				this.input.focus();

packages/ide/src/fill/electron.ts

@@ -45,7 +45,8 @@ const newCreateElement = <K extends keyof HTMLElementTagNameMap>(tagName: K): HT
 			},
 			set: (value: string): void => {
 				if (value) {
-					value = value.replace(/file:\/\//g, "/resource");
+					const resourceBaseUrl = location.pathname.replace(/\/$/, "") + "/resource";
+					value = value.replace(/file:\/\//g, resourceBaseUrl);
 				}
 				oldSrc!.set!.call(img, value);
 			},
@@ -66,7 +67,8 @@ const newCreateElement = <K extends keyof HTMLElementTagNameMap>(tagName: K): HT
 			},
 			set: (value: string): void => {
 				if (value) {
-					value = value.replace(/file:\/\//g, "/resource");
+					const resourceBaseUrl = location.pathname.replace(/\/$/, "") + "/resource";
+					value = value.replace(/file:\/\//g, resourceBaseUrl);
 				}
 				oldInnerHtml!.set!.call(style, value);
 			},
@@ -80,7 +82,8 @@ const newCreateElement = <K extends keyof HTMLElementTagNameMap>(tagName: K): HT
 				if (sheet && !overridden) {
 					const oldInsertRule = sheet.insertRule;
 					sheet.insertRule = (rule: string, index?: number): void => {
-						rule = rule.replace(/file:\/\//g, "/resource");
+						const resourceBaseUrl = location.pathname.replace(/\/$/, "") + "/resource";
+						rule = rule.replace(/file:\/\//g, resourceBaseUrl);
 						oldInsertRule.call(sheet, rule, index);
 					};
 					overridden = true;
@@ -137,12 +140,17 @@ const newCreateElement = <K extends keyof HTMLElementTagNameMap>(tagName: K): HT
 				};
 			},
 		});
+		view.src = require("!!file-loader?name=[path][name].[ext]!./webview.html");
+		Object.defineProperty(view, "src", {
+			set: (): void => { /* Nope. */ },
+		});
 		(view as any).getWebContents = (): void => undefined; // tslint:disable-line no-any
 		(view as any).send = (channel: string, ...args: any[]): void => { // tslint:disable-line no-any
 			if (args[0] && typeof args[0] === "object" && args[0].contents) {
 				// TODO
-				args[0].contents = (args[0].contents as string).replace(/"(file:\/\/[^"]*)"/g, (m1) => `"/resource${m1}"`);
+				const resourceBaseUrl = location.pathname.replace(/\/$/, "") + "/resource";
-				args[0].contents = (args[0].contents as string).replace(/"vscode-resource:([^"]*)"/g, (m, m1) => `"/resource${m1}"`);
+				args[0].contents = (args[0].contents as string).replace(/"(file:\/\/[^"]*)"/g, (m1) => `"${resourceBaseUrl}${m1}"`);
+				args[0].contents = (args[0].contents as string).replace(/"vscode-resource:([^"]*)"/g, (m, m1) => `"${resourceBaseUrl}${m1}"`);
 				args[0].contents = (args[0].contents as string).replace(/style-src vscode-core-resource:/g, "style-src 'self'");
 			}
 			if (view.contentWindow) {
@@ -178,6 +186,10 @@ class Clipboard {
 	public writeText(value: string): Promise<void> {
 		return clipboard.writeText(value);
 	}
+
+	public readText(): Promise<string> {
+		return clipboard.readText();
+	}
 }
 
 class Shell {

packages/ide/src/fill/webview.html

@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html lang="en" style="width: 100%; height: 100%">
+	<head>
+		<title>Virtual Document</title>
+	</head>
+	<body style="margin: 0; overflow: hidden; width: 100%; height: 100%">
+	</body>
+</html>

packages/ide/src/retry.ts

@@ -1,14 +1,64 @@
 import { logger, field } from "@coder/logger";
 import { NotificationService, INotificationHandle, INotificationService, Severity } from "./fill/notification";
 
+// tslint:disable no-any can have different return values
+
 interface IRetryItem {
+	/**
+	 * How many times this item has been retried.
+	 */
 	count?: number;
-	delay?: number; // In seconds.
+
-	end?: number;   // In ms.
+	/**
-	fn(): any | Promise<any>; // tslint:disable-line no-any can have different return values
+	 * In seconds.
+	 */
+	delay?: number;
+
+	/**
+	 * In milliseconds.
+	 */
+	end?: number;
+
+	/**
+	 * Function to run when retrying.
+	 */
+	fn(): any;
+
+	/**
+	 * Timer for running this item.
+	 */
 	timeout?: number | NodeJS.Timer;
+
+	/**
+	 * Whether the item is retrying or waiting to retry.
+	 */
 	running?: boolean;
-	showInNotification: boolean;
+}
+
+/**
+ * An retry-able instance.
+ */
+export interface RetryInstance {
+	/**
+	 * Run this retry.
+	 */
+	run(error?: Error): void;
+
+	/**
+	 * Block on this instance.
+	 */
+	block(): void;
+}
+
+/**
+ * A retry-able instance that doesn't use a promise so it must be manually
+ * ran again on failure and recovered on success.
+ */
+export interface ManualRetryInstance extends RetryInstance {
+	/**
+	 * Mark this item as recovered.
+	 */
+	recover(): void;
 }
 
 /**
@@ -21,11 +71,11 @@ interface IRetryItem {
  * to the user explaining what is happening with an option to immediately retry.
  */
 export class Retry {
-	private items = new Map<string, IRetryItem>();
+	private readonly items = new Map<string, IRetryItem>();
 
 	// Times are in seconds.
 	private readonly retryMinDelay = 1;
-	private readonly retryMaxDelay = 10;
+	private readonly retryMaxDelay = 3;
 	private readonly maxImmediateRetries = 5;
 	private readonly retryExponent = 1.5;
 	private blocked: string | boolean | undefined;
@@ -50,8 +100,49 @@ export class Retry {
 	}
 
 	/**
-	 * Block retries when we know they will fail (for example when starting Wush
+	 * Register a function to retry that starts/connects to a service.
-	 * back up). If a name is passed, that service will still be allowed to retry
+	 *
+	 * The service is automatically retried or recovered when the promise resolves
+	 * or rejects. If the service dies after starting, it must be manually
+	 * retried.
+	 */
+	public register(name: string, fn: () => Promise<any>): RetryInstance;
+	/**
+	 * Register a function to retry that starts/connects to a service.
+	 *
+	 * Must manually retry if it fails to start again or dies after restarting and
+	 * manually recover if it succeeds in starting again.
+	 */
+	public register(name: string, fn: () => any): ManualRetryInstance;
+	/**
+	 * Register a function to retry that starts/connects to a service.
+	 */
+	public register(name: string, fn: () => any): RetryInstance | ManualRetryInstance {
+		if (this.items.has(name)) {
+			throw new Error(`"${name}" is already registered`);
+		}
+		this.items.set(name, { fn });
+
+		return {
+			block: (): void => this.block(name),
+			run: (error?: Error): void => this.run(name, error),
+			recover: (): void => this.recover(name),
+		};
+	}
+
+	/**
+	 * Un-register a function to retry.
+	 */
+	public unregister(name: string): void {
+		if (!this.items.has(name)) {
+			throw new Error(`"${name}" is not registered`);
+		}
+		this.items.delete(name);
+	}
+
+	/**
+	 * Block retries when we know they will fail (for example when the socket is
+	 * down ). If a name is passed, that service will still be allowed to retry
 	 * (unless we have already blocked).
 	 *
 	 * Blocking without a name will override a block with a name.
@@ -68,7 +159,7 @@ export class Retry {
 	/**
 	 * Unblock retries and run any that are pending.
 	 */
-	public unblock(): void {
+	private unblock(): void {
 		this.blocked = false;
 		this.items.forEach((item, name) => {
 			if (item.running) {
@@ -77,35 +168,10 @@ export class Retry {
 		});
 	}
 
-	/**
-	 * Register a function to retry that starts/connects to a service.
-	 *
-	 * If the function returns a promise, it will automatically be retried,
-	 * recover, & unblock after calling `run` once (otherwise they need to be
-	 * called manually).
-	 */
-	// tslint:disable-next-line no-any can have different return values
-	public register(name: string, fn: () => any | Promise<any>, showInNotification: boolean = true): void {
-		if (this.items.has(name)) {
-			throw new Error(`"${name}" is already registered`);
-		}
-		this.items.set(name, { fn, showInNotification });
-	}
-
-	/**
-	 * Unregister a function to retry.
-	 */
-	public unregister(name: string): void {
-		if (!this.items.has(name)) {
-			throw new Error(`"${name}" is not registered`);
-		}
-		this.items.delete(name);
-	}
-
 	/**
 	 * Retry a service.
 	 */
-	public run(name: string, error?: Error): void {
+	private run(name: string, error?: Error): void {
 		if (!this.items.has(name)) {
 			throw new Error(`"${name}" is not registered`);
 		}
@@ -149,7 +215,7 @@ export class Retry {
 	/**
 	 * Reset a service after a successfully recovering.
 	 */
-	public recover(name: string): void {
+	private recover(name: string): void {
 		if (!this.items.has(name)) {
 			throw new Error(`"${name}" is not registered`);
 		}
@@ -191,9 +257,9 @@ export class Retry {
 					if (this.blocked === name) {
 						this.unblock();
 					}
-				}).catch(() => {
+				}).catch((error) => {
 					endItem();
-					this.run(name);
+					this.run(name, error);
 				});
 			} else {
 				endItem();
@@ -214,8 +280,7 @@ export class Retry {
 
 		const now = Date.now();
 		const items = Array.from(this.items.entries()).filter(([_, item]) => {
-			return item.showInNotification
+			return typeof item.end !== "undefined"
-				&& typeof item.end !== "undefined"
 				&& item.end > now
 				&& item.delay && item.delay >= this.notificationThreshold;
 		}).sort((a, b) => {

packages/protocol/src/browser/client.ts

@@ -5,8 +5,8 @@ import { Emitter } from "@coder/events";
 import { logger, field } from "@coder/logger";
 import { ReadWriteConnection, InitData, SharedProcessData } from "../common/connection";
 import { Module, ServerProxy } from "../common/proxy";
-import { stringify, parse, moduleToProto, protoToModule, protoToOperatingSystem } from "../common/util";
+import { argumentToProto, protoToArgument, moduleToProto, protoToModule, protoToOperatingSystem } from "../common/util";
-import { Ping, ServerMessage, ClientMessage, MethodMessage, NamedProxyMessage, NumberedProxyMessage, SuccessMessage, FailMessage, EventMessage, CallbackMessage } from "../proto";
+import { Argument, Ping, ServerMessage, ClientMessage, Method, Event, Callback } from "../proto";
 import { FsModule, ChildProcessModule, NetModule, NodePtyModule, SpdlogModule, TrashModule } from "./modules";
 
 // tslint:disable no-any
@@ -24,8 +24,8 @@ export class Client {
 	private messageId = 0;
 	private callbackId = 0;
 	private readonly proxies = new Map<number | Module, ProxyData>();
-	private readonly successEmitter = new Emitter<SuccessMessage>();
+	private readonly successEmitter = new Emitter<Method.Success>();
-	private readonly failEmitter = new Emitter<FailMessage>();
+	private readonly failEmitter = new Emitter<Method.Fail>();
 	private readonly eventEmitter = new Emitter<{ event: string; args: any[]; }>();
 
 	private _initData: InitData | undefined;
@@ -129,19 +129,13 @@ export class Client {
 				field("event listeners", this.eventEmitter.counts),
 			]);
 
-			const message = new FailMessage();
+			const message = new Method.Fail();
 			const error = new Error("disconnected");
-			message.setResponse(stringify(error));
+			message.setResponse(argumentToProto(error));
 			this.failEmitter.emit(message);
 
-			this.eventEmitter.emit({ event: "exit", args: [1] });
+			this.eventEmitter.emit({ event: "disconnected", args: [error] });
-			this.eventEmitter.emit({ event: "close", args: [] });
+			this.eventEmitter.emit({ event: "done", args: [] });
-			try {
-				this.eventEmitter.emit({ event: "error", args: [error] });
-			} catch (error) {
-				// If nothing is listening, EventEmitter will throw an error.
-			}
-			this.eventEmitter.emit({ event: "done", args: [true] });
 		};
 
 		connection.onDown(() => handleDisconnect());
@@ -149,6 +143,12 @@ export class Client {
 			clearTimeout(this.pingTimeout as any);
 			this.pingTimeout = undefined;
 			handleDisconnect();
+			this.proxies.clear();
+			this.successEmitter.dispose();
+			this.failEmitter.dispose();
+			this.eventEmitter.dispose();
+			this.initDataEmitter.dispose();
+			this.sharedProcessActiveEmitter.dispose();
 		});
 		connection.onUp(() => this.disconnected = false);
 
@@ -174,19 +174,29 @@ export class Client {
 	 * Make a remote call for a proxy's method using proto.
 	 */
 	private remoteCall(proxyId: number | Module, method: string, args: any[]): Promise<any> {
-		if (this.disconnected) {
+		if (this.disconnected && typeof proxyId === "number") {
-			return Promise.reject(new Error("disconnected"));
+			// Can assume killing or closing works because a disconnected proxy
+			// is disposed on the server's side.
+			switch (method) {
+				case "close":
+				case "kill":
+					return Promise.resolve();
+			}
+
+			return Promise.reject(
+				new Error(`Unable to call "${method}" on proxy ${proxyId}: disconnected`),
+			);
 		}
 
-		const message = new MethodMessage();
+		const message = new Method();
 		const id = this.messageId++;
-		let proxyMessage: NamedProxyMessage | NumberedProxyMessage;
+		let proxyMessage: Method.Named | Method.Numbered;
 		if (typeof proxyId === "string") {
-			proxyMessage = new NamedProxyMessage();
+			proxyMessage = new Method.Named();
 			proxyMessage.setModule(moduleToProto(proxyId));
 			message.setNamedProxy(proxyMessage);
 		} else {
-			proxyMessage = new NumberedProxyMessage();
+			proxyMessage = new Method.Numbered();
 			proxyMessage.setProxyId(proxyId);
 			message.setNumberedProxy(proxyMessage);
 		}
@@ -206,16 +216,14 @@ export class Client {
 			return callbackId;
 		};
 
-		const stringifiedArgs = args.map((a) => stringify(a, storeCallback));
 		logger.trace(() => [
 			"sending",
 			field("id", id),
 			field("proxyId", proxyId),
 			field("method", method),
-			field("args", stringifiedArgs),
 		]);
 
-		proxyMessage.setArgsList(stringifiedArgs);
+		proxyMessage.setArgsList(args.map((a) => argumentToProto(a, storeCallback)));
 
 		const clientMessage = new ClientMessage();
 		clientMessage.setMethod(message);
@@ -223,7 +231,7 @@ export class Client {
 
 		// The server will send back a fail or success message when the method
 		// has completed, so we listen for that based on the message's unique ID.
-		const promise =  new Promise((resolve, reject): void => {
+		const promise = new Promise((resolve, reject): void => {
 			const dispose = (): void => {
 				d1.dispose();
 				d2.dispose();
@@ -237,12 +245,12 @@ export class Client {
 
 			const d1 = this.successEmitter.event(id, (message) => {
 				dispose();
-				resolve(this.parse(message.getResponse()));
+				resolve(this.protoToArgument(message.getResponse(), promise));
 			});
 
 			const d2 = this.failEmitter.event(id, (message) => {
 				dispose();
-				reject(parse(message.getResponse()));
+				reject(protoToArgument(message.getResponse()));
 			});
 		});
 
@@ -253,42 +261,54 @@ export class Client {
 	 * Handle all messages from the server.
 	 */
 	private async handleMessage(message: ServerMessage): Promise<void> {
-		if (message.hasInit()) {
+		switch (message.getMsgCase()) {
-			const init = message.getInit()!;
+			case ServerMessage.MsgCase.INIT:
-			this._initData = {
+				const init = message.getInit()!;
-				dataDirectory: init.getDataDirectory(),
+				this._initData = {
-				homeDirectory: init.getHomeDirectory(),
+					dataDirectory: init.getDataDirectory(),
-				tmpDirectory: init.getTmpDirectory(),
+					homeDirectory: init.getHomeDirectory(),
-				workingDirectory: init.getWorkingDirectory(),
+					tmpDirectory: init.getTmpDirectory(),
-				os: protoToOperatingSystem(init.getOperatingSystem()),
+					workingDirectory: init.getWorkingDirectory(),
-				shell: init.getShell(),
+					os: protoToOperatingSystem(init.getOperatingSystem()),
-				builtInExtensionsDirectory: init.getBuiltinExtensionsDir(),
+					shell: init.getShell(),
-			};
+					extensionsDirectory: init.getExtensionsDirectory(),
-			this.initDataEmitter.emit(this._initData);
+					builtInExtensionsDirectory: init.getBuiltinExtensionsDir(),
-		} else if (message.hasSuccess()) {
+				};
-			this.emitSuccess(message.getSuccess()!);
+				this.initDataEmitter.emit(this._initData);
-		} else if (message.hasFail()) {
+				break;
-			this.emitFail(message.getFail()!);
+			case ServerMessage.MsgCase.SUCCESS:
-		} else if (message.hasEvent()) {
+				this.emitSuccess(message.getSuccess()!);
-			await this.emitEvent(message.getEvent()!);
+				break;
-		} else if (message.hasCallback()) {
+			case ServerMessage.MsgCase.FAIL:
-			await this.runCallback(message.getCallback()!);
+				this.emitFail(message.getFail()!);
-		} else if (message.hasSharedProcessActive()) {
+				break;
-			const sharedProcessActiveMessage = message.getSharedProcessActive()!;
+			case ServerMessage.MsgCase.EVENT:
-			this.sharedProcessActiveEmitter.emit({
+				await this.emitEvent(message.getEvent()!);
-				socketPath: sharedProcessActiveMessage.getSocketPath(),
+				break;
-				logPath: sharedProcessActiveMessage.getLogPath(),
+			case ServerMessage.MsgCase.CALLBACK:
-			});
+				await this.runCallback(message.getCallback()!);
-		} else if (message.hasPong()) {
+				break;
-			// Nothing to do since pings are on a timer rather than waiting for the
+			case ServerMessage.MsgCase.SHARED_PROCESS_ACTIVE:
-			// next pong in case a message from either the client or server is dropped
+				const sharedProcessActiveMessage = message.getSharedProcessActive()!;
-			// which would break the ping cycle.
+				this.sharedProcessActiveEmitter.emit({
-		} else {
+					socketPath: sharedProcessActiveMessage.getSocketPath(),
-			throw new Error("unknown message type");
+					logPath: sharedProcessActiveMessage.getLogPath(),
+				});
+				break;
+			case ServerMessage.MsgCase.PONG:
+				// Nothing to do since pings are on a timer rather than waiting for the
+				// next pong in case a message from either the client or server is dropped
+				// which would break the ping cycle.
+				break;
+			default:
+				throw new Error("unknown message type");
 		}
 	}
 
-	private emitSuccess(message: SuccessMessage): void {
+	/**
+	 * Convert message to a success event.
+	 */
+	private emitSuccess(message: Method.Success): void {
 		logger.trace(() => [
 			"received resolve",
 			field("id", message.getId()),
@@ -297,7 +317,10 @@ export class Client {
 		this.successEmitter.emit(message.getId(), message);
 	}
 
-	private emitFail(message: FailMessage): void {
+	/**
+	 * Convert message to a fail event.
+	 */
+	private emitFail(message: Method.Fail): void {
 		logger.trace(() => [
 			"received reject",
 			field("id", message.getId()),
@@ -313,7 +336,7 @@ export class Client {
 	 * request before it emits. Instead, emit all events from the server so all
 	 * events are always caught on the client.
 	 */
-	private async emitEvent(message: EventMessage): Promise<void> {
+	private async emitEvent(message: Event): Promise<void> {
 		const eventMessage = message.getNamedEvent()! || message.getNumberedEvent()!;
 		const proxyId = message.getNamedEvent()
 			? protoToModule(message.getNamedEvent()!.getModule())
@@ -324,10 +347,9 @@ export class Client {
 			"received event",
 			field("proxyId", proxyId),
 			field("event", event),
-			field("args", eventMessage.getArgsList()),
 		]);
 
-		const args = eventMessage.getArgsList().map((a) => this.parse(a));
+		const args = eventMessage.getArgsList().map((a) => this.protoToArgument(a));
 		this.eventEmitter.emit(proxyId, { event, args });
 	}
 
@@ -339,7 +361,7 @@ export class Client {
 	 * also only be used when passed together with the method. If they are sent
 	 * afterward, they may never be called due to timing issues.
 	 */
-	private async runCallback(message: CallbackMessage): Promise<void> {
+	private async runCallback(message: Callback): Promise<void> {
 		const callbackMessage = message.getNamedCallback()! || message.getNumberedCallback()!;
 		const proxyId = message.getNamedCallback()
 			? protoToModule(message.getNamedCallback()!.getModule())
@@ -350,16 +372,15 @@ export class Client {
 			"running callback",
 			field("proxyId", proxyId),
 			field("callbackId", callbackId),
-			field("args", callbackMessage.getArgsList()),
 		]);
-		const args = callbackMessage.getArgsList().map((a) => this.parse(a));
+		const args = callbackMessage.getArgsList().map((a) => this.protoToArgument(a));
 		this.getProxy(proxyId).callbacks.get(callbackId)!(...args);
 	}
 
 	/**
 	 * Start the ping loop. Does nothing if already pinging.
 	 */
-	private startPinging = (): void => {
+	private readonly startPinging = (): void => {
 		if (typeof this.pingTimeout !== "undefined") {
 			return;
 		}
@@ -450,12 +471,12 @@ export class Client {
 			callbacks: new Map(),
 		});
 
-		instance.onDone((disconnected: boolean) => {
+		instance.onDone(() => {
 			const log = (): void => {
 				logger.trace(() => [
 					typeof proxyId === "number" ? "disposed proxy" : "disposed proxy callbacks",
 					field("proxyId", proxyId),
-					field("disconnected", disconnected),
+					field("disconnected", this.disconnected),
 					field("callbacks", Array.from(this.proxies.values()).reduce((count, proxy) => count + proxy.callbacks.size, 0)),
 					field("success listeners", this.successEmitter.counts),
 					field("fail listeners", this.failEmitter.counts),
@@ -471,7 +492,7 @@ export class Client {
 					this.eventEmitter.dispose(proxyId);
 					log();
 				};
-				if (!disconnected) {
+				if (!this.disconnected) {
 					instance.dispose().then(dispose).catch(dispose);
 				} else {
 					dispose();
@@ -496,10 +517,16 @@ export class Client {
 		await this.getProxy(proxyId).promise;
 	}
 
-	private parse(value?: string, promise?: Promise<any>): any {
+	/**
-		return parse(value, undefined, (id) => this.createProxy(id, promise));
+	 * Same as protoToArgument except provides createProxy.
+	 */
+	private protoToArgument(value?: Argument, promise?: Promise<any>): any {
+		return protoToArgument(value, undefined, (id) => this.createProxy(id, promise));
 	}
 
+	/**
+	 * Get a proxy. Error if it doesn't exist.
+	 */
 	private getProxy(proxyId: number | Module): ProxyData {
 		if (!this.proxies.has(proxyId)) {
 			throw new Error(`proxy ${proxyId} disposed too early`);

packages/protocol/src/browser/modules/child_process.ts

@@ -6,6 +6,8 @@ import { ClientProxy } from "../../common/proxy";
 import { ChildProcessModuleProxy, ChildProcessProxy, ChildProcessProxies } from "../../node/modules/child_process";
 import { Readable, Writable } from "./stream";
 
+// tslint:disable completed-docs
+
 export class ChildProcess extends ClientProxy<ChildProcessProxy> implements cp.ChildProcess {
 	public readonly stdin: stream.Writable;
 	public readonly stdout: stream.Readable;
@@ -23,10 +25,10 @@ export class ChildProcess extends ClientProxy<ChildProcessProxy> implements cp.C
 		this.stderr = new Readable(proxyPromises.then((p) => p.stderr!));
 		this.stdio = [this.stdin, this.stdout, this.stderr];
 
-		this.proxy.getPid().then((pid) => {
+		this.catch(this.proxy.getPid().then((pid) => {
 			this._pid = pid;
 			this._connected = true;
-		});
+		}));
 		this.on("disconnect", () => this._connected = false);
 		this.on("exit", () => {
 			this._connected = false;
@@ -48,19 +50,19 @@ export class ChildProcess extends ClientProxy<ChildProcessProxy> implements cp.C
 
 	public kill(): void {
 		this._killed = true;
-		this.proxy.kill();
+		this.catch(this.proxy.kill());
 	}
 
 	public disconnect(): void {
-		this.proxy.disconnect();
+		this.catch(this.proxy.disconnect());
 	}
 
 	public ref(): void {
-		this.proxy.ref();
+		this.catch(this.proxy.ref());
 	}
 
 	public unref(): void {
-		this.proxy.unref();
+		this.catch(this.proxy.unref());
 	}
 
 	public send(
@@ -87,6 +89,14 @@ export class ChildProcess extends ClientProxy<ChildProcessProxy> implements cp.C
 
 		return true; // Always true since we can't get this synchronously.
 	}
+
+	/**
+	 * Exit and close the process when disconnected.
+	 */
+	protected handleDisconnect(): void {
+		this.emit("exit", 1);
+		this.emit("close");
+	}
 }
 
 export class ChildProcessModule {

packages/protocol/src/browser/modules/fs.ts

@@ -1,15 +1,50 @@
 import * as fs from "fs";
 import { callbackify } from "util";
-import { ClientProxy } from "../../common/proxy";
+import { ClientProxy, Batch } from "../../common/proxy";
 import { IEncodingOptions, IEncodingOptionsCallback } from "../../common/util";
 import { FsModuleProxy, Stats as IStats, WatcherProxy, WriteStreamProxy } from "../../node/modules/fs";
 import { Writable  } from "./stream";
 
 // tslint:disable no-any
+// tslint:disable completed-docs
+
+class StatBatch extends Batch<IStats, { path: fs.PathLike }> {
+	public constructor(private readonly proxy: FsModuleProxy) {
+		super();
+	}
+
+	protected remoteCall(batch: { path: fs.PathLike }[]): Promise<(IStats | Error)[]> {
+		return this.proxy.statBatch(batch);
+	}
+}
+
+class LstatBatch extends Batch<IStats, { path: fs.PathLike }> {
+	public constructor(private readonly proxy: FsModuleProxy) {
+		super();
+	}
+
+	protected remoteCall(batch: { path: fs.PathLike }[]): Promise<(IStats | Error)[]> {
+		return this.proxy.lstatBatch(batch);
+	}
+}
+
+class ReaddirBatch extends Batch<Buffer[] | fs.Dirent[] | string[], { path: fs.PathLike, options: IEncodingOptions }> {
+	public constructor(private readonly proxy: FsModuleProxy) {
+		super();
+	}
+
+	protected remoteCall(queue: { path: fs.PathLike, options: IEncodingOptions }[]): Promise<(Buffer[] | fs.Dirent[] | string[] | Error)[]> {
+		return this.proxy.readdirBatch(queue);
+	}
+}
 
 class Watcher extends ClientProxy<WatcherProxy> implements fs.FSWatcher {
 	public close(): void {
-		this.proxy.close();
+		this.catch(this.proxy.close());
+	}
+
+	protected handleDisconnect(): void {
+		this.emit("close");
 	}
 }
 
@@ -23,12 +58,20 @@ class WriteStream extends Writable<WriteStreamProxy> implements fs.WriteStream {
 	}
 
 	public close(): void {
-		this.proxy.close();
+		this.catch(this.proxy.close());
 	}
 }
 
 export class FsModule {
-	public constructor(private readonly proxy: FsModuleProxy) {}
+	private readonly statBatch: StatBatch;
+	private readonly lstatBatch: LstatBatch;
+	private readonly readdirBatch: ReaddirBatch;
+
+	public constructor(private readonly proxy: FsModuleProxy) {
+		this.statBatch = new StatBatch(this.proxy);
+		this.lstatBatch = new LstatBatch(this.proxy);
+		this.readdirBatch = new ReaddirBatch(this.proxy);
+	}
 
 	public access = (path: fs.PathLike, mode: number | undefined | ((err: NodeJS.ErrnoException) => void), callback?: (err: NodeJS.ErrnoException) => void): void => {
 		if (typeof mode === "function") {
@@ -72,9 +115,7 @@ export class FsModule {
 	}
 
 	public exists = (path: fs.PathLike, callback: (exists: boolean) => void): void => {
-		callbackify(this.proxy.exists)(path, (exists) => {
+		this.proxy.exists(path).then((exists) => callback(exists)).catch(() => callback(false));
-			callback!(exists as any);
-		});
 	}
 
 	public fchmod = (fd: number, mode: string | number, callback: (err: NodeJS.ErrnoException) => void): void => {
@@ -124,7 +165,7 @@ export class FsModule {
 	}
 
 	public lstat = (path: fs.PathLike, callback: (err: NodeJS.ErrnoException, stats: fs.Stats) => void): void => {
-		callbackify(this.proxy.lstat)(path, (error, stats) => {
+		callbackify(this.lstatBatch.add)({ path }, (error, stats) => {
 			callback(error, stats && new Stats(stats));
 		});
 	}
@@ -175,7 +216,7 @@ export class FsModule {
 			callback = options;
 			options = undefined;
 		}
-		callbackify(this.proxy.readdir)(path, options, callback!);
+		callbackify(this.readdirBatch.add)({ path, options }, callback!);
 	}
 
 	public readlink = (path: fs.PathLike, options: IEncodingOptionsCallback, callback?: (err: NodeJS.ErrnoException, linkString: string | Buffer) => void): void => {
@@ -203,7 +244,7 @@ export class FsModule {
 	}
 
 	public stat = (path: fs.PathLike, callback: (err: NodeJS.ErrnoException, stats: fs.Stats) => void): void => {
-		callbackify(this.proxy.stat)(path, (error, stats) => {
+		callbackify(this.statBatch.add)({ path }, (error, stats) => {
 			callback(error, stats && new Stats(stats));
 		});
 	}
@@ -276,17 +317,7 @@ export class FsModule {
 }
 
 class Stats implements fs.Stats {
-	public readonly atime: Date;
+	public constructor(private readonly stats: IStats) {}
-	public readonly mtime: Date;
-	public readonly ctime: Date;
-	public readonly birthtime: Date;
-
-	public constructor(private readonly stats: IStats) {
-		this.atime = new Date(stats.atime);
-		this.mtime = new Date(stats.mtime);
-		this.ctime = new Date(stats.ctime);
-		this.birthtime = new Date(stats.birthtime);
-	}
 
 	public get dev(): number { return this.stats.dev; }
 	public get ino(): number { return this.stats.ino; }
@@ -298,6 +329,10 @@ class Stats implements fs.Stats {
 	public get size(): number { return this.stats.size; }
 	public get blksize(): number { return this.stats.blksize; }
 	public get blocks(): number { return this.stats.blocks; }
+	public get atime(): Date { return this.stats.atime; }
+	public get mtime(): Date { return this.stats.mtime; }
+	public get ctime(): Date { return this.stats.ctime; }
+	public get birthtime(): Date { return this.stats.birthtime; }
 	public get atimeMs(): number { return this.stats.atimeMs; }
 	public get mtimeMs(): number { return this.stats.mtimeMs; }
 	public get ctimeMs(): number { return this.stats.ctimeMs; }

packages/protocol/src/browser/modules/net.ts

@@ -4,6 +4,8 @@ import { ClientProxy } from "../../common/proxy";
 import { NetModuleProxy, NetServerProxy, NetSocketProxy } from "../../node/modules/net";
 import { Duplex } from "./stream";
 
+// tslint:disable completed-docs
+
 export class Socket extends Duplex<NetSocketProxy> implements net.Socket {
 	private _connecting: boolean = false;
 	private _destroyed: boolean = false;
@@ -29,9 +31,8 @@ export class Socket extends Duplex<NetSocketProxy> implements net.Socket {
 		if (callback) {
 			this.on("connect", callback as () => void);
 		}
-		this.proxy.connect(options, host);
 
-		return this;
+		return this.catch(this.proxy.connect(options, host));
 	}
 
 	// tslint:disable-next-line no-any
@@ -117,24 +118,30 @@ export class Socket extends Duplex<NetSocketProxy> implements net.Socket {
 	}
 
 	public unref(): void {
-		this.proxy.unref();
+		this.catch(this.proxy.unref());
 	}
 
 	public ref(): void {
-		this.proxy.ref();
+		this.catch(this.proxy.ref());
 	}
 }
 
 export class Server extends ClientProxy<NetServerProxy> implements net.Server {
+	private socketId = 0;
 	private readonly sockets = new Map<number, net.Socket>();
 	private _listening: boolean = false;
 
 	public constructor(proxyPromise: Promise<NetServerProxy> | NetServerProxy) {
 		super(proxyPromise);
 
-		this.proxy.onConnection((socketProxy) => {
+		this.catch(this.proxy.onConnection((socketProxy) => {
-			this.emit("connection", new Socket(socketProxy));
+			const socket = new Socket(socketProxy);
-		});
+			const socketId = this.socketId++;
+			this.sockets.set(socketId, socket);
+			socket.on("error", () => this.sockets.delete(socketId));
+			socket.on("close", () => this.sockets.delete(socketId));
+			this.emit("connection", socket);
+		}));
 
 		this.on("listening", () => this._listening = true);
 		this.on("error", () => this._listening = false);
@@ -154,9 +161,7 @@ export class Server extends ClientProxy<NetServerProxy> implements net.Server {
 			this.on("listening", callback as () => void);
 		}
 
-		this.proxy.listen(handle, hostname, backlog);
+		return this.catch(this.proxy.listen(handle, hostname, backlog));
-
-		return this;
 	}
 
 	public get connections(): number {
@@ -180,26 +185,25 @@ export class Server extends ClientProxy<NetServerProxy> implements net.Server {
 		if (callback) {
 			this.on("close", callback);
 		}
-		this.proxy.close();
 
-		return this;
+		return this.catch(this.proxy.close());
 	}
 
 	public ref(): this {
-		this.proxy.ref();
+		return this.catch(this.proxy.ref());
-
-		return this;
 	}
 
 	public unref(): this {
-		this.proxy.unref();
+		return this.catch(this.proxy.unref());
-
-		return this;
 	}
 
 	public getConnections(cb: (error: Error | null, count: number) => void): void {
 		cb(null, this.sockets.size);
 	}
+
+	protected handleDisconnect(): void {
+		this.emit("close");
+	}
 }
 
 type NodeNet = typeof net;

packages/protocol/src/browser/modules/node-pty.ts

@@ -2,17 +2,28 @@ import * as pty from "node-pty";
 import { ClientProxy } from "../../common/proxy";
 import { NodePtyModuleProxy, NodePtyProcessProxy } from "../../node/modules/node-pty";
 
+// tslint:disable completed-docs
+
 export class NodePtyProcess extends ClientProxy<NodePtyProcessProxy> implements pty.IPty {
 	private _pid = -1;
 	private _process = "";
 
-	public constructor(proxyPromise: Promise<NodePtyProcessProxy>) {
+	public constructor(
-		super(proxyPromise);
+		private readonly moduleProxy: NodePtyModuleProxy,
-		this.proxy.getPid().then((pid) => this._pid = pid);
+		private readonly file: string,
-		this.proxy.getProcess().then((process) => this._process = process);
+		private readonly args: string[] | string,
+		private readonly options: pty.IPtyForkOptions,
+	) {
+		super(moduleProxy.spawn(file, args, options));
 		this.on("process", (process) => this._process = process);
 	}
 
+	protected initialize(proxyPromise: Promise<NodePtyProcessProxy>): void {
+		super.initialize(proxyPromise);
+		this.catch(this.proxy.getPid().then((p) => this._pid = p));
+		this.catch(this.proxy.getProcess().then((p) => this._process = p));
+	}
+
 	public get pid(): number {
 		return this._pid;
 	}
@@ -22,15 +33,21 @@ export class NodePtyProcess extends ClientProxy<NodePtyProcessProxy> implements
 	}
 
 	public resize(columns: number, rows: number): void {
-		this.proxy.resize(columns, rows);
+		this.catch(this.proxy.resize(columns, rows));
 	}
 
 	public write(data: string): void {
-		this.proxy.write(data);
+		this.catch(this.proxy.write(data));
 	}
 
 	public kill(signal?: string): void {
-		this.proxy.kill(signal);
+		this.catch(this.proxy.kill(signal));
+	}
+
+	protected handleDisconnect(): void {
+		this._process += " (disconnected)";
+		this.emit("data", "\r\n\nLost connection...\r\n\n");
+		this.initialize(this.moduleProxy.spawn(this.file, this.args, this.options));
 	}
 }
 
@@ -40,6 +57,6 @@ export class NodePtyModule implements NodePty {
 	public constructor(private readonly proxy: NodePtyModuleProxy) {}
 
 	public spawn = (file: string, args: string[] | string, options: pty.IPtyForkOptions): pty.IPty => {
-		return new NodePtyProcess(this.proxy.spawn(file, args, options));
+		return new NodePtyProcess(this.proxy, file, args, options);
 	}
 }

packages/protocol/src/browser/modules/spdlog.ts

@@ -2,17 +2,33 @@ import * as spdlog from "spdlog";
 import { ClientProxy } from "../../common/proxy";
 import { RotatingLoggerProxy, SpdlogModuleProxy } from "../../node/modules/spdlog";
 
+// tslint:disable completed-docs
+
 class RotatingLogger extends ClientProxy<RotatingLoggerProxy> implements spdlog.RotatingLogger {
-	public async trace (message: string): Promise<void> { this.proxy.trace(message); }
+	public constructor(
-	public async debug (message: string): Promise<void> { this.proxy.debug(message); }
+		private readonly moduleProxy: SpdlogModuleProxy,
-	public async info (message: string): Promise<void> { this.proxy.info(message); }
+		private readonly name: string,
-	public async warn (message: string): Promise<void> { this.proxy.warn(message); }
+		private readonly filename: string,
-	public async error (message: string): Promise<void> { this.proxy.error(message); }
+		private readonly filesize: number,
-	public async critical (message: string): Promise<void> { this.proxy.critical(message); }
+		private readonly filecount: number,
-	public async setLevel (level: number): Promise<void> { this.proxy.setLevel(level); }
+	) {
-	public async clearFormatters (): Promise<void> { this.proxy.clearFormatters(); }
+		super(moduleProxy.createLogger(name, filename, filesize, filecount));
-	public async flush (): Promise<void> { this.proxy.flush(); }
+	}
-	public async drop (): Promise<void> { this.proxy.drop(); }
+
+	public trace (message: string): void { this.catch(this.proxy.trace(message)); }
+	public debug (message: string): void { this.catch(this.proxy.debug(message)); }
+	public info (message: string): void { this.catch(this.proxy.info(message)); }
+	public warn (message: string): void { this.catch(this.proxy.warn(message)); }
+	public error (message: string): void { this.catch(this.proxy.error(message)); }
+	public critical (message: string): void { this.catch(this.proxy.critical(message)); }
+	public setLevel (level: number): void { this.catch(this.proxy.setLevel(level)); }
+	public clearFormatters (): void { this.catch(this.proxy.clearFormatters()); }
+	public flush (): void { this.catch(this.proxy.flush()); }
+	public drop (): void { this.catch(this.proxy.drop()); }
+
+	protected handleDisconnect(): void {
+		this.initialize(this.moduleProxy.createLogger(this.name, this.filename, this.filesize, this.filecount));
+	}
 }
 
 export class SpdlogModule {
@@ -21,12 +37,20 @@ export class SpdlogModule {
 	public constructor(private readonly proxy: SpdlogModuleProxy) {
 		this.RotatingLogger = class extends RotatingLogger {
 			public constructor(name: string, filename: string, filesize: number, filecount: number) {
-				super(proxy.createLogger(name, filename, filesize, filecount));
+				super(proxy, name, filename, filesize, filecount);
 			}
 		};
 	}
 
-	public setAsyncMode = (bufferSize: number, flushInterval: number): void => {
+	public setAsyncMode = (bufferSize: number, flushInterval: number): Promise<void> => {
-		this.proxy.setAsyncMode(bufferSize, flushInterval);
+		return this.proxy.setAsyncMode(bufferSize, flushInterval);
+	}
+
+	public createRotatingLogger(name: string, filename: string, filesize: number, filecount: number): RotatingLogger {
+		return new RotatingLogger(this.proxy, name, filename, filesize, filecount);
+	}
+
+	public createRotatingLoggerAsync(name: string, filename: string, filesize: number, filecount: number): Promise<RotatingLogger> {
+		return Promise.resolve(this.createRotatingLogger(name, filename, filesize, filecount));
 	}
 }

packages/protocol/src/browser/modules/stream.ts

@@ -3,6 +3,8 @@ import { callbackify } from "util";
 import { ClientProxy } from "../../common/proxy";
 import { DuplexProxy, IReadableProxy, WritableProxy } from "../../node/modules/stream";
 
+// tslint:disable completed-docs
+
 export class Writable<T extends WritableProxy = WritableProxy> extends ClientProxy<T> implements stream.Writable {
 	public get writable(): boolean {
 		throw new Error("not implemented");
@@ -41,13 +43,11 @@ export class Writable<T extends WritableProxy = WritableProxy> extends ClientPro
 	}
 
 	public destroy(): void {
-		this.proxy.destroy();
+		this.catch(this.proxy.destroy());
 	}
 
 	public setDefaultEncoding(encoding: string): this {
-		this.proxy.setDefaultEncoding(encoding);
+		return this.catch(this.proxy.setDefaultEncoding(encoding));
-
-		return this;
 	}
 
 	// tslint:disable-next-line no-any
@@ -81,6 +81,11 @@ export class Writable<T extends WritableProxy = WritableProxy> extends ClientPro
 			}
 		});
 	}
+
+	protected handleDisconnect(): void {
+		this.emit("close");
+		this.emit("finish");
+	}
 }
 
 export class Readable<T extends IReadableProxy = IReadableProxy> extends ClientProxy<T> implements stream.Readable {
@@ -146,13 +151,16 @@ export class Readable<T extends IReadableProxy = IReadableProxy> extends ClientP
 	}
 
 	public destroy(): void {
-		this.proxy.destroy();
+		this.catch(this.proxy.destroy());
 	}
 
 	public setEncoding(encoding: string): this {
-		this.proxy.setEncoding(encoding);
+		return this.catch(this.proxy.setEncoding(encoding));
+	}
 
-		return this;
+	protected handleDisconnect(): void {
+		this.emit("close");
+		this.emit("end");
 	}
 }
 
@@ -226,8 +234,11 @@ export class Duplex<T extends DuplexProxy = DuplexProxy> extends Writable<T> imp
 	}
 
 	public setEncoding(encoding: string): this {
-		this.proxy.setEncoding(encoding);
+		return this.catch(this.proxy.setEncoding(encoding));
+	}
 
-		return this;
+	protected handleDisconnect(): void {
+		super.handleDisconnect();
+		this.emit("end");
 	}
 }

packages/protocol/src/browser/modules/trash.ts

@@ -1,6 +1,8 @@
 import * as trash from "trash";
 import { TrashModuleProxy } from "../../node/modules/trash";
 
+// tslint:disable completed-docs
+
 export class TrashModule {
 	public constructor(private readonly proxy: TrashModuleProxy) {}
 

packages/protocol/src/common/connection.ts

@@ -23,6 +23,7 @@ export interface InitData {
 	readonly homeDirectory: string;
 	readonly tmpDirectory: string;
 	readonly shell: string;
+	readonly extensionsDirectory: string;
 	readonly builtInExtensionsDirectory: string;
 }
 

packages/protocol/src/common/proxy.ts

@@ -29,21 +29,77 @@ const unpromisify = <T extends ServerProxy>(proxyPromise: Promise<T>): T => {
  * need a bunch of `then` calls everywhere.
  */
 export abstract class ClientProxy<T extends ServerProxy> extends EventEmitter {
-	protected readonly proxy: T;
+	private _proxy: T | undefined;
 
 	/**
 	 * You can specify not to bind events in order to avoid emitting twice for
 	 * duplex streams.
 	 */
-	public constructor(proxyPromise: Promise<T> | T, bindEvents: boolean = true) {
+	public constructor(
+		proxyPromise: Promise<T> | T,
+		private readonly bindEvents: boolean = true,
+	) {
 		super();
-		this.proxy = isPromise(proxyPromise) ? unpromisify(proxyPromise) : proxyPromise;
+		this.initialize(proxyPromise);
-		if (bindEvents) {
+		if (this.bindEvents) {
-			this.proxy.onEvent((event, ...args): void => {
+			this.on("disconnected", (error) => {
-				this.emit(event, ...args);
+				try {
+					this.emit("error", error);
+				} catch (error) {
+					// If nothing is listening, EventEmitter will throw an error.
+				}
+				this.handleDisconnect();
 			});
 		}
 	}
+
+	/**
+	 * Remove an event listener.
+	 */
+	public off(event: string, cb: (...args: any[]) => void): this {
+		// Fill it here because the fill we're using to provide EventEmitter for the
+		// browser doesn't appear to include `off`.
+		this.removeListener(event, cb);
+
+		return this;
+	}
+
+	protected get proxy(): T {
+		if (!this._proxy) {
+			throw new Error("not initialized");
+		}
+
+		return this._proxy;
+	}
+
+	/**
+	 * Initialize the proxy by unpromisifying if necessary and binding to its
+	 * events.
+	 */
+	protected initialize(proxyPromise: Promise<T> | T): void {
+		this._proxy = isPromise(proxyPromise) ? unpromisify(proxyPromise) : proxyPromise;
+		if (this.bindEvents) {
+			this.catch(this.proxy.onEvent((event, ...args): void => {
+				this.emit(event, ...args);
+			}));
+		}
+	}
+
+	/**
+	 * Perform necessary cleanup on disconnect (or reconnect).
+	 */
+	protected abstract handleDisconnect(): void;
+
+	/**
+	 * Emit an error event if the promise errors.
+	 */
+	protected catch(promise?: Promise<any>): this {
+		if (promise) {
+			promise.catch((e) => this.emit("error", e));
+		}
+
+		return this;
+	}
 }
 
 /**
@@ -54,6 +110,9 @@ export abstract class ClientProxy<T extends ServerProxy> extends EventEmitter {
  * from those child proxies and fail to dispose them properly.
  */
 export interface ServerProxy {
+	/**
+	 * Dispose the proxy.
+	 */
 	dispose(): Promise<void>;
 
 	/**
@@ -73,6 +132,9 @@ export interface ServerProxy {
 	onEvent(cb: (event: string, ...args: any[]) => void): Promise<void>;
 }
 
+/**
+ * Supported top-level module proxies.
+ */
 export enum Module {
 	Fs = "fs",
 	ChildProcess = "child_process",
@@ -81,3 +143,82 @@ export enum Module {
 	NodePty = "node-pty",
 	Trash = "trash",
 }
+
+interface BatchItem<T, A> {
+	args: A;
+	resolve: (t: T) => void;
+	reject: (e: Error) => void;
+}
+
+/**
+ * Batch remote calls.
+ */
+export abstract class Batch<T, A> {
+	private idleTimeout: number | NodeJS.Timer | undefined;
+	private maxTimeout: number | NodeJS.Timer | undefined;
+	private batch = <BatchItem<T, A>[]>[];
+
+	public constructor(
+		/**
+		 * Flush after reaching this amount of time.
+		 */
+		private readonly maxTime: number = 1000,
+		/**
+		 * Flush after reaching this count.
+		 */
+		private readonly maxCount: number = 100,
+		/**
+		 * Flush after not receiving more requests for this amount of time.
+		 * This is pretty low by default so essentially we just end up batching
+		 * requests that are all made at the same time.
+		 */
+		private readonly idleTime: number = 1,
+	) {}
+
+	public add = (args: A): Promise<T> => {
+		return new Promise((resolve, reject): void => {
+			this.batch.push({
+				args,
+				resolve,
+				reject,
+			});
+			if (this.batch.length >= this.maxCount) {
+				this.flush();
+			} else {
+				clearTimeout(this.idleTimeout as any);
+				this.idleTimeout = setTimeout(this.flush, this.idleTime);
+				if (typeof this.maxTimeout === "undefined") {
+					this.maxTimeout = setTimeout(this.flush, this.maxTime);
+				}
+			}
+		});
+	}
+
+	/**
+	 * Perform remote call for a batch.
+	 */
+	protected abstract remoteCall(batch: A[]): Promise<(T | Error)[]>;
+
+	/**
+	 * Flush out the current batch.
+	 */
+	private readonly flush = (): void => {
+		clearTimeout(this.idleTimeout as any);
+		clearTimeout(this.maxTimeout as any);
+		this.maxTimeout = undefined;
+
+		const batch = this.batch;
+		this.batch = [];
+
+		this.remoteCall(batch.map((q) => q.args)).then((results) => {
+			batch.forEach((item, i) => {
+				const result = results[i];
+				if (result && result instanceof Error) {
+					item.reject(result);
+				} else {
+					item.resolve(result);
+				}
+			});
+		}).catch((error) => batch.forEach((item) => item.reject(error)));
+	}
+}

packages/protocol/src/common/util.ts

@@ -1,4 +1,4 @@
-import { Module as ProtoModule, WorkingInitMessage } from "../proto";
+import { Argument, Module as ProtoModule, WorkingInit } from "../proto";
 import { OperatingSystem } from "../common/connection";
 import { Module, ServerProxy } from "./proxy";
 
@@ -29,227 +29,151 @@ export type IEncodingOptions = {
 
 export type IEncodingOptionsCallback = IEncodingOptions | ((err: NodeJS.ErrnoException, ...args: any[]) => void);
 
-interface StringifiedError {
-	type: "error";
-	data: {
-		message: string;
-		stack?: string;
-		code?: string;
-	};
-}
-
-interface StringifiedBuffer {
-	type: "buffer";
-	data: number[];
-}
-
-interface StringifiedObject {
-	type: "object";
-	data: { [key: string]: StringifiedValue };
-}
-
-interface StringifiedArray {
-	type: "array";
-	data: StringifiedValue[];
-}
-
-interface StringifiedProxy {
-	type: "proxy";
-	data: {
-		id: number;
-	};
-}
-
-interface StringifiedFunction {
-	type: "function";
-	data: {
-		id: number;
-	};
-}
-
-interface StringifiedUndefined {
-	type: "undefined";
-}
-
-type StringifiedValue = StringifiedFunction | StringifiedProxy
-	| StringifiedUndefined | StringifiedObject | StringifiedArray
-	| StringifiedBuffer | StringifiedError | number | string | boolean | null;
-
-const isPrimitive = (value: any): value is number | string | boolean | null => {
-	return typeof value === "number"
-		|| typeof value === "string"
-		|| typeof value === "boolean"
-		|| value === null;
-};
-
 /**
- * Stringify an argument or a return value.
+ * Convert an argument to proto.
  * If sending a function is possible, provide `storeFunction`.
  * If sending a proxy is possible, provide `storeProxy`.
  */
-export const stringify = (
+export const argumentToProto = (
 	value: any,
 	storeFunction?: (fn: () => void) => number,
 	storeProxy?: (proxy: ServerProxy) => number,
-): string => {
+): Argument => {
-	const convert = (currentValue: any): StringifiedValue => {
+	const convert = (currentValue: any): Argument => {
-		// Errors don't stringify at all. They just become "{}".
+		const message = new Argument();
-		// For some reason when running in Jest errors aren't instances of Error,
+
-		// so also check against the values.
 		if (currentValue instanceof Error
 			|| (currentValue && typeof currentValue.message !== "undefined"
 				&& typeof currentValue.stack !== "undefined")) {
-			return {
+			const arg = new Argument.ErrorValue();
-				type: "error",
+			arg.setMessage(currentValue.message);
-				data: {
+			arg.setStack(currentValue.stack);
-					message: currentValue.message,
+			arg.setCode(currentValue.code);
-					stack: currentValue.stack,
+			message.setError(arg);
-					code: (currentValue as NodeJS.ErrnoException).code,
+		} else if (currentValue instanceof Uint8Array || currentValue instanceof Buffer) {
-				},
+			const arg = new Argument.BufferValue();
-			};
+			arg.setData(currentValue);
-		}
+			message.setBuffer(arg);
-
+		} else if (Array.isArray(currentValue)) {
-		// With stringify, Uint8Array gets turned into objects with each index
+			const arg = new Argument.ArrayValue();
-		// becoming a key for some reason. Then trying to do something like write
+			arg.setDataList(currentValue.map(convert));
-		// that data results in [object Object] being written. Stringify them like
+			message.setArray(arg);
-		// a Buffer instead. Also handle Buffer so it doesn't get caught by the
+		} else if (isProxy(currentValue)) {
-		// object check and to get the same type.
-		if (currentValue instanceof Uint8Array || currentValue instanceof Buffer) {
-			return {
-				type: "buffer",
-				data: Array.from(currentValue),
-			};
-		}
-
-		if (Array.isArray(currentValue)) {
-			return {
-				type: "array",
-				data: currentValue.map((a) => convert(a)),
-			};
-		}
-
-		if (isProxy(currentValue)) {
 			if (!storeProxy) {
 				throw new Error("no way to serialize proxy");
 			}
-
+			const arg = new Argument.ProxyValue();
-			return {
+			arg.setId(storeProxy(currentValue));
-				type: "proxy",
+			message.setProxy(arg);
-				data: {
+		} else if (currentValue instanceof Date
-					id: storeProxy(currentValue),
+			|| (currentValue && typeof currentValue.getTime === "function")) {
-				},
+			const arg = new Argument.DateValue();
-			};
+			arg.setDate(currentValue.toString());
-		}
+			message.setDate(arg);
-
+		} else if (currentValue !== null && typeof currentValue === "object") {
-		if (currentValue !== null && typeof currentValue === "object") {
+			const arg = new Argument.ObjectValue();
-			const converted: { [key: string]: StringifiedValue } = {};
+			const map = arg.getDataMap();
 			Object.keys(currentValue).forEach((key) => {
-				converted[key] = convert(currentValue[key]);
+				map.set(key, convert(currentValue[key]));
 			});
-
+			message.setObject(arg);
-			return {
+		} else if (currentValue === null) {
-				type: "object",
+			message.setNull(new Argument.NullValue());
-				data: converted,
+		} else {
-			};
+			switch (typeof currentValue) {
-		}
+				case "undefined":
-
+					message.setUndefined(new Argument.UndefinedValue());
-		// `undefined` can't be stringified.
+					break;
-		if (typeof currentValue === "undefined") {
+				case "function":
-			return {
+					if (!storeFunction) {
-				type: "undefined",
+						throw new Error("no way to serialize function");
-			};
+					}
-		}
+					const arg = new Argument.FunctionValue();
-
+					arg.setId(storeFunction(currentValue));
-		if (typeof currentValue === "function") {
+					message.setFunction(arg);
-			if (!storeFunction) {
+					break;
-				throw new Error("no way to serialize function");
+				case "number":
+					message.setNumber(currentValue);
+					break;
+				case "string":
+					message.setString(currentValue);
+					break;
+				case "boolean":
+					message.setBoolean(currentValue);
+					break;
+				default:
+					throw new Error(`cannot convert ${typeof currentValue} to proto`);
 			}
-
-			return {
-				type: "function",
-				data: {
-					id: storeFunction(currentValue),
-				},
-			};
 		}
 
-		if (!isPrimitive(currentValue)) {
+		return message;
-			throw new Error(`cannot stringify ${typeof currentValue}`);
-		}
-
-		return currentValue;
 	};
 
-	return JSON.stringify(convert(value));
+	return convert(value);
 };
 
 /**
- * Parse an argument.
+ * Convert proto to an argument.
  * If running a remote callback is supported, provide `runCallback`.
  * If using a remote proxy is supported, provide `createProxy`.
  */
-export const parse = (
+export const protoToArgument = (
-	value?: string,
+	message?: Argument,
 	runCallback?: (id: number, args: any[]) => void,
 	createProxy?: (id: number) => ServerProxy,
 ): any => {
-	const convert = (currentValue: StringifiedValue): any => {
+	const convert = (currentMessage: Argument): any => {
-		if (currentValue && !isPrimitive(currentValue)) {
+		switch (currentMessage.getMsgCase()) {
-			// Would prefer a switch but the types don't seem to work.
+			case Argument.MsgCase.ERROR:
-			if (currentValue.type === "buffer") {
+				const errorMessage = currentMessage.getError()!;
-				return Buffer.from(currentValue.data);
+				const error = new Error(errorMessage.getMessage());
-			}
+				(error as NodeJS.ErrnoException).code = errorMessage.getCode();
-
+				(error as any).originalStack = errorMessage.getStack();
-			if (currentValue.type === "error") {
-				const error = new Error(currentValue.data.message);
-				if (typeof currentValue.data.code !== "undefined") {
-					(error as NodeJS.ErrnoException).code = currentValue.data.code;
-				}
-				(error as any).originalStack = currentValue.data.stack;
 
 				return error;
-			}
+			case Argument.MsgCase.BUFFER:
+				return Buffer.from(currentMessage.getBuffer()!.getData() as Uint8Array);
+			case Argument.MsgCase.ARRAY:
+				return currentMessage.getArray()!.getDataList().map((a) => convert(a));
+			case Argument.MsgCase.PROXY:
+				if (!createProxy) {
+					throw new Error("no way to create proxy");
+				}
 
-			if (currentValue.type === "object") {
+				return createProxy(currentMessage.getProxy()!.getId());
-				const converted: { [key: string]: any } = {};
+			case Argument.MsgCase.DATE:
-				Object.keys(currentValue.data).forEach((key) => {
+				return new Date(currentMessage.getDate()!.getDate());
-					converted[key] = convert(currentValue.data[key]);
+			case Argument.MsgCase.OBJECT:
+				const obj: { [Key: string]: any } = {};
+				currentMessage.getObject()!.getDataMap().forEach((argument, key) => {
+					obj[key] = convert(argument);
 				});
 
-				return converted;
+				return obj;
-			}
+			case Argument.MsgCase.UNDEFINED:
-
-			if (currentValue.type === "array") {
-				return currentValue.data.map(convert);
-			}
-
-			if (currentValue.type === "undefined") {
 				return undefined;
-			}
+			case Argument.MsgCase.NULL:
-
+				return null;
-			if (currentValue.type === "function") {
+			case Argument.MsgCase.FUNCTION:
 				if (!runCallback) {
 					throw new Error("no way to run remote callback");
 				}
 
 				return (...args: any[]): void => {
-					return runCallback(currentValue.data.id, args);
+					return runCallback(currentMessage.getFunction()!.getId(), args);
 				};
-			}
+			case Argument.MsgCase.NUMBER:
-
+				return currentMessage.getNumber();
-			if (currentValue.type === "proxy") {
+			case Argument.MsgCase.STRING:
-				if (!createProxy) {
+				return currentMessage.getString();
-					throw new Error("no way to create proxy");
+			case Argument.MsgCase.BOOLEAN:
-				}
+				return currentMessage.getBoolean();
-
+			default:
-				return createProxy(currentValue.data.id);
+				throw new Error("cannot convert unexpected proto to argument");
-			}
 		}
-
-		return currentValue;
 	};
 
-	return value && convert(JSON.parse(value));
+	return message && convert(message);
 };
 
 export const protoToModule = (protoModule: ProtoModule): Module => {
@@ -276,20 +200,20 @@ export const moduleToProto = (moduleName: Module): ProtoModule => {
 	}
 };
 
-export const protoToOperatingSystem = (protoOp: WorkingInitMessage.OperatingSystem): OperatingSystem => {
+export const protoToOperatingSystem = (protoOp: WorkingInit.OperatingSystem): OperatingSystem => {
 	switch (protoOp) {
-		case WorkingInitMessage.OperatingSystem.WINDOWS: return OperatingSystem.Windows;
+		case WorkingInit.OperatingSystem.WINDOWS: return OperatingSystem.Windows;
-		case WorkingInitMessage.OperatingSystem.LINUX: return OperatingSystem.Linux;
+		case WorkingInit.OperatingSystem.LINUX: return OperatingSystem.Linux;
-		case WorkingInitMessage.OperatingSystem.MAC: return OperatingSystem.Mac;
+		case WorkingInit.OperatingSystem.MAC: return OperatingSystem.Mac;
 		default: throw new Error(`unsupported operating system ${protoOp}`);
 	}
 };
 
-export const platformToProto = (platform: NodeJS.Platform): WorkingInitMessage.OperatingSystem => {
+export const platformToProto = (platform: NodeJS.Platform): WorkingInit.OperatingSystem => {
 	switch (platform) {
-		case "win32": return WorkingInitMessage.OperatingSystem.WINDOWS;
+		case "win32": return WorkingInit.OperatingSystem.WINDOWS;
-		case "linux": return WorkingInitMessage.OperatingSystem.LINUX;
+		case "linux": return WorkingInit.OperatingSystem.LINUX;
-		case "darwin": return WorkingInitMessage.OperatingSystem.MAC;
+		case "darwin": return WorkingInit.OperatingSystem.MAC;
 		default: throw new Error(`unrecognized platform "${platform}"`);
 	}
 };

packages/protocol/src/node/modules/child_process.ts

@@ -3,6 +3,8 @@ import { ServerProxy } from "../../common/proxy";
 import { preserveEnv } from "../../common/util";
 import { WritableProxy, ReadableProxy } from "./stream";
 
+// tslint:disable completed-docs
+
 export type ForkProvider = (modulePath: string, args?: string[], options?: cp.ForkOptions) => cp.ChildProcess;
 
 export class ChildProcessProxy implements ServerProxy {
@@ -26,7 +28,7 @@ export class ChildProcessProxy implements ServerProxy {
 
 	// tslint:disable-next-line no-any
 	public async send(message: any): Promise<void> {
-		return new Promise((resolve, reject) => {
+		return new Promise((resolve, reject): void => {
 			this.process.send(message, (error) => {
 				if (error) {
 					reject(error);
@@ -46,8 +48,8 @@ export class ChildProcessProxy implements ServerProxy {
 	}
 
 	public async dispose(): Promise<void> {
-		this.kill();
+		this.process.kill();
-		setTimeout(() => this.kill("SIGKILL"), 5000); // Double tap.
+		setTimeout(() => this.process.kill("SIGKILL"), 5000); // Double tap.
 	}
 
 	// tslint:disable-next-line no-any
@@ -62,9 +64,9 @@ export class ChildProcessProxy implements ServerProxy {
 
 export interface ChildProcessProxies {
 	childProcess: ChildProcessProxy;
-	stdin?: WritableProxy;
+	stdin?: WritableProxy | null;
-	stdout?: ReadableProxy;
+	stdout?: ReadableProxy | null;
-	stderr?: ReadableProxy;
+	stderr?: ReadableProxy | null;
 }
 
 export class ChildProcessModuleProxy {

packages/protocol/src/node/modules/fs.ts

@@ -4,6 +4,8 @@ import { ServerProxy } from "../../common/proxy";
 import { IEncodingOptions } from "../../common/util";
 import { WritableProxy } from "./stream";
 
+// tslint:disable completed-docs
+
 /**
  * A serializable version of fs.Stats.
  */
@@ -22,10 +24,10 @@ export interface Stats {
 	mtimeMs: number;
 	ctimeMs: number;
 	birthtimeMs: number;
-	atime: Date | string;
+	atime: Date;
-	mtime: Date | string;
+	mtime: Date;
-	ctime: Date | string;
+	ctime: Date;
-	birthtime: Date | string;
+	birthtime: Date;
 	_isFile: boolean;
 	_isDirectory: boolean;
 	_isBlockDevice: boolean;
@@ -41,13 +43,13 @@ export class WriteStreamProxy extends WritableProxy<fs.WriteStream> {
 	}
 
 	public async dispose(): Promise<void> {
-		super.dispose();
+		await super.dispose();
 		this.stream.close();
 	}
 
 	// tslint:disable-next-line no-any
 	public async onEvent(cb: (event: string, ...args: any[]) => void): Promise<void> {
-		super.onEvent(cb);
+		await super.onEvent(cb);
 		this.stream.on("open", (fd) => cb("open", fd));
 	}
 }
@@ -109,7 +111,7 @@ export class FsModuleProxy {
 	}
 
 	public exists(path: fs.PathLike): Promise<boolean> {
-		return promisify(fs.exists)(path);
+		return promisify(fs.exists)(path); // tslint:disable-line deprecation
 	}
 
 	public fchmod(fd: number, mode: string | number): Promise<void> {
@@ -156,6 +158,10 @@ export class FsModuleProxy {
 		return this.makeStatsSerializable(await promisify(fs.lstat)(path));
 	}
 
+	public async lstatBatch(args: { path: fs.PathLike }[]): Promise<(Stats | Error)[]> {
+		return Promise.all(args.map((a) => this.lstat(a.path).catch((e) => e)));
+	}
+
 	public mkdir(path: fs.PathLike, mode: number | string | fs.MakeDirectoryOptions | undefined | null): Promise<void> {
 		return promisify(fs.mkdir)(path, mode);
 	}
@@ -169,7 +175,7 @@ export class FsModuleProxy {
 	}
 
 	public read(fd: number, length: number, position: number | null): Promise<{ bytesRead: number, buffer: Buffer }> {
-		const buffer = new Buffer(length);
+		const buffer = Buffer.alloc(length);
 
 		return promisify(fs.read)(fd, buffer, 0, length, position);
 	}
@@ -182,6 +188,10 @@ export class FsModuleProxy {
 		return promisify(fs.readdir)(path, options);
 	}
 
+	public readdirBatch(args: { path: fs.PathLike, options: IEncodingOptions }[]): Promise<(Buffer[] | fs.Dirent[] | string[] | Error)[]> {
+		return Promise.all(args.map((a) => this.readdir(a.path, a.options).catch((e) => e)));
+	}
+
 	public readlink(path: fs.PathLike, options: IEncodingOptions): Promise<string | Buffer> {
 		return promisify(fs.readlink)(path, options);
 	}
@@ -202,6 +212,10 @@ export class FsModuleProxy {
 		return this.makeStatsSerializable(await promisify(fs.stat)(path));
 	}
 
+	public async statBatch(args: { path: fs.PathLike }[]): Promise<(Stats | Error)[]> {
+		return Promise.all(args.map((a) => this.stat(a.path).catch((e) => e)));
+	}
+
 	public symlink(target: fs.PathLike, path: fs.PathLike, type?: fs.symlink.Type | null): Promise<void> {
 		return promisify(fs.symlink)(target, path, type);
 	}

packages/protocol/src/node/modules/net.ts

@@ -2,6 +2,8 @@ import * as net from "net";
 import { ServerProxy } from "../../common/proxy";
 import { DuplexProxy } from "./stream";
 
+// tslint:disable completed-docs
+
 export class NetSocketProxy extends DuplexProxy<net.Socket> {
 	public async connect(options: number | string | net.SocketConnectOpts, host?: string): Promise<void> {
 		this.stream.connect(options as any, host as any); // tslint:disable-line no-any this works fine
@@ -28,7 +30,7 @@ export class NetSocketProxy extends DuplexProxy<net.Socket> {
 
 	// tslint:disable-next-line no-any
 	public async onEvent(cb: (event: string, ...args: any[]) => void): Promise<void> {
-		super.onEvent(cb);
+		await super.onEvent(cb);
 		this.stream.on("connect", () => cb("connect"));
 		this.stream.on("lookup", (error, address, family, host) => cb("lookup", error, address, family, host));
 		this.stream.on("timeout", () => cb("timeout"));

packages/protocol/src/node/modules/node-pty.ts

@@ -4,6 +4,8 @@ import * as pty from "node-pty";
 import { ServerProxy } from "../../common/proxy";
 import { preserveEnv } from "../../common/util";
 
+// tslint:disable completed-docs
+
 /**
  * Server-side IPty proxy.
  */
@@ -22,7 +24,7 @@ export class NodePtyProcessProxy implements ServerProxy {
 			}
 		}, 200);
 
-		this.onDone(() => clearInterval(timer));
+		this.process.on("exit", () => clearInterval(timer));
 	}
 
 	public async getPid(): Promise<number> {
@@ -50,8 +52,8 @@ export class NodePtyProcessProxy implements ServerProxy {
 	}
 
 	public async dispose(): Promise<void> {
-		this.kill();
+		this.process.kill();
-		setTimeout(() => this.kill("SIGKILL"), 5000); // Double tap.
+		setTimeout(() => this.process.kill("SIGKILL"), 5000); // Double tap.
 		this.emitter.removeAllListeners();
 	}
 

packages/protocol/src/node/modules/spdlog.ts

@@ -3,6 +3,8 @@ import { EventEmitter } from "events";
 import * as spdlog from "spdlog";
 import { ServerProxy } from "../../common/proxy";
 
+// tslint:disable completed-docs
+
 export class RotatingLoggerProxy implements ServerProxy {
 	private readonly emitter = new EventEmitter();
 
@@ -24,7 +26,7 @@ export class RotatingLoggerProxy implements ServerProxy {
 	}
 
 	public async dispose(): Promise<void> {
-		this.flush();
+		await this.flush();
 		this.emitter.emit("dispose");
 		this.emitter.removeAllListeners();
 	}

packages/protocol/src/node/modules/stream.ts

@@ -1,6 +1,8 @@
 import * as stream from "stream";
 import { ServerProxy } from "../../common/proxy";
 
+// tslint:disable completed-docs
+
 export class WritableProxy<T extends stream.Writable = stream.Writable> implements ServerProxy {
 	public constructor(protected readonly stream: T) {}
 
@@ -100,7 +102,7 @@ export class DuplexProxy<T extends stream.Duplex = stream.Duplex> extends Writab
 
 	// tslint:disable-next-line no-any
 	public async onEvent(cb: (event: string, ...args: any[]) => void): Promise<void> {
-		super.onEvent(cb);
+		await super.onEvent(cb);
 		this.stream.on("data", (chunk) => cb("data", chunk));
 		this.stream.on("end", () => cb("end"));
 	}

packages/protocol/src/node/modules/trash.ts

@@ -1,5 +1,7 @@
 import * as trash from "trash";
 
+// tslint:disable completed-docs
+
 export class TrashModuleProxy {
 	public async trash(path: string, options?: trash.Options): Promise<void> {
 		return trash(path, options);

packages/protocol/src/node/server.ts

@@ -3,8 +3,8 @@ import * as os from "os";
 import { field, logger} from "@coder/logger";
 import { ReadWriteConnection } from "../common/connection";
 import { Module, ServerProxy } from "../common/proxy";
-import { isPromise, isProxy, moduleToProto, parse, platformToProto, protoToModule, stringify } from "../common/util";
+import { isPromise, isProxy, moduleToProto, protoToArgument, platformToProto, protoToModule, argumentToProto } from "../common/util";
-import { CallbackMessage, ClientMessage, EventMessage, FailMessage, MethodMessage, NamedCallbackMessage, NamedEventMessage, NumberedCallbackMessage, NumberedEventMessage, Pong, ServerMessage, SuccessMessage, WorkingInitMessage } from "../proto";
+import { Argument, Callback, ClientMessage, Event, Method, Pong, ServerMessage, WorkingInit } from "../proto";
 import { ChildProcessModuleProxy, ForkProvider, FsModuleProxy, NetModuleProxy, NodePtyModuleProxy, SpdlogModuleProxy, TrashModuleProxy } from "./modules";
 
 // tslint:disable no-any
@@ -14,6 +14,7 @@ export interface ServerOptions {
 	readonly dataDirectory: string;
 	readonly cacheDirectory: string;
 	readonly builtInExtensionsDirectory: string;
+	readonly extensionsDirectory: string;
 	readonly fork?: ForkProvider;
 }
 
@@ -22,11 +23,14 @@ interface ProxyData {
 	instance: any;
 }
 
+/**
+ * Handle messages from the client.
+ */
 export class Server {
 	private proxyId = 0;
 	private readonly proxies = new Map<number | Module, ProxyData>();
 	private disconnected: boolean = false;
-	private responseTimeout = 10000;
+	private readonly responseTimeout = 10000;
 
 	public constructor(
 		private readonly connection: ReadWriteConnection,
@@ -57,7 +61,9 @@ export class Server {
 
 			this.proxies.forEach((proxy, proxyId) => {
 				if (isProxy(proxy.instance)) {
-					proxy.instance.dispose();
+					proxy.instance.dispose().catch((error) => {
+						logger.error(error.message);
+					});
 				}
 				this.removeProxy(proxyId);
 			});
@@ -84,14 +90,15 @@ export class Server {
 			logger.error(error.message, field("error", error));
 		});
 
-		const initMsg = new WorkingInitMessage();
+		const initMsg = new WorkingInit();
 		initMsg.setDataDirectory(this.options.dataDirectory);
 		initMsg.setWorkingDirectory(this.options.workingDirectory);
 		initMsg.setBuiltinExtensionsDir(this.options.builtInExtensionsDirectory);
+		initMsg.setExtensionsDirectory(this.options.extensionsDirectory);
 		initMsg.setHomeDirectory(os.homedir());
 		initMsg.setTmpDirectory(os.tmpdir());
 		initMsg.setOperatingSystem(platformToProto(os.platform()));
-		initMsg.setShell(os.userInfo().shell || global.process.env.SHELL);
+		initMsg.setShell(os.userInfo().shell || global.process.env.SHELL || "");
 		const srvMsg = new ServerMessage();
 		srvMsg.setInit(initMsg);
 		connection.send(srvMsg.serializeBinary());
@@ -101,29 +108,32 @@ export class Server {
 	 * Handle all messages from the client.
 	 */
 	private async handleMessage(message: ClientMessage): Promise<void> {
-		if (message.hasMethod()) {
+		switch (message.getMsgCase()) {
-			await this.runMethod(message.getMethod()!);
+			case ClientMessage.MsgCase.METHOD:
-		} else if (message.hasPing()) {
+				await this.runMethod(message.getMethod()!);
-			logger.trace("ping");
+				break;
-			const srvMsg = new ServerMessage();
+			case ClientMessage.MsgCase.PING:
-			srvMsg.setPong(new Pong());
+				logger.trace("ping");
-			this.connection.send(srvMsg.serializeBinary());
+				const srvMsg = new ServerMessage();
-		} else {
+				srvMsg.setPong(new Pong());
-			throw new Error("unknown message type");
+				this.connection.send(srvMsg.serializeBinary());
+				break;
+			default:
+				throw new Error("unknown message type");
 		}
 	}
 
 	/**
 	 * Run a method on a proxy.
 	 */
-	private async runMethod(message: MethodMessage): Promise<void> {
+	private async runMethod(message: Method): Promise<void> {
 		const proxyMessage = message.getNamedProxy()! || message.getNumberedProxy()!;
 		const id = proxyMessage.getId();
 		const proxyId = message.hasNamedProxy()
 			? protoToModule(message.getNamedProxy()!.getModule())
 			: message.getNumberedProxy()!.getProxyId();
 		const method = proxyMessage.getMethod();
-		const args = proxyMessage.getArgsList().map((a) => parse(
+		const args = proxyMessage.getArgsList().map((a) => protoToArgument(
 			a,
 			(id, args) => this.sendCallback(proxyId, id, args),
 		));
@@ -133,14 +143,13 @@ export class Server {
 			field("id", id),
 			field("proxyId", proxyId),
 			field("method", method),
-			field("args", proxyMessage.getArgsList()),
 		]);
 
 		let response: any;
 		try {
 			const proxy = this.getProxy(proxyId);
 			if (typeof proxy.instance[method] !== "function") {
-				throw new Error(`"${method}" is not a function`);
+				throw new Error(`"${method}" is not a function on proxy ${proxyId}`);
 			}
 
 			response = proxy.instance[method](...args);
@@ -153,7 +162,7 @@ export class Server {
 
 			// Proxies must always return promises.
 			if (!isPromise(response)) {
-				throw new Error('"${method}" must return a promise');
+				throw new Error(`"${method}" must return a promise`);
 			}
 		} catch (error) {
 			logger.error(
@@ -175,27 +184,25 @@ export class Server {
 	 * Send a callback to the client.
 	 */
 	private sendCallback(proxyId: number | Module, callbackId: number, args: any[]): void {
-		const stringifiedArgs = args.map((a) => this.stringify(a));
 		logger.trace(() => [
 			"sending callback",
 			field("proxyId", proxyId),
 			field("callbackId", callbackId),
-			field("args", stringifiedArgs),
 		]);
 
-		const message = new CallbackMessage();
+		const message = new Callback();
-		let callbackMessage: NamedCallbackMessage | NumberedCallbackMessage;
+		let callbackMessage: Callback.Named | Callback.Numbered;
 		if (typeof proxyId === "string") {
-			callbackMessage = new NamedCallbackMessage();
+			callbackMessage = new Callback.Named();
 			callbackMessage.setModule(moduleToProto(proxyId));
 			message.setNamedCallback(callbackMessage);
 		} else  {
-			callbackMessage = new NumberedCallbackMessage();
+			callbackMessage = new Callback.Numbered();
 			callbackMessage.setProxyId(proxyId);
 			message.setNumberedCallback(callbackMessage);
 		}
 		callbackMessage.setCallbackId(callbackId);
-		callbackMessage.setArgsList(stringifiedArgs);
+		callbackMessage.setArgsList(args.map((a) => this.argumentToProto(a)));
 
 		const serverMessage = new ServerMessage();
 		serverMessage.setCallback(message);
@@ -203,15 +210,23 @@ export class Server {
 	}
 
 	/**
-	 * Store a proxy and bind events to send them back to the client.
+	 * Store a numbered proxy and bind events to send them back to the client.
 	 */
 	private storeProxy(instance: ServerProxy): number;
+	/**
+	 * Store a unique proxy and bind events to send them back to the client.
+	 */
 	private storeProxy(instance: any, moduleProxyId: Module): Module;
+	/**
+	 * Store a proxy and bind events to send them back to the client.
+	 */
 	private storeProxy(instance: ServerProxy | any, moduleProxyId?: Module): number | Module {
 		// In case we disposed while waiting for a function to return.
 		if (this.disconnected) {
 			if (isProxy(instance)) {
-				instance.dispose();
+				instance.dispose().catch((error) => {
+					logger.error(error.message);
+				});
 			}
 
 			throw new Error("disposed");
@@ -226,16 +241,22 @@ export class Server {
 		this.proxies.set(proxyId, { instance });
 
 		if (isProxy(instance)) {
-			instance.onEvent((event, ...args) => this.sendEvent(proxyId, event, ...args));
+			instance.onEvent((event, ...args) => this.sendEvent(proxyId, event, ...args)).catch((error) => {
+				logger.error(error.message);
+			});
 			instance.onDone(() => {
 				// It might have finished because we disposed it due to a disconnect.
 				if (!this.disconnected) {
 					this.sendEvent(proxyId, "done");
 					this.getProxy(proxyId).disposeTimeout = setTimeout(() => {
-						instance.dispose();
+						instance.dispose().catch((error) => {
+							logger.error(error.message);
+						});
 						this.removeProxy(proxyId);
 					}, this.responseTimeout);
 				}
+			}).catch((error) => {
+				logger.error(error.message);
 			});
 		}
 
@@ -246,27 +267,25 @@ export class Server {
 	 * Send an event to the client.
 	 */
 	private sendEvent(proxyId: number | Module, event: string, ...args: any[]): void {
-		const stringifiedArgs = args.map((a) => this.stringify(a));
 		logger.trace(() => [
 			"sending event",
 			field("proxyId", proxyId),
 			field("event", event),
-			field("args", stringifiedArgs),
 		]);
 
-		const message = new EventMessage();
+		const message = new Event();
-		let eventMessage: NamedEventMessage | NumberedEventMessage;
+		let eventMessage: Event.Named | Event.Numbered;
 		if (typeof proxyId === "string") {
-			eventMessage = new NamedEventMessage();
+			eventMessage = new Event.Named();
 			eventMessage.setModule(moduleToProto(proxyId));
 			message.setNamedEvent(eventMessage);
 		} else  {
-			eventMessage = new NumberedEventMessage();
+			eventMessage = new Event.Numbered();
 			eventMessage.setProxyId(proxyId);
 			message.setNumberedEvent(eventMessage);
 		}
 		eventMessage.setEvent(event);
-		eventMessage.setArgsList(stringifiedArgs);
+		eventMessage.setArgsList(args.map((a) => this.argumentToProto(a)));
 
 		const serverMessage = new ServerMessage();
 		serverMessage.setEvent(message);
@@ -277,16 +296,14 @@ export class Server {
 	 * Send a response back to the client.
 	 */
 	private sendResponse(id: number, response: any): void {
-		const stringifiedResponse = this.stringify(response);
 		logger.trace(() => [
 			"sending resolve",
 			field("id", id),
-			field("response", stringifiedResponse),
 		]);
 
-		const successMessage = new SuccessMessage();
+		const successMessage = new Method.Success();
 		successMessage.setId(id);
-		successMessage.setResponse(stringifiedResponse);
+		successMessage.setResponse(this.argumentToProto(response));
 
 		const serverMessage = new ServerMessage();
 		serverMessage.setSuccess(successMessage);
@@ -297,16 +314,15 @@ export class Server {
 	 * Send an exception back to the client.
 	 */
 	private sendException(id: number, error: Error): void {
-		const stringifiedError = stringify(error);
 		logger.trace(() => [
 			"sending reject",
 			field("id", id) ,
-			field("response", stringifiedError),
+			field("message", error.message),
 		]);
 
-		const failedMessage = new FailMessage();
+		const failedMessage = new Method.Fail();
 		failedMessage.setId(id);
-		failedMessage.setResponse(stringifiedError);
+		failedMessage.setResponse(argumentToProto(error));
 
 		const serverMessage = new ServerMessage();
 		serverMessage.setFail(failedMessage);
@@ -327,10 +343,16 @@ export class Server {
 		]);
 	}
 
-	private stringify(value: any): string {
+	/**
-		return stringify(value, undefined, (p) => this.storeProxy(p));
+	 * Same as argumentToProto but provides storeProxy.
+	 */
+	private argumentToProto(value: any): Argument {
+		return argumentToProto(value, undefined, (p) => this.storeProxy(p));
 	}
 
+	/**
+	 * Get a proxy. Error if it doesn't exist.
+	 */
 	private getProxy(proxyId: number | Module): ProxyData {
 		if (!this.proxies.has(proxyId)) {
 			throw new Error(`proxy ${proxyId} disposed too early`);

packages/protocol/src/proto/client.proto

@@ -6,7 +6,7 @@ import "vscode.proto";
 message ClientMessage {
 	oneof msg {
 		// node.proto
-		MethodMessage method = 20;
+		Method method = 20;
 		Ping ping = 21;
 	}
 }
@@ -15,20 +15,20 @@ message ClientMessage {
 message ServerMessage {
 	oneof msg {
 		// node.proto
-		FailMessage fail = 13;
+		Method.Fail fail = 13;
-		SuccessMessage success = 14;
+		Method.Success success = 14;
-		EventMessage event = 19;
+		Event event = 19;
-		CallbackMessage callback = 22;
+		Callback callback = 22;
 		Pong pong = 18;
 
-		WorkingInitMessage init = 16;
+		WorkingInit init = 16;
 
 		// vscode.proto
-		SharedProcessActiveMessage shared_process_active = 17;
+		SharedProcessActive shared_process_active = 17;
 	}
 }
 
-message WorkingInitMessage {
+message WorkingInit {
 	string home_directory = 1;
 	string tmp_directory = 2;
 	string data_directory = 3;
@@ -41,4 +41,5 @@ message WorkingInitMessage {
 	OperatingSystem operating_system = 5;
 	string shell = 6;
 	string builtin_extensions_dir = 7;
+	string extensions_directory = 8;
 }

packages/protocol/src/proto/client_pb.d.ts

@@ -8,8 +8,8 @@ import * as vscode_pb from "./vscode_pb";
 export class ClientMessage extends jspb.Message {
   hasMethod(): boolean;
   clearMethod(): void;
-  getMethod(): node_pb.MethodMessage | undefined;
+  getMethod(): node_pb.Method | undefined;
-  setMethod(value?: node_pb.MethodMessage): void;
+  setMethod(value?: node_pb.Method): void;
 
   hasPing(): boolean;
   clearPing(): void;
@@ -29,7 +29,7 @@ export class ClientMessage extends jspb.Message {
 
 export namespace ClientMessage {
   export type AsObject = {
-    method?: node_pb.MethodMessage.AsObject,
+    method?: node_pb.Method.AsObject,
     ping?: node_pb.Ping.AsObject,
   }
 
@@ -43,23 +43,23 @@ export namespace ClientMessage {
 export class ServerMessage extends jspb.Message {
   hasFail(): boolean;
   clearFail(): void;
-  getFail(): node_pb.FailMessage | undefined;
+  getFail(): node_pb.Method.Fail | undefined;
-  setFail(value?: node_pb.FailMessage): void;
+  setFail(value?: node_pb.Method.Fail): void;
 
   hasSuccess(): boolean;
   clearSuccess(): void;
-  getSuccess(): node_pb.SuccessMessage | undefined;
+  getSuccess(): node_pb.Method.Success | undefined;
-  setSuccess(value?: node_pb.SuccessMessage): void;
+  setSuccess(value?: node_pb.Method.Success): void;
 
   hasEvent(): boolean;
   clearEvent(): void;
-  getEvent(): node_pb.EventMessage | undefined;
+  getEvent(): node_pb.Event | undefined;
-  setEvent(value?: node_pb.EventMessage): void;
+  setEvent(value?: node_pb.Event): void;
 
   hasCallback(): boolean;
   clearCallback(): void;
-  getCallback(): node_pb.CallbackMessage | undefined;
+  getCallback(): node_pb.Callback | undefined;
-  setCallback(value?: node_pb.CallbackMessage): void;
+  setCallback(value?: node_pb.Callback): void;
 
   hasPong(): boolean;
   clearPong(): void;
@@ -68,13 +68,13 @@ export class ServerMessage extends jspb.Message {
 
   hasInit(): boolean;
   clearInit(): void;
-  getInit(): WorkingInitMessage | undefined;
+  getInit(): WorkingInit | undefined;
-  setInit(value?: WorkingInitMessage): void;
+  setInit(value?: WorkingInit): void;
 
   hasSharedProcessActive(): boolean;
   clearSharedProcessActive(): void;
-  getSharedProcessActive(): vscode_pb.SharedProcessActiveMessage | undefined;
+  getSharedProcessActive(): vscode_pb.SharedProcessActive | undefined;
-  setSharedProcessActive(value?: vscode_pb.SharedProcessActiveMessage): void;
+  setSharedProcessActive(value?: vscode_pb.SharedProcessActive): void;
 
   getMsgCase(): ServerMessage.MsgCase;
   serializeBinary(): Uint8Array;
@@ -89,13 +89,13 @@ export class ServerMessage extends jspb.Message {
 
 export namespace ServerMessage {
   export type AsObject = {
-    fail?: node_pb.FailMessage.AsObject,
+    fail?: node_pb.Method.Fail.AsObject,
-    success?: node_pb.SuccessMessage.AsObject,
+    success?: node_pb.Method.Success.AsObject,
-    event?: node_pb.EventMessage.AsObject,
+    event?: node_pb.Event.AsObject,
-    callback?: node_pb.CallbackMessage.AsObject,
+    callback?: node_pb.Callback.AsObject,
     pong?: node_pb.Pong.AsObject,
-    init?: WorkingInitMessage.AsObject,
+    init?: WorkingInit.AsObject,
-    sharedProcessActive?: vscode_pb.SharedProcessActiveMessage.AsObject,
+    sharedProcessActive?: vscode_pb.SharedProcessActive.AsObject,
   }
 
   export enum MsgCase {
@@ -110,7 +110,7 @@ export namespace ServerMessage {
   }
 }
 
-export class WorkingInitMessage extends jspb.Message {
+export class WorkingInit extends jspb.Message {
   getHomeDirectory(): string;
   setHomeDirectory(value: string): void;
 
@@ -123,8 +123,8 @@ export class WorkingInitMessage extends jspb.Message {
   getWorkingDirectory(): string;
   setWorkingDirectory(value: string): void;
 
-  getOperatingSystem(): WorkingInitMessage.OperatingSystem;
+  getOperatingSystem(): WorkingInit.OperatingSystem;
-  setOperatingSystem(value: WorkingInitMessage.OperatingSystem): void;
+  setOperatingSystem(value: WorkingInit.OperatingSystem): void;
 
   getShell(): string;
   setShell(value: string): void;
@@ -132,25 +132,29 @@ export class WorkingInitMessage extends jspb.Message {
   getBuiltinExtensionsDir(): string;
   setBuiltinExtensionsDir(value: string): void;
 
+  getExtensionsDirectory(): string;
+  setExtensionsDirectory(value: string): void;
+
   serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): WorkingInitMessage.AsObject;
+  toObject(includeInstance?: boolean): WorkingInit.AsObject;
-  static toObject(includeInstance: boolean, msg: WorkingInitMessage): WorkingInitMessage.AsObject;
+  static toObject(includeInstance: boolean, msg: WorkingInit): WorkingInit.AsObject;
   static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
   static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: WorkingInitMessage, writer: jspb.BinaryWriter): void;
+  static serializeBinaryToWriter(message: WorkingInit, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): WorkingInitMessage;
+  static deserializeBinary(bytes: Uint8Array): WorkingInit;
-  static deserializeBinaryFromReader(message: WorkingInitMessage, reader: jspb.BinaryReader): WorkingInitMessage;
+  static deserializeBinaryFromReader(message: WorkingInit, reader: jspb.BinaryReader): WorkingInit;
 }
 
-export namespace WorkingInitMessage {
+export namespace WorkingInit {
   export type AsObject = {
     homeDirectory: string,
     tmpDirectory: string,
     dataDirectory: string,
     workingDirectory: string,
-    operatingSystem: WorkingInitMessage.OperatingSystem,
+    operatingSystem: WorkingInit.OperatingSystem,
     shell: string,
     builtinExtensionsDir: string,
+    extensionsDirectory: string,
   }
 
   export enum OperatingSystem {

packages/protocol/src/proto/client_pb.js

@@ -12,12 +12,13 @@ var goog = jspb;
 var global = Function('return this')();
 
 var node_pb = require('./node_pb.js');
+goog.object.extend(proto, node_pb);
 var vscode_pb = require('./vscode_pb.js');
+goog.object.extend(proto, vscode_pb);
 goog.exportSymbol('proto.ClientMessage', null, global);
 goog.exportSymbol('proto.ServerMessage', null, global);
-goog.exportSymbol('proto.WorkingInitMessage', null, global);
+goog.exportSymbol('proto.WorkingInit', null, global);
-goog.exportSymbol('proto.WorkingInitMessage.OperatingSystem', null, global);
+goog.exportSymbol('proto.WorkingInit.OperatingSystem', null, global);
-
 /**
  * Generated by JsPbCodeGenerator.
  * @param {Array=} opt_data Optional initial data array, typically from a
@@ -33,8 +34,55 @@ proto.ClientMessage = function(opt_data) {
 };
 goog.inherits(proto.ClientMessage, jspb.Message);
 if (goog.DEBUG && !COMPILED) {
+  /**
+   * @public
+   * @override
+   */
   proto.ClientMessage.displayName = 'proto.ClientMessage';
 }
+/**
+ * Generated by JsPbCodeGenerator.
+ * @param {Array=} opt_data Optional initial data array, typically from a
+ * server response, or constructed directly in Javascript. The array is used
+ * in place and becomes part of the constructed object. It is not cloned.
+ * If no data is provided, the constructed object will be empty, but still
+ * valid.
+ * @extends {jspb.Message}
+ * @constructor
+ */
+proto.ServerMessage = function(opt_data) {
+  jspb.Message.initialize(this, opt_data, 0, -1, null, proto.ServerMessage.oneofGroups_);
+};
+goog.inherits(proto.ServerMessage, jspb.Message);
+if (goog.DEBUG && !COMPILED) {
+  /**
+   * @public
+   * @override
+   */
+  proto.ServerMessage.displayName = 'proto.ServerMessage';
+}
+/**
+ * Generated by JsPbCodeGenerator.
+ * @param {Array=} opt_data Optional initial data array, typically from a
+ * server response, or constructed directly in Javascript. The array is used
+ * in place and becomes part of the constructed object. It is not cloned.
+ * If no data is provided, the constructed object will be empty, but still
+ * valid.
+ * @extends {jspb.Message}
+ * @constructor
+ */
+proto.WorkingInit = function(opt_data) {
+  jspb.Message.initialize(this, opt_data, 0, -1, null, null);
+};
+goog.inherits(proto.WorkingInit, jspb.Message);
+if (goog.DEBUG && !COMPILED) {
+  /**
+   * @public
+   * @override
+   */
+  proto.WorkingInit.displayName = 'proto.WorkingInit';
+}
+
 /**
  * Oneof group definitions for this message. Each group defines the field
  * numbers belonging to that group. When of these fields' value is set, all
@@ -89,8 +137,8 @@ proto.ClientMessage.prototype.toObject = function(opt_includeInstance) {
  * @suppress {unusedLocalVariables} f is only used for nested messages
  */
 proto.ClientMessage.toObject = function(includeInstance, msg) {
-  var f, obj = {
+  var obj = {
-    method: (f = msg.getMethod()) && node_pb.MethodMessage.toObject(includeInstance, f),
+    method: (f = msg.getMethod()) && node_pb.Method.toObject(includeInstance, f),
     ping: (f = msg.getPing()) && node_pb.Ping.toObject(includeInstance, f)
   };
 
@@ -129,8 +177,8 @@ proto.ClientMessage.deserializeBinaryFromReader = function(msg, reader) {
     var field = reader.getFieldNumber();
     switch (field) {
     case 20:
-      var value = new node_pb.MethodMessage;
+      var value = new node_pb.Method;
-      reader.readMessage(value,node_pb.MethodMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,node_pb.Method.deserializeBinaryFromReader);
       msg.setMethod(value);
       break;
     case 21:
@@ -172,7 +220,7 @@ proto.ClientMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       20,
       f,
-      node_pb.MethodMessage.serializeBinaryToWriter
+      node_pb.Method.serializeBinaryToWriter
     );
   }
   f = message.getPing();
@@ -187,21 +235,24 @@ proto.ClientMessage.serializeBinaryToWriter = function(message, writer) {
 
 
 /**
- * optional MethodMessage method = 20;
+ * optional Method method = 20;
- * @return {?proto.MethodMessage}
+ * @return {?proto.Method}
  */
 proto.ClientMessage.prototype.getMethod = function() {
-  return /** @type{?proto.MethodMessage} */ (
+  return /** @type{?proto.Method} */ (
-    jspb.Message.getWrapperField(this, node_pb.MethodMessage, 20));
+    jspb.Message.getWrapperField(this, node_pb.Method, 20));
 };
 
 
-/** @param {?proto.MethodMessage|undefined} value */
+/** @param {?proto.Method|undefined} value */
 proto.ClientMessage.prototype.setMethod = function(value) {
   jspb.Message.setOneofWrapperField(this, 20, proto.ClientMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ClientMessage.prototype.clearMethod = function() {
   this.setMethod(undefined);
 };
@@ -209,7 +260,7 @@ proto.ClientMessage.prototype.clearMethod = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ClientMessage.prototype.hasMethod = function() {
   return jspb.Message.getField(this, 20) != null;
@@ -232,6 +283,9 @@ proto.ClientMessage.prototype.setPing = function(value) {
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ClientMessage.prototype.clearPing = function() {
   this.setPing(undefined);
 };
@@ -239,7 +293,7 @@ proto.ClientMessage.prototype.clearPing = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ClientMessage.prototype.hasPing = function() {
   return jspb.Message.getField(this, 21) != null;
@@ -247,23 +301,6 @@ proto.ClientMessage.prototype.hasPing = function() {
 
 
 
-/**
- * Generated by JsPbCodeGenerator.
- * @param {Array=} opt_data Optional initial data array, typically from a
- * server response, or constructed directly in Javascript. The array is used
- * in place and becomes part of the constructed object. It is not cloned.
- * If no data is provided, the constructed object will be empty, but still
- * valid.
- * @extends {jspb.Message}
- * @constructor
- */
-proto.ServerMessage = function(opt_data) {
-  jspb.Message.initialize(this, opt_data, 0, -1, null, proto.ServerMessage.oneofGroups_);
-};
-goog.inherits(proto.ServerMessage, jspb.Message);
-if (goog.DEBUG && !COMPILED) {
-  proto.ServerMessage.displayName = 'proto.ServerMessage';
-}
 /**
  * Oneof group definitions for this message. Each group defines the field
  * numbers belonging to that group. When of these fields' value is set, all
@@ -323,14 +360,14 @@ proto.ServerMessage.prototype.toObject = function(opt_includeInstance) {
  * @suppress {unusedLocalVariables} f is only used for nested messages
  */
 proto.ServerMessage.toObject = function(includeInstance, msg) {
-  var f, obj = {
+  var obj = {
-    fail: (f = msg.getFail()) && node_pb.FailMessage.toObject(includeInstance, f),
+    fail: (f = msg.getFail()) && node_pb.Method.Fail.toObject(includeInstance, f),
-    success: (f = msg.getSuccess()) && node_pb.SuccessMessage.toObject(includeInstance, f),
+    success: (f = msg.getSuccess()) && node_pb.Method.Success.toObject(includeInstance, f),
-    event: (f = msg.getEvent()) && node_pb.EventMessage.toObject(includeInstance, f),
+    event: (f = msg.getEvent()) && node_pb.Event.toObject(includeInstance, f),
-    callback: (f = msg.getCallback()) && node_pb.CallbackMessage.toObject(includeInstance, f),
+    callback: (f = msg.getCallback()) && node_pb.Callback.toObject(includeInstance, f),
     pong: (f = msg.getPong()) && node_pb.Pong.toObject(includeInstance, f),
-    init: (f = msg.getInit()) && proto.WorkingInitMessage.toObject(includeInstance, f),
+    init: (f = msg.getInit()) && proto.WorkingInit.toObject(includeInstance, f),
-    sharedProcessActive: (f = msg.getSharedProcessActive()) && vscode_pb.SharedProcessActiveMessage.toObject(includeInstance, f)
+    sharedProcessActive: (f = msg.getSharedProcessActive()) && vscode_pb.SharedProcessActive.toObject(includeInstance, f)
   };
 
   if (includeInstance) {
@@ -368,23 +405,23 @@ proto.ServerMessage.deserializeBinaryFromReader = function(msg, reader) {
     var field = reader.getFieldNumber();
     switch (field) {
     case 13:
-      var value = new node_pb.FailMessage;
+      var value = new node_pb.Method.Fail;
-      reader.readMessage(value,node_pb.FailMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,node_pb.Method.Fail.deserializeBinaryFromReader);
       msg.setFail(value);
       break;
     case 14:
-      var value = new node_pb.SuccessMessage;
+      var value = new node_pb.Method.Success;
-      reader.readMessage(value,node_pb.SuccessMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,node_pb.Method.Success.deserializeBinaryFromReader);
       msg.setSuccess(value);
       break;
     case 19:
-      var value = new node_pb.EventMessage;
+      var value = new node_pb.Event;
-      reader.readMessage(value,node_pb.EventMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,node_pb.Event.deserializeBinaryFromReader);
       msg.setEvent(value);
       break;
     case 22:
-      var value = new node_pb.CallbackMessage;
+      var value = new node_pb.Callback;
-      reader.readMessage(value,node_pb.CallbackMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,node_pb.Callback.deserializeBinaryFromReader);
       msg.setCallback(value);
       break;
     case 18:
@@ -393,13 +430,13 @@ proto.ServerMessage.deserializeBinaryFromReader = function(msg, reader) {
       msg.setPong(value);
       break;
     case 16:
-      var value = new proto.WorkingInitMessage;
+      var value = new proto.WorkingInit;
-      reader.readMessage(value,proto.WorkingInitMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,proto.WorkingInit.deserializeBinaryFromReader);
       msg.setInit(value);
       break;
     case 17:
-      var value = new vscode_pb.SharedProcessActiveMessage;
+      var value = new vscode_pb.SharedProcessActive;
-      reader.readMessage(value,vscode_pb.SharedProcessActiveMessage.deserializeBinaryFromReader);
+      reader.readMessage(value,vscode_pb.SharedProcessActive.deserializeBinaryFromReader);
       msg.setSharedProcessActive(value);
       break;
     default:
@@ -436,7 +473,7 @@ proto.ServerMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       13,
       f,
-      node_pb.FailMessage.serializeBinaryToWriter
+      node_pb.Method.Fail.serializeBinaryToWriter
     );
   }
   f = message.getSuccess();
@@ -444,7 +481,7 @@ proto.ServerMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       14,
       f,
-      node_pb.SuccessMessage.serializeBinaryToWriter
+      node_pb.Method.Success.serializeBinaryToWriter
     );
   }
   f = message.getEvent();
@@ -452,7 +489,7 @@ proto.ServerMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       19,
       f,
-      node_pb.EventMessage.serializeBinaryToWriter
+      node_pb.Event.serializeBinaryToWriter
     );
   }
   f = message.getCallback();
@@ -460,7 +497,7 @@ proto.ServerMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       22,
       f,
-      node_pb.CallbackMessage.serializeBinaryToWriter
+      node_pb.Callback.serializeBinaryToWriter
     );
   }
   f = message.getPong();
@@ -476,7 +513,7 @@ proto.ServerMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       16,
       f,
-      proto.WorkingInitMessage.serializeBinaryToWriter
+      proto.WorkingInit.serializeBinaryToWriter
     );
   }
   f = message.getSharedProcessActive();
@@ -484,28 +521,31 @@ proto.ServerMessage.serializeBinaryToWriter = function(message, writer) {
     writer.writeMessage(
       17,
       f,
-      vscode_pb.SharedProcessActiveMessage.serializeBinaryToWriter
+      vscode_pb.SharedProcessActive.serializeBinaryToWriter
     );
   }
 };
 
 
 /**
- * optional FailMessage fail = 13;
+ * optional Method.Fail fail = 13;
- * @return {?proto.FailMessage}
+ * @return {?proto.Method.Fail}
  */
 proto.ServerMessage.prototype.getFail = function() {
-  return /** @type{?proto.FailMessage} */ (
+  return /** @type{?proto.Method.Fail} */ (
-    jspb.Message.getWrapperField(this, node_pb.FailMessage, 13));
+    jspb.Message.getWrapperField(this, node_pb.Method.Fail, 13));
 };
 
 
-/** @param {?proto.FailMessage|undefined} value */
+/** @param {?proto.Method.Fail|undefined} value */
 proto.ServerMessage.prototype.setFail = function(value) {
   jspb.Message.setOneofWrapperField(this, 13, proto.ServerMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearFail = function() {
   this.setFail(undefined);
 };
@@ -513,7 +553,7 @@ proto.ServerMessage.prototype.clearFail = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasFail = function() {
   return jspb.Message.getField(this, 13) != null;
@@ -521,21 +561,24 @@ proto.ServerMessage.prototype.hasFail = function() {
 
 
 /**
- * optional SuccessMessage success = 14;
+ * optional Method.Success success = 14;
- * @return {?proto.SuccessMessage}
+ * @return {?proto.Method.Success}
  */
 proto.ServerMessage.prototype.getSuccess = function() {
-  return /** @type{?proto.SuccessMessage} */ (
+  return /** @type{?proto.Method.Success} */ (
-    jspb.Message.getWrapperField(this, node_pb.SuccessMessage, 14));
+    jspb.Message.getWrapperField(this, node_pb.Method.Success, 14));
 };
 
 
-/** @param {?proto.SuccessMessage|undefined} value */
+/** @param {?proto.Method.Success|undefined} value */
 proto.ServerMessage.prototype.setSuccess = function(value) {
   jspb.Message.setOneofWrapperField(this, 14, proto.ServerMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearSuccess = function() {
   this.setSuccess(undefined);
 };
@@ -543,7 +586,7 @@ proto.ServerMessage.prototype.clearSuccess = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasSuccess = function() {
   return jspb.Message.getField(this, 14) != null;
@@ -551,21 +594,24 @@ proto.ServerMessage.prototype.hasSuccess = function() {
 
 
 /**
- * optional EventMessage event = 19;
+ * optional Event event = 19;
- * @return {?proto.EventMessage}
+ * @return {?proto.Event}
  */
 proto.ServerMessage.prototype.getEvent = function() {
-  return /** @type{?proto.EventMessage} */ (
+  return /** @type{?proto.Event} */ (
-    jspb.Message.getWrapperField(this, node_pb.EventMessage, 19));
+    jspb.Message.getWrapperField(this, node_pb.Event, 19));
 };
 
 
-/** @param {?proto.EventMessage|undefined} value */
+/** @param {?proto.Event|undefined} value */
 proto.ServerMessage.prototype.setEvent = function(value) {
   jspb.Message.setOneofWrapperField(this, 19, proto.ServerMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearEvent = function() {
   this.setEvent(undefined);
 };
@@ -573,7 +619,7 @@ proto.ServerMessage.prototype.clearEvent = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasEvent = function() {
   return jspb.Message.getField(this, 19) != null;
@@ -581,21 +627,24 @@ proto.ServerMessage.prototype.hasEvent = function() {
 
 
 /**
- * optional CallbackMessage callback = 22;
+ * optional Callback callback = 22;
- * @return {?proto.CallbackMessage}
+ * @return {?proto.Callback}
  */
 proto.ServerMessage.prototype.getCallback = function() {
-  return /** @type{?proto.CallbackMessage} */ (
+  return /** @type{?proto.Callback} */ (
-    jspb.Message.getWrapperField(this, node_pb.CallbackMessage, 22));
+    jspb.Message.getWrapperField(this, node_pb.Callback, 22));
 };
 
 
-/** @param {?proto.CallbackMessage|undefined} value */
+/** @param {?proto.Callback|undefined} value */
 proto.ServerMessage.prototype.setCallback = function(value) {
   jspb.Message.setOneofWrapperField(this, 22, proto.ServerMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearCallback = function() {
   this.setCallback(undefined);
 };
@@ -603,7 +652,7 @@ proto.ServerMessage.prototype.clearCallback = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasCallback = function() {
   return jspb.Message.getField(this, 22) != null;
@@ -626,6 +675,9 @@ proto.ServerMessage.prototype.setPong = function(value) {
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearPong = function() {
   this.setPong(undefined);
 };
@@ -633,7 +685,7 @@ proto.ServerMessage.prototype.clearPong = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasPong = function() {
   return jspb.Message.getField(this, 18) != null;
@@ -641,21 +693,24 @@ proto.ServerMessage.prototype.hasPong = function() {
 
 
 /**
- * optional WorkingInitMessage init = 16;
+ * optional WorkingInit init = 16;
- * @return {?proto.WorkingInitMessage}
+ * @return {?proto.WorkingInit}
  */
 proto.ServerMessage.prototype.getInit = function() {
-  return /** @type{?proto.WorkingInitMessage} */ (
+  return /** @type{?proto.WorkingInit} */ (
-    jspb.Message.getWrapperField(this, proto.WorkingInitMessage, 16));
+    jspb.Message.getWrapperField(this, proto.WorkingInit, 16));
 };
 
 
-/** @param {?proto.WorkingInitMessage|undefined} value */
+/** @param {?proto.WorkingInit|undefined} value */
 proto.ServerMessage.prototype.setInit = function(value) {
   jspb.Message.setOneofWrapperField(this, 16, proto.ServerMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearInit = function() {
   this.setInit(undefined);
 };
@@ -663,7 +718,7 @@ proto.ServerMessage.prototype.clearInit = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasInit = function() {
   return jspb.Message.getField(this, 16) != null;
@@ -671,21 +726,24 @@ proto.ServerMessage.prototype.hasInit = function() {
 
 
 /**
- * optional SharedProcessActiveMessage shared_process_active = 17;
+ * optional SharedProcessActive shared_process_active = 17;
- * @return {?proto.SharedProcessActiveMessage}
+ * @return {?proto.SharedProcessActive}
  */
 proto.ServerMessage.prototype.getSharedProcessActive = function() {
-  return /** @type{?proto.SharedProcessActiveMessage} */ (
+  return /** @type{?proto.SharedProcessActive} */ (
-    jspb.Message.getWrapperField(this, vscode_pb.SharedProcessActiveMessage, 17));
+    jspb.Message.getWrapperField(this, vscode_pb.SharedProcessActive, 17));
 };
 
 
-/** @param {?proto.SharedProcessActiveMessage|undefined} value */
+/** @param {?proto.SharedProcessActive|undefined} value */
 proto.ServerMessage.prototype.setSharedProcessActive = function(value) {
   jspb.Message.setOneofWrapperField(this, 17, proto.ServerMessage.oneofGroups_[0], value);
 };
 
 
+/**
+ * Clears the message field making it undefined.
+ */
 proto.ServerMessage.prototype.clearSharedProcessActive = function() {
   this.setSharedProcessActive(undefined);
 };
@@ -693,7 +751,7 @@ proto.ServerMessage.prototype.clearSharedProcessActive = function() {
 
 /**
  * Returns whether this field is set.
- * @return {!boolean}
+ * @return {boolean}
  */
 proto.ServerMessage.prototype.hasSharedProcessActive = function() {
   return jspb.Message.getField(this, 17) != null;
@@ -701,23 +759,6 @@ proto.ServerMessage.prototype.hasSharedProcessActive = function() {
 
 
 
-/**
- * Generated by JsPbCodeGenerator.
- * @param {Array=} opt_data Optional initial data array, typically from a
- * server response, or constructed directly in Javascript. The array is used
- * in place and becomes part of the constructed object. It is not cloned.
- * If no data is provided, the constructed object will be empty, but still
- * valid.
- * @extends {jspb.Message}
- * @constructor
- */
-proto.WorkingInitMessage = function(opt_data) {
-  jspb.Message.initialize(this, opt_data, 0, -1, null, null);
-};
-goog.inherits(proto.WorkingInitMessage, jspb.Message);
-if (goog.DEBUG && !COMPILED) {
-  proto.WorkingInitMessage.displayName = 'proto.WorkingInitMessage';
-}
 
 
 if (jspb.Message.GENERATE_TO_OBJECT) {
@@ -731,8 +772,8 @@ if (jspb.Message.GENERATE_TO_OBJECT) {
  *     for transitional soy proto support: http://goto/soy-param-migration
  * @return {!Object}
  */
-proto.WorkingInitMessage.prototype.toObject = function(opt_includeInstance) {
+proto.WorkingInit.prototype.toObject = function(opt_includeInstance) {
-  return proto.WorkingInitMessage.toObject(opt_includeInstance, this);
+  return proto.WorkingInit.toObject(opt_includeInstance, this);
 };
 
 
@@ -741,19 +782,20 @@ proto.WorkingInitMessage.prototype.toObject = function(opt_includeInstance) {
  * @param {boolean|undefined} includeInstance Whether to include the JSPB
  *     instance for transitional soy proto support:
  *     http://goto/soy-param-migration
- * @param {!proto.WorkingInitMessage} msg The msg instance to transform.
+ * @param {!proto.WorkingInit} msg The msg instance to transform.
  * @return {!Object}
  * @suppress {unusedLocalVariables} f is only used for nested messages
  */
-proto.WorkingInitMessage.toObject = function(includeInstance, msg) {
+proto.WorkingInit.toObject = function(includeInstance, msg) {
-  var f, obj = {
+  var obj = {
     homeDirectory: jspb.Message.getFieldWithDefault(msg, 1, ""),
     tmpDirectory: jspb.Message.getFieldWithDefault(msg, 2, ""),
     dataDirectory: jspb.Message.getFieldWithDefault(msg, 3, ""),
     workingDirectory: jspb.Message.getFieldWithDefault(msg, 4, ""),
     operatingSystem: jspb.Message.getFieldWithDefault(msg, 5, 0),
     shell: jspb.Message.getFieldWithDefault(msg, 6, ""),
-    builtinExtensionsDir: jspb.Message.getFieldWithDefault(msg, 7, "")
+    builtinExtensionsDir: jspb.Message.getFieldWithDefault(msg, 7, ""),
+    extensionsDirectory: jspb.Message.getFieldWithDefault(msg, 8, "")
   };
 
   if (includeInstance) {
@@ -767,23 +809,23 @@ proto.WorkingInitMessage.toObject = function(includeInstance, msg) {
 /**
  * Deserializes binary data (in protobuf wire format).
  * @param {jspb.ByteSource} bytes The bytes to deserialize.
- * @return {!proto.WorkingInitMessage}
+ * @return {!proto.WorkingInit}
  */
-proto.WorkingInitMessage.deserializeBinary = function(bytes) {
+proto.WorkingInit.deserializeBinary = function(bytes) {
   var reader = new jspb.BinaryReader(bytes);
-  var msg = new proto.WorkingInitMessage;
+  var msg = new proto.WorkingInit;
-  return proto.WorkingInitMessage.deserializeBinaryFromReader(msg, reader);
+  return proto.WorkingInit.deserializeBinaryFromReader(msg, reader);
 };
 
 
 /**
  * Deserializes binary data (in protobuf wire format) from the
  * given reader into the given message object.
- * @param {!proto.WorkingInitMessage} msg The message object to deserialize into.
+ * @param {!proto.WorkingInit} msg The message object to deserialize into.
  * @param {!jspb.BinaryReader} reader The BinaryReader to use.
- * @return {!proto.WorkingInitMessage}
+ * @return {!proto.WorkingInit}
  */
-proto.WorkingInitMessage.deserializeBinaryFromReader = function(msg, reader) {
+proto.WorkingInit.deserializeBinaryFromReader = function(msg, reader) {
   while (reader.nextField()) {
     if (reader.isEndGroup()) {
       break;
@@ -807,7 +849,7 @@ proto.WorkingInitMessage.deserializeBinaryFromReader = function(msg, reader) {
       msg.setWorkingDirectory(value);
       break;
     case 5:
-      var value = /** @type {!proto.WorkingInitMessage.OperatingSystem} */ (reader.readEnum());
+      var value = /** @type {!proto.WorkingInit.OperatingSystem} */ (reader.readEnum());
       msg.setOperatingSystem(value);
       break;
     case 6:
@@ -818,6 +860,10 @@ proto.WorkingInitMessage.deserializeBinaryFromReader = function(msg, reader) {
       var value = /** @type {string} */ (reader.readString());
       msg.setBuiltinExtensionsDir(value);
       break;
+    case 8:
+      var value = /** @type {string} */ (reader.readString());
+      msg.setExtensionsDirectory(value);
+      break;
     default:
       reader.skipField();
       break;
@@ -831,9 +877,9 @@ proto.WorkingInitMessage.deserializeBinaryFromReader = function(msg, reader) {
  * Serializes the message to binary data (in protobuf wire format).
  * @return {!Uint8Array}
  */
-proto.WorkingInitMessage.prototype.serializeBinary = function() {
+proto.WorkingInit.prototype.serializeBinary = function() {
   var writer = new jspb.BinaryWriter();
-  proto.WorkingInitMessage.serializeBinaryToWriter(this, writer);
+  proto.WorkingInit.serializeBinaryToWriter(this, writer);
   return writer.getResultBuffer();
 };
 
@@ -841,11 +887,11 @@ proto.WorkingInitMessage.prototype.serializeBinary = function() {
 /**
  * Serializes the given message to binary data (in protobuf wire
  * format), writing to the given BinaryWriter.
- * @param {!proto.WorkingInitMessage} message
+ * @param {!proto.WorkingInit} message
  * @param {!jspb.BinaryWriter} writer
  * @suppress {unusedLocalVariables} f is only used for nested messages
  */
-proto.WorkingInitMessage.serializeBinaryToWriter = function(message, writer) {
+proto.WorkingInit.serializeBinaryToWriter = function(message, writer) {
   var f = undefined;
   f = message.getHomeDirectory();
   if (f.length > 0) {
@@ -896,13 +942,20 @@ proto.WorkingInitMessage.serializeBinaryToWriter = function(message, writer) {
       f
     );
   }
+  f = message.getExtensionsDirectory();
+  if (f.length > 0) {
+    writer.writeString(
+      8,
+      f
+    );
+  }
 };
 
 
 /**
  * @enum {number}
  */
-proto.WorkingInitMessage.OperatingSystem = {
+proto.WorkingInit.OperatingSystem = {
   WINDOWS: 0,
   LINUX: 1,
   MAC: 2
@@ -912,13 +965,13 @@ proto.WorkingInitMessage.OperatingSystem = {
  * optional string home_directory = 1;
  * @return {string}
  */
-proto.WorkingInitMessage.prototype.getHomeDirectory = function() {
+proto.WorkingInit.prototype.getHomeDirectory = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 1, ""));
 };
 
 
 /** @param {string} value */
-proto.WorkingInitMessage.prototype.setHomeDirectory = function(value) {
+proto.WorkingInit.prototype.setHomeDirectory = function(value) {
   jspb.Message.setProto3StringField(this, 1, value);
 };
 
@@ -927,13 +980,13 @@ proto.WorkingInitMessage.prototype.setHomeDirectory = function(value) {
  * optional string tmp_directory = 2;
  * @return {string}
  */
-proto.WorkingInitMessage.prototype.getTmpDirectory = function() {
+proto.WorkingInit.prototype.getTmpDirectory = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 2, ""));
 };
 
 
 /** @param {string} value */
-proto.WorkingInitMessage.prototype.setTmpDirectory = function(value) {
+proto.WorkingInit.prototype.setTmpDirectory = function(value) {
   jspb.Message.setProto3StringField(this, 2, value);
 };
 
@@ -942,13 +995,13 @@ proto.WorkingInitMessage.prototype.setTmpDirectory = function(value) {
  * optional string data_directory = 3;
  * @return {string}
  */
-proto.WorkingInitMessage.prototype.getDataDirectory = function() {
+proto.WorkingInit.prototype.getDataDirectory = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 3, ""));
 };
 
 
 /** @param {string} value */
-proto.WorkingInitMessage.prototype.setDataDirectory = function(value) {
+proto.WorkingInit.prototype.setDataDirectory = function(value) {
   jspb.Message.setProto3StringField(this, 3, value);
 };
 
@@ -957,28 +1010,28 @@ proto.WorkingInitMessage.prototype.setDataDirectory = function(value) {
  * optional string working_directory = 4;
  * @return {string}
  */
-proto.WorkingInitMessage.prototype.getWorkingDirectory = function() {
+proto.WorkingInit.prototype.getWorkingDirectory = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 4, ""));
 };
 
 
 /** @param {string} value */
-proto.WorkingInitMessage.prototype.setWorkingDirectory = function(value) {
+proto.WorkingInit.prototype.setWorkingDirectory = function(value) {
   jspb.Message.setProto3StringField(this, 4, value);
 };
 
 
 /**
  * optional OperatingSystem operating_system = 5;
- * @return {!proto.WorkingInitMessage.OperatingSystem}
+ * @return {!proto.WorkingInit.OperatingSystem}
  */
-proto.WorkingInitMessage.prototype.getOperatingSystem = function() {
+proto.WorkingInit.prototype.getOperatingSystem = function() {
-  return /** @type {!proto.WorkingInitMessage.OperatingSystem} */ (jspb.Message.getFieldWithDefault(this, 5, 0));
+  return /** @type {!proto.WorkingInit.OperatingSystem} */ (jspb.Message.getFieldWithDefault(this, 5, 0));
 };
 
 
-/** @param {!proto.WorkingInitMessage.OperatingSystem} value */
+/** @param {!proto.WorkingInit.OperatingSystem} value */
-proto.WorkingInitMessage.prototype.setOperatingSystem = function(value) {
+proto.WorkingInit.prototype.setOperatingSystem = function(value) {
   jspb.Message.setProto3EnumField(this, 5, value);
 };
 
@@ -987,13 +1040,13 @@ proto.WorkingInitMessage.prototype.setOperatingSystem = function(value) {
  * optional string shell = 6;
  * @return {string}
  */
-proto.WorkingInitMessage.prototype.getShell = function() {
+proto.WorkingInit.prototype.getShell = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 6, ""));
 };
 
 
 /** @param {string} value */
-proto.WorkingInitMessage.prototype.setShell = function(value) {
+proto.WorkingInit.prototype.setShell = function(value) {
   jspb.Message.setProto3StringField(this, 6, value);
 };
 
@@ -1002,15 +1055,30 @@ proto.WorkingInitMessage.prototype.setShell = function(value) {
  * optional string builtin_extensions_dir = 7;
  * @return {string}
  */
-proto.WorkingInitMessage.prototype.getBuiltinExtensionsDir = function() {
+proto.WorkingInit.prototype.getBuiltinExtensionsDir = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 7, ""));
 };
 
 
 /** @param {string} value */
-proto.WorkingInitMessage.prototype.setBuiltinExtensionsDir = function(value) {
+proto.WorkingInit.prototype.setBuiltinExtensionsDir = function(value) {
   jspb.Message.setProto3StringField(this, 7, value);
 };
 
 
+/**
+ * optional string extensions_directory = 8;
+ * @return {string}
+ */
+proto.WorkingInit.prototype.getExtensionsDirectory = function() {
+  return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 8, ""));
+};
+
+
+/** @param {string} value */
+proto.WorkingInit.prototype.setExtensionsDirectory = function(value) {
+  jspb.Message.setProto3StringField(this, 8, value);
+};
+
+
 goog.object.extend(exports, proto);

packages/protocol/src/proto/node.proto

@@ -9,84 +9,133 @@ enum Module {
 	Trash = 5;
 }
 
-// A proxy identified by a unique name like "fs".
+message Argument {
-message NamedProxyMessage {
+	message ErrorValue {
-	uint64 id = 1;
+		string message = 1;
-	Module module = 2;
+		string stack = 2;
-	string method = 3;
+		string code = 3;
-	repeated string args = 4;
+	}
-}
 
-// A general proxy identified by an ID like WriteStream.
+	message BufferValue {
-message NumberedProxyMessage {
+		bytes data = 1;
-	uint64 id = 1;
+	}
-	uint64 proxy_id = 2;
+
-	string method = 3;
+	message ObjectValue {
-	repeated string args = 4;
+		map<string, Argument> data = 1;
+	}
+
+	message ArrayValue {
+		repeated Argument data = 1;
+	}
+
+	message ProxyValue {
+		uint64 id = 1;
+	}
+
+	message FunctionValue {
+		uint64 id = 1;
+	}
+
+	message NullValue {}
+
+	message UndefinedValue {}
+
+	message DateValue {
+		string date = 1;
+	}
+
+	oneof msg {
+		ErrorValue error = 1;
+		BufferValue buffer = 2;
+		ObjectValue object = 3;
+		ArrayValue array = 4;
+		ProxyValue proxy = 5;
+		FunctionValue function = 6;
+		NullValue null = 7;
+		UndefinedValue undefined = 8;
+		double number = 9;
+		string string = 10;
+		bool boolean = 11;
+		DateValue date = 12;
+	}
 }
 
 // Call a remote method.
-message MethodMessage {
+message Method {
+	// A proxy identified by a unique name like "fs".
+	message Named {
+		uint64 id = 1;
+		Module module = 2;
+		string method = 3;
+		repeated Argument args = 4;
+	}
+
+	// A general proxy identified by an ID like WriteStream.
+	message Numbered {
+		uint64 id = 1;
+		uint64 proxy_id = 2;
+		string method = 3;
+		repeated Argument args = 4;
+	}
+
+	// Remote method failed.
+	message Fail {
+		uint64 id = 1;
+		Argument response = 2;
+	}
+
+	// Remote method succeeded.
+	message Success {
+		uint64 id = 1;
+		Argument response = 2;
+	}
+
 	oneof msg {
-		NamedProxyMessage named_proxy = 1;
+		Method.Named named_proxy = 1;
-		NumberedProxyMessage numbered_proxy = 2;
+		Method.Numbered numbered_proxy = 2;
 	}
 }
 
-// Call a remote callback.
+message Callback {
-message CallbackMessage {
+	// A remote callback for uniquely named proxy.
+	message Named {
+		Module module = 1;
+		uint64 callback_id = 2;
+		repeated Argument args = 3;
+	}
+
+	// A remote callback for a numbered proxy.
+	message Numbered {
+		uint64 proxy_id = 1;
+		uint64 callback_id = 2;
+		repeated Argument args = 3;
+	}
+
 	oneof msg {
-		NamedCallbackMessage named_callback = 1;
+		Callback.Named named_callback = 1;
-		NumberedCallbackMessage numbered_callback = 2;
+		Callback.Numbered numbered_callback = 2;
 	}
 }
 
-// A remote callback for uniquely named proxy.
+message Event {
-message NamedCallbackMessage {
+	// Emit an event on a uniquely named proxy.
-	Module module = 1;
+	message Named {
-	uint64 callback_id = 2;
+		Module module = 1;
-	repeated string args = 3;
+		string event = 2;
-}
+		repeated Argument args = 3;
-
-// A remote callback for a numbered proxy.
-message NumberedCallbackMessage {
-	uint64 proxy_id = 1;
-	uint64 callback_id = 2;
-	repeated string args = 3;
-}
-
-// Emit an event.
-message EventMessage {
-	oneof msg {
-		NamedEventMessage named_event = 1;
-		NumberedEventMessage numbered_event = 2;
 	}
-}
 
-// Emit an event on a uniquely named proxy.
+	// Emit an event on a numbered proxy.
-message NamedEventMessage {
+	message Numbered {
-	Module module = 1;
+		uint64 proxy_id = 1;
-	string event = 2;
+		string event = 2;
-	repeated string args = 3;
+		repeated Argument args = 3;
-}
+	}
 
-// Emit an event on a numbered proxy.
+	oneof msg {
-message NumberedEventMessage {
+		Event.Named named_event = 1;
-	uint64 proxy_id = 1;
+		Event.Numbered numbered_event = 2;
-	string event = 2;
+	}
-	repeated string args = 3;
-}
-
-// Remote method failed.
-message FailMessage {
-	uint64 id = 1;
-	string response = 2;
-}
-
-// Remote method succeeded.
-message SuccessMessage {
-	uint64 id = 1;
-	string response = 2;
 }
 
 message Ping {}

packages/protocol/src/proto/node_pb.d.ts

@@ -3,100 +3,440 @@
 
 import * as jspb from "google-protobuf";
 
-export class NamedProxyMessage extends jspb.Message {
+export class Argument extends jspb.Message {
-  getId(): number;
+  hasError(): boolean;
-  setId(value: number): void;
+  clearError(): void;
+  getError(): Argument.ErrorValue | undefined;
+  setError(value?: Argument.ErrorValue): void;
 
-  getModule(): Module;
+  hasBuffer(): boolean;
-  setModule(value: Module): void;
+  clearBuffer(): void;
+  getBuffer(): Argument.BufferValue | undefined;
+  setBuffer(value?: Argument.BufferValue): void;
 
-  getMethod(): string;
+  hasObject(): boolean;
-  setMethod(value: string): void;
+  clearObject(): void;
+  getObject(): Argument.ObjectValue | undefined;
+  setObject(value?: Argument.ObjectValue): void;
 
-  clearArgsList(): void;
+  hasArray(): boolean;
-  getArgsList(): Array<string>;
+  clearArray(): void;
-  setArgsList(value: Array<string>): void;
+  getArray(): Argument.ArrayValue | undefined;
-  addArgs(value: string, index?: number): string;
+  setArray(value?: Argument.ArrayValue): void;
 
+  hasProxy(): boolean;
+  clearProxy(): void;
+  getProxy(): Argument.ProxyValue | undefined;
+  setProxy(value?: Argument.ProxyValue): void;
+
+  hasFunction(): boolean;
+  clearFunction(): void;
+  getFunction(): Argument.FunctionValue | undefined;
+  setFunction(value?: Argument.FunctionValue): void;
+
+  hasNull(): boolean;
+  clearNull(): void;
+  getNull(): Argument.NullValue | undefined;
+  setNull(value?: Argument.NullValue): void;
+
+  hasUndefined(): boolean;
+  clearUndefined(): void;
+  getUndefined(): Argument.UndefinedValue | undefined;
+  setUndefined(value?: Argument.UndefinedValue): void;
+
+  hasNumber(): boolean;
+  clearNumber(): void;
+  getNumber(): number;
+  setNumber(value: number): void;
+
+  hasString(): boolean;
+  clearString(): void;
+  getString(): string;
+  setString(value: string): void;
+
+  hasBoolean(): boolean;
+  clearBoolean(): void;
+  getBoolean(): boolean;
+  setBoolean(value: boolean): void;
+
+  hasDate(): boolean;
+  clearDate(): void;
+  getDate(): Argument.DateValue | undefined;
+  setDate(value?: Argument.DateValue): void;
+
+  getMsgCase(): Argument.MsgCase;
   serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): NamedProxyMessage.AsObject;
+  toObject(includeInstance?: boolean): Argument.AsObject;
-  static toObject(includeInstance: boolean, msg: NamedProxyMessage): NamedProxyMessage.AsObject;
+  static toObject(includeInstance: boolean, msg: Argument): Argument.AsObject;
   static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
   static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: NamedProxyMessage, writer: jspb.BinaryWriter): void;
+  static serializeBinaryToWriter(message: Argument, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): NamedProxyMessage;
+  static deserializeBinary(bytes: Uint8Array): Argument;
-  static deserializeBinaryFromReader(message: NamedProxyMessage, reader: jspb.BinaryReader): NamedProxyMessage;
+  static deserializeBinaryFromReader(message: Argument, reader: jspb.BinaryReader): Argument;
 }
 
-export namespace NamedProxyMessage {
+export namespace Argument {
   export type AsObject = {
-    id: number,
+    error?: Argument.ErrorValue.AsObject,
-    module: Module,
+    buffer?: Argument.BufferValue.AsObject,
-    method: string,
+    object?: Argument.ObjectValue.AsObject,
-    argsList: Array<string>,
+    array?: Argument.ArrayValue.AsObject,
+    proxy?: Argument.ProxyValue.AsObject,
+    pb_function?: Argument.FunctionValue.AsObject,
+    pb_null?: Argument.NullValue.AsObject,
+    undefined?: Argument.UndefinedValue.AsObject,
+    number: number,
+    string: string,
+    pb_boolean: boolean,
+    date?: Argument.DateValue.AsObject,
+  }
+
+  export class ErrorValue extends jspb.Message {
+    getMessage(): string;
+    setMessage(value: string): void;
+
+    getStack(): string;
+    setStack(value: string): void;
+
+    getCode(): string;
+    setCode(value: string): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): ErrorValue.AsObject;
+    static toObject(includeInstance: boolean, msg: ErrorValue): ErrorValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: ErrorValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): ErrorValue;
+    static deserializeBinaryFromReader(message: ErrorValue, reader: jspb.BinaryReader): ErrorValue;
+  }
+
+  export namespace ErrorValue {
+    export type AsObject = {
+      message: string,
+      stack: string,
+      code: string,
+    }
+  }
+
+  export class BufferValue extends jspb.Message {
+    getData(): Uint8Array | string;
+    getData_asU8(): Uint8Array;
+    getData_asB64(): string;
+    setData(value: Uint8Array | string): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): BufferValue.AsObject;
+    static toObject(includeInstance: boolean, msg: BufferValue): BufferValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: BufferValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): BufferValue;
+    static deserializeBinaryFromReader(message: BufferValue, reader: jspb.BinaryReader): BufferValue;
+  }
+
+  export namespace BufferValue {
+    export type AsObject = {
+      data: Uint8Array | string,
+    }
+  }
+
+  export class ObjectValue extends jspb.Message {
+    getDataMap(): jspb.Map<string, Argument>;
+    clearDataMap(): void;
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): ObjectValue.AsObject;
+    static toObject(includeInstance: boolean, msg: ObjectValue): ObjectValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: ObjectValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): ObjectValue;
+    static deserializeBinaryFromReader(message: ObjectValue, reader: jspb.BinaryReader): ObjectValue;
+  }
+
+  export namespace ObjectValue {
+    export type AsObject = {
+      dataMap: Array<[string, Argument.AsObject]>,
+    }
+  }
+
+  export class ArrayValue extends jspb.Message {
+    clearDataList(): void;
+    getDataList(): Array<Argument>;
+    setDataList(value: Array<Argument>): void;
+    addData(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): ArrayValue.AsObject;
+    static toObject(includeInstance: boolean, msg: ArrayValue): ArrayValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: ArrayValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): ArrayValue;
+    static deserializeBinaryFromReader(message: ArrayValue, reader: jspb.BinaryReader): ArrayValue;
+  }
+
+  export namespace ArrayValue {
+    export type AsObject = {
+      dataList: Array<Argument.AsObject>,
+    }
+  }
+
+  export class ProxyValue extends jspb.Message {
+    getId(): number;
+    setId(value: number): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): ProxyValue.AsObject;
+    static toObject(includeInstance: boolean, msg: ProxyValue): ProxyValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: ProxyValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): ProxyValue;
+    static deserializeBinaryFromReader(message: ProxyValue, reader: jspb.BinaryReader): ProxyValue;
+  }
+
+  export namespace ProxyValue {
+    export type AsObject = {
+      id: number,
+    }
+  }
+
+  export class FunctionValue extends jspb.Message {
+    getId(): number;
+    setId(value: number): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): FunctionValue.AsObject;
+    static toObject(includeInstance: boolean, msg: FunctionValue): FunctionValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: FunctionValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): FunctionValue;
+    static deserializeBinaryFromReader(message: FunctionValue, reader: jspb.BinaryReader): FunctionValue;
+  }
+
+  export namespace FunctionValue {
+    export type AsObject = {
+      id: number,
+    }
+  }
+
+  export class NullValue extends jspb.Message {
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): NullValue.AsObject;
+    static toObject(includeInstance: boolean, msg: NullValue): NullValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: NullValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): NullValue;
+    static deserializeBinaryFromReader(message: NullValue, reader: jspb.BinaryReader): NullValue;
+  }
+
+  export namespace NullValue {
+    export type AsObject = {
+    }
+  }
+
+  export class UndefinedValue extends jspb.Message {
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): UndefinedValue.AsObject;
+    static toObject(includeInstance: boolean, msg: UndefinedValue): UndefinedValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: UndefinedValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): UndefinedValue;
+    static deserializeBinaryFromReader(message: UndefinedValue, reader: jspb.BinaryReader): UndefinedValue;
+  }
+
+  export namespace UndefinedValue {
+    export type AsObject = {
+    }
+  }
+
+  export class DateValue extends jspb.Message {
+    getDate(): string;
+    setDate(value: string): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): DateValue.AsObject;
+    static toObject(includeInstance: boolean, msg: DateValue): DateValue.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: DateValue, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): DateValue;
+    static deserializeBinaryFromReader(message: DateValue, reader: jspb.BinaryReader): DateValue;
+  }
+
+  export namespace DateValue {
+    export type AsObject = {
+      date: string,
+    }
+  }
+
+  export enum MsgCase {
+    MSG_NOT_SET = 0,
+    ERROR = 1,
+    BUFFER = 2,
+    OBJECT = 3,
+    ARRAY = 4,
+    PROXY = 5,
+    FUNCTION = 6,
+    NULL = 7,
+    UNDEFINED = 8,
+    NUMBER = 9,
+    STRING = 10,
+    BOOLEAN = 11,
+    DATE = 12,
   }
 }
 
-export class NumberedProxyMessage extends jspb.Message {
+export class Method extends jspb.Message {
-  getId(): number;
-  setId(value: number): void;
-
-  getProxyId(): number;
-  setProxyId(value: number): void;
-
-  getMethod(): string;
-  setMethod(value: string): void;
-
-  clearArgsList(): void;
-  getArgsList(): Array<string>;
-  setArgsList(value: Array<string>): void;
-  addArgs(value: string, index?: number): string;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): NumberedProxyMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: NumberedProxyMessage): NumberedProxyMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: NumberedProxyMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): NumberedProxyMessage;
-  static deserializeBinaryFromReader(message: NumberedProxyMessage, reader: jspb.BinaryReader): NumberedProxyMessage;
-}
-
-export namespace NumberedProxyMessage {
-  export type AsObject = {
-    id: number,
-    proxyId: number,
-    method: string,
-    argsList: Array<string>,
-  }
-}
-
-export class MethodMessage extends jspb.Message {
   hasNamedProxy(): boolean;
   clearNamedProxy(): void;
-  getNamedProxy(): NamedProxyMessage | undefined;
+  getNamedProxy(): Method.Named | undefined;
-  setNamedProxy(value?: NamedProxyMessage): void;
+  setNamedProxy(value?: Method.Named): void;
 
   hasNumberedProxy(): boolean;
   clearNumberedProxy(): void;
-  getNumberedProxy(): NumberedProxyMessage | undefined;
+  getNumberedProxy(): Method.Numbered | undefined;
-  setNumberedProxy(value?: NumberedProxyMessage): void;
+  setNumberedProxy(value?: Method.Numbered): void;
 
-  getMsgCase(): MethodMessage.MsgCase;
+  getMsgCase(): Method.MsgCase;
   serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): MethodMessage.AsObject;
+  toObject(includeInstance?: boolean): Method.AsObject;
-  static toObject(includeInstance: boolean, msg: MethodMessage): MethodMessage.AsObject;
+  static toObject(includeInstance: boolean, msg: Method): Method.AsObject;
   static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
   static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: MethodMessage, writer: jspb.BinaryWriter): void;
+  static serializeBinaryToWriter(message: Method, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): MethodMessage;
+  static deserializeBinary(bytes: Uint8Array): Method;
-  static deserializeBinaryFromReader(message: MethodMessage, reader: jspb.BinaryReader): MethodMessage;
+  static deserializeBinaryFromReader(message: Method, reader: jspb.BinaryReader): Method;
 }
 
-export namespace MethodMessage {
+export namespace Method {
   export type AsObject = {
-    namedProxy?: NamedProxyMessage.AsObject,
+    namedProxy?: Method.Named.AsObject,
-    numberedProxy?: NumberedProxyMessage.AsObject,
+    numberedProxy?: Method.Numbered.AsObject,
+  }
+
+  export class Named extends jspb.Message {
+    getId(): number;
+    setId(value: number): void;
+
+    getModule(): Module;
+    setModule(value: Module): void;
+
+    getMethod(): string;
+    setMethod(value: string): void;
+
+    clearArgsList(): void;
+    getArgsList(): Array<Argument>;
+    setArgsList(value: Array<Argument>): void;
+    addArgs(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Named.AsObject;
+    static toObject(includeInstance: boolean, msg: Named): Named.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Named, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Named;
+    static deserializeBinaryFromReader(message: Named, reader: jspb.BinaryReader): Named;
+  }
+
+  export namespace Named {
+    export type AsObject = {
+      id: number,
+      module: Module,
+      method: string,
+      argsList: Array<Argument.AsObject>,
+    }
+  }
+
+  export class Numbered extends jspb.Message {
+    getId(): number;
+    setId(value: number): void;
+
+    getProxyId(): number;
+    setProxyId(value: number): void;
+
+    getMethod(): string;
+    setMethod(value: string): void;
+
+    clearArgsList(): void;
+    getArgsList(): Array<Argument>;
+    setArgsList(value: Array<Argument>): void;
+    addArgs(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Numbered.AsObject;
+    static toObject(includeInstance: boolean, msg: Numbered): Numbered.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Numbered, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Numbered;
+    static deserializeBinaryFromReader(message: Numbered, reader: jspb.BinaryReader): Numbered;
+  }
+
+  export namespace Numbered {
+    export type AsObject = {
+      id: number,
+      proxyId: number,
+      method: string,
+      argsList: Array<Argument.AsObject>,
+    }
+  }
+
+  export class Fail extends jspb.Message {
+    getId(): number;
+    setId(value: number): void;
+
+    hasResponse(): boolean;
+    clearResponse(): void;
+    getResponse(): Argument | undefined;
+    setResponse(value?: Argument): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Fail.AsObject;
+    static toObject(includeInstance: boolean, msg: Fail): Fail.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Fail, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Fail;
+    static deserializeBinaryFromReader(message: Fail, reader: jspb.BinaryReader): Fail;
+  }
+
+  export namespace Fail {
+    export type AsObject = {
+      id: number,
+      response?: Argument.AsObject,
+    }
+  }
+
+  export class Success extends jspb.Message {
+    getId(): number;
+    setId(value: number): void;
+
+    hasResponse(): boolean;
+    clearResponse(): void;
+    getResponse(): Argument | undefined;
+    setResponse(value?: Argument): void;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Success.AsObject;
+    static toObject(includeInstance: boolean, msg: Success): Success.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Success, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Success;
+    static deserializeBinaryFromReader(message: Success, reader: jspb.BinaryReader): Success;
+  }
+
+  export namespace Success {
+    export type AsObject = {
+      id: number,
+      response?: Argument.AsObject,
+    }
   }
 
   export enum MsgCase {
@@ -106,32 +446,92 @@ export namespace MethodMessage {
   }
 }
 
-export class CallbackMessage extends jspb.Message {
+export class Callback extends jspb.Message {
   hasNamedCallback(): boolean;
   clearNamedCallback(): void;
-  getNamedCallback(): NamedCallbackMessage | undefined;
+  getNamedCallback(): Callback.Named | undefined;
-  setNamedCallback(value?: NamedCallbackMessage): void;
+  setNamedCallback(value?: Callback.Named): void;
 
   hasNumberedCallback(): boolean;
   clearNumberedCallback(): void;
-  getNumberedCallback(): NumberedCallbackMessage | undefined;
+  getNumberedCallback(): Callback.Numbered | undefined;
-  setNumberedCallback(value?: NumberedCallbackMessage): void;
+  setNumberedCallback(value?: Callback.Numbered): void;
 
-  getMsgCase(): CallbackMessage.MsgCase;
+  getMsgCase(): Callback.MsgCase;
   serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): CallbackMessage.AsObject;
+  toObject(includeInstance?: boolean): Callback.AsObject;
-  static toObject(includeInstance: boolean, msg: CallbackMessage): CallbackMessage.AsObject;
+  static toObject(includeInstance: boolean, msg: Callback): Callback.AsObject;
   static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
   static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: CallbackMessage, writer: jspb.BinaryWriter): void;
+  static serializeBinaryToWriter(message: Callback, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): CallbackMessage;
+  static deserializeBinary(bytes: Uint8Array): Callback;
-  static deserializeBinaryFromReader(message: CallbackMessage, reader: jspb.BinaryReader): CallbackMessage;
+  static deserializeBinaryFromReader(message: Callback, reader: jspb.BinaryReader): Callback;
 }
 
-export namespace CallbackMessage {
+export namespace Callback {
   export type AsObject = {
-    namedCallback?: NamedCallbackMessage.AsObject,
+    namedCallback?: Callback.Named.AsObject,
-    numberedCallback?: NumberedCallbackMessage.AsObject,
+    numberedCallback?: Callback.Numbered.AsObject,
+  }
+
+  export class Named extends jspb.Message {
+    getModule(): Module;
+    setModule(value: Module): void;
+
+    getCallbackId(): number;
+    setCallbackId(value: number): void;
+
+    clearArgsList(): void;
+    getArgsList(): Array<Argument>;
+    setArgsList(value: Array<Argument>): void;
+    addArgs(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Named.AsObject;
+    static toObject(includeInstance: boolean, msg: Named): Named.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Named, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Named;
+    static deserializeBinaryFromReader(message: Named, reader: jspb.BinaryReader): Named;
+  }
+
+  export namespace Named {
+    export type AsObject = {
+      module: Module,
+      callbackId: number,
+      argsList: Array<Argument.AsObject>,
+    }
+  }
+
+  export class Numbered extends jspb.Message {
+    getProxyId(): number;
+    setProxyId(value: number): void;
+
+    getCallbackId(): number;
+    setCallbackId(value: number): void;
+
+    clearArgsList(): void;
+    getArgsList(): Array<Argument>;
+    setArgsList(value: Array<Argument>): void;
+    addArgs(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Numbered.AsObject;
+    static toObject(includeInstance: boolean, msg: Numbered): Numbered.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Numbered, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Numbered;
+    static deserializeBinaryFromReader(message: Numbered, reader: jspb.BinaryReader): Numbered;
+  }
+
+  export namespace Numbered {
+    export type AsObject = {
+      proxyId: number,
+      callbackId: number,
+      argsList: Array<Argument.AsObject>,
+    }
   }
 
   export enum MsgCase {
@@ -141,92 +541,92 @@ export namespace CallbackMessage {
   }
 }
 
-export class NamedCallbackMessage extends jspb.Message {
+export class Event extends jspb.Message {
-  getModule(): Module;
-  setModule(value: Module): void;
-
-  getCallbackId(): number;
-  setCallbackId(value: number): void;
-
-  clearArgsList(): void;
-  getArgsList(): Array<string>;
-  setArgsList(value: Array<string>): void;
-  addArgs(value: string, index?: number): string;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): NamedCallbackMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: NamedCallbackMessage): NamedCallbackMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: NamedCallbackMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): NamedCallbackMessage;
-  static deserializeBinaryFromReader(message: NamedCallbackMessage, reader: jspb.BinaryReader): NamedCallbackMessage;
-}
-
-export namespace NamedCallbackMessage {
-  export type AsObject = {
-    module: Module,
-    callbackId: number,
-    argsList: Array<string>,
-  }
-}
-
-export class NumberedCallbackMessage extends jspb.Message {
-  getProxyId(): number;
-  setProxyId(value: number): void;
-
-  getCallbackId(): number;
-  setCallbackId(value: number): void;
-
-  clearArgsList(): void;
-  getArgsList(): Array<string>;
-  setArgsList(value: Array<string>): void;
-  addArgs(value: string, index?: number): string;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): NumberedCallbackMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: NumberedCallbackMessage): NumberedCallbackMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: NumberedCallbackMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): NumberedCallbackMessage;
-  static deserializeBinaryFromReader(message: NumberedCallbackMessage, reader: jspb.BinaryReader): NumberedCallbackMessage;
-}
-
-export namespace NumberedCallbackMessage {
-  export type AsObject = {
-    proxyId: number,
-    callbackId: number,
-    argsList: Array<string>,
-  }
-}
-
-export class EventMessage extends jspb.Message {
   hasNamedEvent(): boolean;
   clearNamedEvent(): void;
-  getNamedEvent(): NamedEventMessage | undefined;
+  getNamedEvent(): Event.Named | undefined;
-  setNamedEvent(value?: NamedEventMessage): void;
+  setNamedEvent(value?: Event.Named): void;
 
   hasNumberedEvent(): boolean;
   clearNumberedEvent(): void;
-  getNumberedEvent(): NumberedEventMessage | undefined;
+  getNumberedEvent(): Event.Numbered | undefined;
-  setNumberedEvent(value?: NumberedEventMessage): void;
+  setNumberedEvent(value?: Event.Numbered): void;
 
-  getMsgCase(): EventMessage.MsgCase;
+  getMsgCase(): Event.MsgCase;
   serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): EventMessage.AsObject;
+  toObject(includeInstance?: boolean): Event.AsObject;
-  static toObject(includeInstance: boolean, msg: EventMessage): EventMessage.AsObject;
+  static toObject(includeInstance: boolean, msg: Event): Event.AsObject;
   static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
   static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: EventMessage, writer: jspb.BinaryWriter): void;
+  static serializeBinaryToWriter(message: Event, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): EventMessage;
+  static deserializeBinary(bytes: Uint8Array): Event;
-  static deserializeBinaryFromReader(message: EventMessage, reader: jspb.BinaryReader): EventMessage;
+  static deserializeBinaryFromReader(message: Event, reader: jspb.BinaryReader): Event;
 }
 
-export namespace EventMessage {
+export namespace Event {
   export type AsObject = {
-    namedEvent?: NamedEventMessage.AsObject,
+    namedEvent?: Event.Named.AsObject,
-    numberedEvent?: NumberedEventMessage.AsObject,
+    numberedEvent?: Event.Numbered.AsObject,
+  }
+
+  export class Named extends jspb.Message {
+    getModule(): Module;
+    setModule(value: Module): void;
+
+    getEvent(): string;
+    setEvent(value: string): void;
+
+    clearArgsList(): void;
+    getArgsList(): Array<Argument>;
+    setArgsList(value: Array<Argument>): void;
+    addArgs(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Named.AsObject;
+    static toObject(includeInstance: boolean, msg: Named): Named.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Named, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Named;
+    static deserializeBinaryFromReader(message: Named, reader: jspb.BinaryReader): Named;
+  }
+
+  export namespace Named {
+    export type AsObject = {
+      module: Module,
+      event: string,
+      argsList: Array<Argument.AsObject>,
+    }
+  }
+
+  export class Numbered extends jspb.Message {
+    getProxyId(): number;
+    setProxyId(value: number): void;
+
+    getEvent(): string;
+    setEvent(value: string): void;
+
+    clearArgsList(): void;
+    getArgsList(): Array<Argument>;
+    setArgsList(value: Array<Argument>): void;
+    addArgs(value?: Argument, index?: number): Argument;
+
+    serializeBinary(): Uint8Array;
+    toObject(includeInstance?: boolean): Numbered.AsObject;
+    static toObject(includeInstance: boolean, msg: Numbered): Numbered.AsObject;
+    static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+    static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+    static serializeBinaryToWriter(message: Numbered, writer: jspb.BinaryWriter): void;
+    static deserializeBinary(bytes: Uint8Array): Numbered;
+    static deserializeBinaryFromReader(message: Numbered, reader: jspb.BinaryReader): Numbered;
+  }
+
+  export namespace Numbered {
+    export type AsObject = {
+      proxyId: number,
+      event: string,
+      argsList: Array<Argument.AsObject>,
+    }
   }
 
   export enum MsgCase {
@@ -236,114 +636,6 @@ export namespace EventMessage {
   }
 }
 
-export class NamedEventMessage extends jspb.Message {
-  getModule(): Module;
-  setModule(value: Module): void;
-
-  getEvent(): string;
-  setEvent(value: string): void;
-
-  clearArgsList(): void;
-  getArgsList(): Array<string>;
-  setArgsList(value: Array<string>): void;
-  addArgs(value: string, index?: number): string;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): NamedEventMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: NamedEventMessage): NamedEventMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: NamedEventMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): NamedEventMessage;
-  static deserializeBinaryFromReader(message: NamedEventMessage, reader: jspb.BinaryReader): NamedEventMessage;
-}
-
-export namespace NamedEventMessage {
-  export type AsObject = {
-    module: Module,
-    event: string,
-    argsList: Array<string>,
-  }
-}
-
-export class NumberedEventMessage extends jspb.Message {
-  getProxyId(): number;
-  setProxyId(value: number): void;
-
-  getEvent(): string;
-  setEvent(value: string): void;
-
-  clearArgsList(): void;
-  getArgsList(): Array<string>;
-  setArgsList(value: Array<string>): void;
-  addArgs(value: string, index?: number): string;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): NumberedEventMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: NumberedEventMessage): NumberedEventMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: NumberedEventMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): NumberedEventMessage;
-  static deserializeBinaryFromReader(message: NumberedEventMessage, reader: jspb.BinaryReader): NumberedEventMessage;
-}
-
-export namespace NumberedEventMessage {
-  export type AsObject = {
-    proxyId: number,
-    event: string,
-    argsList: Array<string>,
-  }
-}
-
-export class FailMessage extends jspb.Message {
-  getId(): number;
-  setId(value: number): void;
-
-  getResponse(): string;
-  setResponse(value: string): void;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): FailMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: FailMessage): FailMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: FailMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): FailMessage;
-  static deserializeBinaryFromReader(message: FailMessage, reader: jspb.BinaryReader): FailMessage;
-}
-
-export namespace FailMessage {
-  export type AsObject = {
-    id: number,
-    response: string,
-  }
-}
-
-export class SuccessMessage extends jspb.Message {
-  getId(): number;
-  setId(value: number): void;
-
-  getResponse(): string;
-  setResponse(value: string): void;
-
-  serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): SuccessMessage.AsObject;
-  static toObject(includeInstance: boolean, msg: SuccessMessage): SuccessMessage.AsObject;
-  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
-  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: SuccessMessage, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): SuccessMessage;
-  static deserializeBinaryFromReader(message: SuccessMessage, reader: jspb.BinaryReader): SuccessMessage;
-}
-
-export namespace SuccessMessage {
-  export type AsObject = {
-    id: number,
-    response: string,
-  }
-}
-
 export class Ping extends jspb.Message {
   serializeBinary(): Uint8Array;
   toObject(includeInstance?: boolean): Ping.AsObject;

packages/protocol/src/proto/vscode.proto

@@ -1,7 +1,7 @@
 syntax = "proto3";
 
 // Sent when a shared process becomes active
-message SharedProcessActiveMessage {
+message SharedProcessActive {
 	string socket_path = 1;
 	string log_path = 2;
-}
+}

packages/protocol/src/proto/vscode_pb.d.ts

@@ -3,7 +3,7 @@
 
 import * as jspb from "google-protobuf";
 
-export class SharedProcessActiveMessage extends jspb.Message {
+export class SharedProcessActive extends jspb.Message {
   getSocketPath(): string;
   setSocketPath(value: string): void;
 
@@ -11,16 +11,16 @@ export class SharedProcessActiveMessage extends jspb.Message {
   setLogPath(value: string): void;
 
   serializeBinary(): Uint8Array;
-  toObject(includeInstance?: boolean): SharedProcessActiveMessage.AsObject;
+  toObject(includeInstance?: boolean): SharedProcessActive.AsObject;
-  static toObject(includeInstance: boolean, msg: SharedProcessActiveMessage): SharedProcessActiveMessage.AsObject;
+  static toObject(includeInstance: boolean, msg: SharedProcessActive): SharedProcessActive.AsObject;
   static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
   static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
-  static serializeBinaryToWriter(message: SharedProcessActiveMessage, writer: jspb.BinaryWriter): void;
+  static serializeBinaryToWriter(message: SharedProcessActive, writer: jspb.BinaryWriter): void;
-  static deserializeBinary(bytes: Uint8Array): SharedProcessActiveMessage;
+  static deserializeBinary(bytes: Uint8Array): SharedProcessActive;
-  static deserializeBinaryFromReader(message: SharedProcessActiveMessage, reader: jspb.BinaryReader): SharedProcessActiveMessage;
+  static deserializeBinaryFromReader(message: SharedProcessActive, reader: jspb.BinaryReader): SharedProcessActive;
 }
 
-export namespace SharedProcessActiveMessage {
+export namespace SharedProcessActive {
   export type AsObject = {
     socketPath: string,
     logPath: string,

packages/protocol/src/proto/vscode_pb.js

@@ -11,8 +11,7 @@ var jspb = require('google-protobuf');
 var goog = jspb;
 var global = Function('return this')();
 
-goog.exportSymbol('proto.SharedProcessActiveMessage', null, global);
+goog.exportSymbol('proto.SharedProcessActive', null, global);
-
 /**
  * Generated by JsPbCodeGenerator.
  * @param {Array=} opt_data Optional initial data array, typically from a
@@ -23,15 +22,20 @@ goog.exportSymbol('proto.SharedProcessActiveMessage', null, global);
  * @extends {jspb.Message}
  * @constructor
  */
-proto.SharedProcessActiveMessage = function(opt_data) {
+proto.SharedProcessActive = function(opt_data) {
   jspb.Message.initialize(this, opt_data, 0, -1, null, null);
 };
-goog.inherits(proto.SharedProcessActiveMessage, jspb.Message);
+goog.inherits(proto.SharedProcessActive, jspb.Message);
 if (goog.DEBUG && !COMPILED) {
-  proto.SharedProcessActiveMessage.displayName = 'proto.SharedProcessActiveMessage';
+  /**
+   * @public
+   * @override
+   */
+  proto.SharedProcessActive.displayName = 'proto.SharedProcessActive';
 }
 
 
+
 if (jspb.Message.GENERATE_TO_OBJECT) {
 /**
  * Creates an object representation of this proto suitable for use in Soy templates.
@@ -43,8 +47,8 @@ if (jspb.Message.GENERATE_TO_OBJECT) {
  *     for transitional soy proto support: http://goto/soy-param-migration
  * @return {!Object}
  */
-proto.SharedProcessActiveMessage.prototype.toObject = function(opt_includeInstance) {
+proto.SharedProcessActive.prototype.toObject = function(opt_includeInstance) {
-  return proto.SharedProcessActiveMessage.toObject(opt_includeInstance, this);
+  return proto.SharedProcessActive.toObject(opt_includeInstance, this);
 };
 
 
@@ -53,12 +57,12 @@ proto.SharedProcessActiveMessage.prototype.toObject = function(opt_includeInstan
  * @param {boolean|undefined} includeInstance Whether to include the JSPB
  *     instance for transitional soy proto support:
  *     http://goto/soy-param-migration
- * @param {!proto.SharedProcessActiveMessage} msg The msg instance to transform.
+ * @param {!proto.SharedProcessActive} msg The msg instance to transform.
  * @return {!Object}
  * @suppress {unusedLocalVariables} f is only used for nested messages
  */
-proto.SharedProcessActiveMessage.toObject = function(includeInstance, msg) {
+proto.SharedProcessActive.toObject = function(includeInstance, msg) {
-  var f, obj = {
+  var obj = {
     socketPath: jspb.Message.getFieldWithDefault(msg, 1, ""),
     logPath: jspb.Message.getFieldWithDefault(msg, 2, "")
   };
@@ -74,23 +78,23 @@ proto.SharedProcessActiveMessage.toObject = function(includeInstance, msg) {
 /**
  * Deserializes binary data (in protobuf wire format).
  * @param {jspb.ByteSource} bytes The bytes to deserialize.
- * @return {!proto.SharedProcessActiveMessage}
+ * @return {!proto.SharedProcessActive}
  */
-proto.SharedProcessActiveMessage.deserializeBinary = function(bytes) {
+proto.SharedProcessActive.deserializeBinary = function(bytes) {
   var reader = new jspb.BinaryReader(bytes);
-  var msg = new proto.SharedProcessActiveMessage;
+  var msg = new proto.SharedProcessActive;
-  return proto.SharedProcessActiveMessage.deserializeBinaryFromReader(msg, reader);
+  return proto.SharedProcessActive.deserializeBinaryFromReader(msg, reader);
 };
 
 
 /**
  * Deserializes binary data (in protobuf wire format) from the
  * given reader into the given message object.
- * @param {!proto.SharedProcessActiveMessage} msg The message object to deserialize into.
+ * @param {!proto.SharedProcessActive} msg The message object to deserialize into.
  * @param {!jspb.BinaryReader} reader The BinaryReader to use.
- * @return {!proto.SharedProcessActiveMessage}
+ * @return {!proto.SharedProcessActive}
  */
-proto.SharedProcessActiveMessage.deserializeBinaryFromReader = function(msg, reader) {
+proto.SharedProcessActive.deserializeBinaryFromReader = function(msg, reader) {
   while (reader.nextField()) {
     if (reader.isEndGroup()) {
       break;
@@ -118,9 +122,9 @@ proto.SharedProcessActiveMessage.deserializeBinaryFromReader = function(msg, rea
  * Serializes the message to binary data (in protobuf wire format).
  * @return {!Uint8Array}
  */
-proto.SharedProcessActiveMessage.prototype.serializeBinary = function() {
+proto.SharedProcessActive.prototype.serializeBinary = function() {
   var writer = new jspb.BinaryWriter();
-  proto.SharedProcessActiveMessage.serializeBinaryToWriter(this, writer);
+  proto.SharedProcessActive.serializeBinaryToWriter(this, writer);
   return writer.getResultBuffer();
 };
 
@@ -128,11 +132,11 @@ proto.SharedProcessActiveMessage.prototype.serializeBinary = function() {
 /**
  * Serializes the given message to binary data (in protobuf wire
  * format), writing to the given BinaryWriter.
- * @param {!proto.SharedProcessActiveMessage} message
+ * @param {!proto.SharedProcessActive} message
  * @param {!jspb.BinaryWriter} writer
  * @suppress {unusedLocalVariables} f is only used for nested messages
  */
-proto.SharedProcessActiveMessage.serializeBinaryToWriter = function(message, writer) {
+proto.SharedProcessActive.serializeBinaryToWriter = function(message, writer) {
   var f = undefined;
   f = message.getSocketPath();
   if (f.length > 0) {
@@ -155,13 +159,13 @@ proto.SharedProcessActiveMessage.serializeBinaryToWriter = function(message, wri
  * optional string socket_path = 1;
  * @return {string}
  */
-proto.SharedProcessActiveMessage.prototype.getSocketPath = function() {
+proto.SharedProcessActive.prototype.getSocketPath = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 1, ""));
 };
 
 
 /** @param {string} value */
-proto.SharedProcessActiveMessage.prototype.setSocketPath = function(value) {
+proto.SharedProcessActive.prototype.setSocketPath = function(value) {
   jspb.Message.setProto3StringField(this, 1, value);
 };
 
@@ -170,13 +174,13 @@ proto.SharedProcessActiveMessage.prototype.setSocketPath = function(value) {
  * optional string log_path = 2;
  * @return {string}
  */
-proto.SharedProcessActiveMessage.prototype.getLogPath = function() {
+proto.SharedProcessActive.prototype.getLogPath = function() {
   return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 2, ""));
 };
 
 
 /** @param {string} value */
-proto.SharedProcessActiveMessage.prototype.setLogPath = function(value) {
+proto.SharedProcessActive.prototype.setLogPath = function(value) {
   jspb.Message.setProto3StringField(this, 2, value);
 };
 

packages/protocol/test/child_process.test.ts

@@ -10,7 +10,7 @@ describe("child_process", () => {
 	const cp = client.modules[Module.ChildProcess];
 
 	const getStdout = async (proc: ChildProcess): Promise<string> => {
-		return new Promise((r): Readable => proc.stdout.on("data", r))
+		return new Promise((r): Readable => proc.stdout!.on("data", r))
 		.then((s) => s.toString());
 	};
 
@@ -36,10 +36,10 @@ describe("child_process", () => {
 		it("should cat", async () => {
 			const proc = cp.spawn("cat", []);
 			expect(proc.pid).toBe(-1);
-			proc.stdin.write("banana");
+			proc.stdin!.write("banana");
 			await expect(getStdout(proc)).resolves.toBe("banana");
 
-			proc.stdin.end();
+			proc.stdin!.end();
 			proc.kill();
 
 			expect(proc.pid).toBeGreaterThan(-1);
@@ -53,6 +53,11 @@ describe("child_process", () => {
 
 			await expect(getStdout(proc)).resolves.toContain("hi=donkey\n");
 		});
+
+		it("should eval", async () => {
+			const proc = cp.spawn("node", ["-e", "console.log('foo')"]);
+			await expect(getStdout(proc)).resolves.toContain("foo");
+		});
 	});
 
 	describe("fork", () => {

packages/protocol/test/fs.test.ts

@@ -4,6 +4,8 @@ import * as util from "util";
 import { Module } from "../src/common/proxy";
 import { createClient, Helper } from "./helpers";
 
+// tslint:disable deprecation to use fs.exists
+
 describe("fs", () => {
 	const client = createClient();
 	// tslint:disable-next-line no-any
@@ -242,6 +244,14 @@ describe("fs", () => {
 			await util.promisify(nativeFs.close)(fd);
 		});
 
+		it("should futimes existing file with date", async () => {
+			const file = await helper.createTmpFile();
+			const fd = await util.promisify(nativeFs.open)(file, "w");
+			await expect(util.promisify(fs.futimes)(fd, new Date(), new Date()))
+				.resolves.toBeUndefined();
+			await util.promisify(nativeFs.close)(fd);
+		});
+
 		it("should fail to futimes nonexistent file", async () => {
 			await expect(util.promisify(fs.futimes)(99999, 9999, 9999))
 				.rejects.toThrow("EBADF");
@@ -346,7 +356,7 @@ describe("fs", () => {
 		it("should read existing file", async () => {
 			const fd = await util.promisify(nativeFs.open)(__filename, "r");
 			const stat = await util.promisify(nativeFs.fstat)(fd);
-			const buffer = new Buffer(stat.size);
+			const buffer = Buffer.alloc(stat.size);
 			let bytesRead = 0;
 			let chunkSize = 2048;
 			while (bytesRead < stat.size) {
@@ -364,7 +374,7 @@ describe("fs", () => {
 		});
 
 		it("should fail to read nonexistent file", async () => {
-			await expect(util.promisify(fs.read)(99999, new Buffer(10), 9999, 999, 999))
+			await expect(util.promisify(fs.read)(99999, Buffer.alloc(10), 9999, 999, 999))
 				.rejects.toThrow("EBADF");
 		});
 	});
@@ -466,6 +476,7 @@ describe("fs", () => {
 			expect(stat).toMatchObject({
 				size: nativeStat.size,
 			});
+			expect(typeof stat.mtime.getTime()).toBe("number");
 			expect(stat.isFile()).toBe(true);
 		});
 
@@ -493,7 +504,7 @@ describe("fs", () => {
 			const destination = helper.tmpFile();
 			await expect(util.promisify(fs.symlink)(source, destination))
 				.resolves.toBeUndefined();
-			expect(util.promisify(nativeFs.exists)(source))
+			await expect(util.promisify(nativeFs.exists)(source))
 				.resolves.toBe(true);
 		});
 
@@ -525,7 +536,7 @@ describe("fs", () => {
 			const file = await helper.createTmpFile();
 			await expect(util.promisify(fs.unlink)(file))
 				.resolves.toBeUndefined();
-			expect(util.promisify(nativeFs.exists)(file))
+			await expect(util.promisify(nativeFs.exists)(file))
 				.resolves.toBe(false);
 		});
 

packages/protocol/test/net.test.ts

@@ -38,6 +38,23 @@ describe("net", () => {
 			expect(fn).toHaveBeenCalledTimes(1);
 		});
 
+		it("should remove event listener", async () => {
+			const socket = new net.Socket();
+
+			const fn1 = jest.fn();
+			const fn2 = jest.fn();
+
+			socket.on("error", fn1);
+			socket.on("error", fn2);
+			socket.off("error", fn1);
+
+			socket.connect("/tmp/t/e/s/t/d/o/e/s/n/o/t/e/x/i/s/t");
+
+			await new Promise((r): nativeNet.Socket => socket.on("close", r));
+			expect(fn1).toHaveBeenCalledTimes(0);
+			expect(fn2).toHaveBeenCalledTimes(1);
+		});
+
 		it("should connect", async () => {
 			await new Promise((resolve): void => {
 				const socket = net.createConnection(socketPath, () => {

packages/protocol/test/server.test.ts

@@ -12,12 +12,10 @@ describe("Server", () => {
 		workingDirectory,
 	});
 
-	it("should get init msg", (done) => {
+	it("should get init msg", async () => {
-		client.initData.then((data) => {
+		const data = await client.initData;
-			expect(data.dataDirectory).toEqual(dataDirectory);
+		expect(data.dataDirectory).toEqual(dataDirectory);
-			expect(data.workingDirectory).toEqual(workingDirectory);
+		expect(data.workingDirectory).toEqual(workingDirectory);
-			expect(data.builtInExtensionsDirectory).toEqual(builtInExtensionsDirectory);
+		expect(data.builtInExtensionsDirectory).toEqual(builtInExtensionsDirectory);
-			done();
-		});
 	});
 });

packages/protocol/test/util.test.ts

@@ -0,0 +1,101 @@
+import * as fs from "fs";
+import * as util from "util";
+import { argumentToProto, protoToArgument } from "../src/common/util";
+
+describe("Convert", () => {
+	it("should convert nothing", () => {
+		expect(protoToArgument()).toBeUndefined();
+	});
+
+	it("should convert null", () => {
+		expect(protoToArgument(argumentToProto(null))).toBeNull();
+	});
+
+	it("should convert undefined", () => {
+		expect(protoToArgument(argumentToProto(undefined))).toBeUndefined();
+	});
+
+	it("should convert string", () => {
+		expect(protoToArgument(argumentToProto("test"))).toBe("test");
+	});
+
+	it("should convert number", () => {
+		expect(protoToArgument(argumentToProto(10))).toBe(10);
+	});
+
+	it("should convert boolean", () => {
+		expect(protoToArgument(argumentToProto(true))).toBe(true);
+		expect(protoToArgument(argumentToProto(false))).toBe(false);
+	});
+
+	it("should convert error", () => {
+		const error = new Error("message");
+		const convertedError = protoToArgument(argumentToProto(error));
+
+		expect(convertedError instanceof Error).toBeTruthy();
+		expect(convertedError.message).toBe("message");
+	});
+
+	it("should convert buffer", async () => {
+		const buffer = await util.promisify(fs.readFile)(__filename);
+		expect(buffer instanceof Buffer).toBeTruthy();
+
+		const convertedBuffer = protoToArgument(argumentToProto(buffer));
+		expect(convertedBuffer instanceof Buffer).toBeTruthy();
+		expect(convertedBuffer.toString()).toBe(buffer.toString());
+	});
+
+	it("should convert proxy", () => {
+		let i = 0;
+		const proto = argumentToProto(
+			{ onEvent: (): void => undefined },
+			undefined,
+			() => i++,
+		);
+
+		const proxy = protoToArgument(proto, undefined, (id) => {
+			return {
+				id: `created: ${id}`,
+				dispose: (): Promise<void> => Promise.resolve(),
+				onDone: (): Promise<void> => Promise.resolve(),
+				onEvent: (): Promise<void> => Promise.resolve(),
+			};
+		});
+
+		expect(proxy.id).toBe("created: 0");
+	});
+
+	it("should convert function", () => {
+		const fn = jest.fn();
+		// tslint:disable-next-line no-any
+		const map = new Map<number, (...args: any[]) => void>();
+		let i = 0;
+		const proto = argumentToProto(
+			fn,
+			(f) => {
+				map.set(i++, f);
+
+				return i - 1;
+			},
+		);
+
+		const remoteFn = protoToArgument(proto, (id, args) => {
+			map.get(id)!(...args);
+		});
+
+		remoteFn("a", "b", 1);
+
+		expect(fn).toHaveBeenCalledWith("a", "b", 1);
+	});
+
+	it("should convert array", () => {
+		const array = ["a", "b", 1, [1, "a"], null, undefined];
+		expect(protoToArgument(argumentToProto(array))).toEqual(array);
+	});
+
+	it("should convert object", () => {
+		const obj = { a: "test" };
+		// const obj = { "a": 1, "b": [1, "a"], test: null, test2: undefined };
+		expect(protoToArgument(argumentToProto(obj))).toEqual(obj);
+	});
+});

packages/server/package.json

@@ -9,7 +9,7 @@
 		"build:binary": "ts-node scripts/nbin.ts"
 	},
 	"dependencies": {
-		"@coder/nbin": "^1.0.4",
+		"@coder/nbin": "^1.0.7",
 		"commander": "^2.19.0",
 		"express": "^4.16.4",
 		"express-static-gzip": "^1.1.3",

packages/server/src/cli.ts

@@ -1,5 +1,5 @@
 import { field, logger } from "@coder/logger";
-import { ServerMessage, SharedProcessActiveMessage } from "@coder/protocol/src/proto";
+import { ServerMessage, SharedProcessActive } from "@coder/protocol/src/proto";
 import { ChildProcess, fork, ForkOptions, spawn } from "child_process";
 import { randomFillSync } from "crypto";
 import * as fs from "fs";
@@ -19,9 +19,11 @@ import * as commander from "commander";
 commander.version(process.env.VERSION || "development")
 	.name("code-server")
 	.description("Run VS Code on a remote server.")
-	.option("--cert")
+	.option("--cert <value>")
-	.option("--cert-key")
+	.option("--cert-key <value>")
-	.option("-d, --data-dir <value>", "Customize where user-data is stored.")
+	.option("-e, --extensions-dir <dir>", "Set the root path for extensions.")
+	.option("-d --user-data-dir <dir>", "	Specifies the directory that user data is kept in, useful when running as root.")
+	.option("--data-dir <value>", "DEPRECATED: Use '--user-data-dir' instead. Customize where user-data is stored.")
 	.option("-h, --host <value>", "Customize the hostname.", "0.0.0.0")
 	.option("-o, --open", "Open in the browser on startup.", false)
 	.option("-p, --port <number>", "Port to bind on.", 8443)
@@ -38,6 +40,10 @@ Error.stackTraceLimit = Infinity;
 if (isCli) {
 	require("nbin").shimNativeFs(buildDir);
 }
+// Makes strings or numbers bold in stdout
+const bold = (text: string | number): string | number => {
+	return `\u001B[1m${text}\u001B[0m`;
+};
 
 (async (): Promise<void> => {
 	const args = commander.args;
@@ -47,6 +53,9 @@ if (isCli) {
 		readonly host: string;
 		readonly port: number;
 
+		readonly userDataDir?: string;
+		readonly extensionsDir?: string;
+
 		readonly dataDir?: string;
 		readonly password?: string;
 		readonly open?: boolean;
@@ -63,7 +72,8 @@ if (isCli) {
 	const noAuthValue = (commander as any).auth;
 	options.noAuth = !noAuthValue;
 
-	const dataDir = path.resolve(options.dataDir || path.join(dataHome, "code-server"));
+	const dataDir = path.resolve(options.userDataDir || options.dataDir || path.join(dataHome, "code-server"));
+	const extensionsDir = options.extensionsDir ? path.resolve(options.extensionsDir) : path.resolve(dataDir, "extensions");
 	const workingDir = path.resolve(args[0] || process.cwd());
 
 	if (!fs.existsSync(dataDir)) {
@@ -77,6 +87,7 @@ if (isCli) {
 	await Promise.all([
 		fse.mkdirp(cacheHome),
 		fse.mkdirp(dataDir),
+		fse.mkdirp(extensionsDir),
 		fse.mkdirp(workingDir),
 	]);
 
@@ -140,12 +151,17 @@ if (isCli) {
 	}
 
 	logger.info(`\u001B[1mcode-server ${process.env.VERSION ? `v${process.env.VERSION}` : "development"}`);
+
+	if (options.dataDir) {
+		logger.warn('"--data-dir" is deprecated. Use "--user-data-dir" instead.');
+	}
+
 	// TODO: fill in appropriate doc url
 	logger.info("Additional documentation: http://github.com/codercom/code-server");
-	logger.info("Initializing", field("data-dir", dataDir), field("working-dir", workingDir), field("log-dir", logDir));
+	logger.info("Initializing", field("data-dir", dataDir), field("extensions-dir", extensionsDir), field("working-dir", workingDir), field("log-dir", logDir));
-	const sharedProcess = new SharedProcess(dataDir, builtInExtensionsDir);
+	const sharedProcess = new SharedProcess(dataDir, extensionsDir, builtInExtensionsDir);
 	const sendSharedProcessReady = (socket: WebSocket): void => {
-		const active = new SharedProcessActiveMessage();
+		const active = new SharedProcessActive();
 		active.setSocketPath(sharedProcess.socketPath);
 		active.setLogPath(logDir);
 		const serverMessage = new ServerMessage();
@@ -184,7 +200,13 @@ if (isCli) {
 				const webpackConfig = require(path.resolve(__dirname, "..", "..", "web", "webpack.config.js"));
 				const compiler = require("webpack")(webpackConfig);
 				app.use(require("webpack-dev-middleware")(compiler, {
-					logger,
+					logger: {
+						trace: (m: string): void => logger.trace("webpack", field("message", m)),
+						debug: (m: string): void => logger.debug("webpack", field("message", m)),
+						info: (m: string): void => logger.info("webpack", field("message", m)),
+						warn: (m: string): void => logger.warn("webpack", field("message", m)),
+						error: (m: string): void => logger.error("webpack", field("message", m)),
+					},
 					publicPath: webpackConfig.output.publicPath,
 					stats: webpackConfig.stats,
 				}));
@@ -192,6 +214,7 @@ if (isCli) {
 			}
 		},
 		serverOptions: {
+			extensionsDirectory: extensionsDir,
 			builtInExtensionsDirectory: builtInExtensionsDir,
 			dataDirectory: dataDir,
 			workingDirectory: workingDir,
@@ -234,11 +257,16 @@ if (isCli) {
 			logger.info(`WebSocket closed \u001B[0m${req.url}`, field("client", id), field("code", code));
 		});
 	});
-
+	app.wss.on("error", (err: NodeJS.ErrnoException) => {
+		if (err.code === "EADDRINUSE") {
+			logger.error(`Port ${bold(options.port)} is in use. Please free up port ${options.port} or specify a different port with the -p flag`);
+			process.exit(1);
+		}
+	});
 	if (!options.certKey && !options.cert) {
 		logger.warn("No certificate specified. \u001B[1mThis could be insecure.");
 		// TODO: fill in appropriate doc url
-		logger.warn("Documentation on securing your setup: https://coder.com/docs");
+		logger.warn("Documentation on securing your setup: https://github.com/codercom/code-server/blob/master/doc/security/ssl.md");
 	}
 
 	if (!options.noAuth) {

packages/server/src/portScanner.ts

@@ -17,7 +17,7 @@ export interface PortScanner {
  * Will scan local ports and emit events when ports are added or removed.
  * Currently only scans TCP ports.
  */
-export const createPortScanner = (scanInterval: number = 250): PortScanner => {
+export const createPortScanner = (scanInterval: number = 5000): PortScanner => {
 	const ports = new Map<number, number>();
 
 	const addEmitter = new Emitter<number[]>();
@@ -76,9 +76,14 @@ export const createPortScanner = (scanInterval: number = 250): PortScanner => {
 	let disposed: boolean = false;
 
 	const doInterval = (): void => {
+		logger.trace("scanning ports");
 		scan((error) => {
 			if (error) {
-				logger.error(`Port scanning will not be available: ${error.message}.`);
+				if ((error as NodeJS.ErrnoException).code === "ENOENT") {
+					logger.warn("Port scanning will not be available because netstat is not installed");
+				} else {
+					logger.warn(`Port scanning will not be available: ${error.message}`);
+				}
 				disposed = true;
 			} else if (!disposed) {
 				lastTimeout = setTimeout(doInterval, scanInterval);

packages/server/src/server.ts

@@ -271,7 +271,7 @@ export const createApp = async (options: CreateAppOptions): Promise<{
 				const body = data.join("");
 				await mkdirp(path.dirname(fullPath));
 				fs.writeFileSync(fullPath, body);
-				logger.debug("Wrote resource", field("path", fullPath), field("content-length", body.length));
+				logger.info("Wrote resource", field("path", fullPath), field("content-length", body.length));
 				res.status(200);
 				res.end();
 			});

packages/server/src/vscode/bootstrapFork.ts

@@ -1,7 +1,9 @@
 import * as cp from "child_process";
 import * as fs from "fs";
+import * as os from "os";
 import * as path from "path";
 import * as vm from "vm";
+import { logger } from "@coder/logger";
 import { buildDir, isCli } from "../constants";
 
 let ipcMsgBuffer: Buffer[] | undefined = [];
@@ -151,6 +153,13 @@ export const forkModule = (modulePath: string, args?: string[], options?: cp.For
 	} else {
 		proc = cp.spawn(process.execPath, ["--require", "ts-node/register", "--require", "tsconfig-paths/register", process.argv[1], ...forkArgs], forkOptions);
 	}
+	if (args && args[0] === "--type=watcherService" && os.platform() === "linux") {
+		cp.exec(`renice -n 19 -p ${proc.pid}`, (error) => {
+			if (error) {
+				logger.warn(error.message);
+			}
+		});
+	}
 
 	return proc;
 };

packages/server/src/vscode/sharedProcess.ts

@@ -1,5 +1,6 @@
 import { ChildProcess } from "child_process";
 import * as fs from "fs";
+import * as fse from "fs-extra";
 import * as os from "os";
 import * as path from "path";
 import { forkModule } from "./bootstrapFork";
@@ -7,7 +8,7 @@ import { StdioIpcHandler } from "../ipc";
 import { ParsedArgs } from "vs/platform/environment/common/environment";
 import { Emitter } from "@coder/events/src";
 import { retry } from "@coder/ide/src/retry";
-import { logger, field, Level } from "@coder/logger";
+import { logger, Level } from "@coder/logger";
 
 export enum SharedProcessState {
 	Stopped,
@@ -23,123 +24,148 @@ export type SharedProcessEvent = {
 };
 
 export class SharedProcess {
-	public readonly socketPath: string = os.platform() === "win32" ? path.join("\\\\?\\pipe", os.tmpdir(), `.code-server${Math.random().toString()}`) : path.join(os.tmpdir(), `.code-server${Math.random().toString()}`);
+	public readonly socketPath: string = os.platform() === "win32"
+		? path.join("\\\\?\\pipe", os.tmpdir(), `.code-server${Math.random().toString()}`)
+		: path.join(os.tmpdir(), `.code-server${Math.random().toString()}`);
 	private _state: SharedProcessState = SharedProcessState.Stopped;
 	private activeProcess: ChildProcess | undefined;
 	private ipcHandler: StdioIpcHandler | undefined;
 	private readonly onStateEmitter = new Emitter<SharedProcessEvent>();
 	public readonly onState = this.onStateEmitter.event;
-	private readonly retryName = "Shared process";
 	private readonly logger = logger.named("shared");
+	private readonly retry = retry.register("Shared process", () => this.connect());
+	private disposed: boolean = false;
 
 	public constructor(
 		private readonly userDataDir: string,
+		private readonly extensionsDir: string,
 		private readonly builtInExtensionsDir: string,
 	) {
-		retry.register(this.retryName, () => this.restart());
+		this.retry.run();
-		retry.run(this.retryName);
 	}
 
 	public get state(): SharedProcessState {
 		return this._state;
 	}
 
-	public restart(): void {
+	/**
-		if (this.activeProcess && !this.activeProcess.killed) {
+	 * Signal the shared process to terminate.
-			this.activeProcess.kill();
+	 */
-		}
-
-		const extensionsDir = path.join(this.userDataDir, "extensions");
-		const mkdir = (dir: string): void => {
-			try {
-				fs.mkdirSync(dir);
-			} catch (ex) {
-				if (ex.code !== "EEXIST" && ex.code !== "EISDIR") {
-					throw ex;
-				}
-			}
-		};
-		mkdir(this.userDataDir);
-		mkdir(extensionsDir);
-
-		this.setState({
-			state: SharedProcessState.Starting,
-		});
-		let resolved: boolean = false;
-		const maybeStop = (error: string): void => {
-			if (resolved) {
-				return;
-			}
-			this.setState({
-				error,
-				state: SharedProcessState.Stopped,
-			});
-			if (!this.activeProcess) {
-				return;
-			}
-			this.activeProcess.kill();
-		};
-		this.activeProcess = forkModule("vs/code/electron-browser/sharedProcess/sharedProcessMain", [], {
-			env: {
-				VSCODE_ALLOW_IO: "true",
-				VSCODE_LOGS: process.env.VSCODE_LOGS,
-			},
-		}, this.userDataDir);
-		if (this.logger.level <= Level.Trace) {
-			this.activeProcess.stdout.on("data", (data) => {
-				this.logger.trace(() => ["stdout", field("data", data.toString())]);
-			});
-		}
-		this.activeProcess.on("error", (error) => {
-			this.logger.error("error", field("error", error));
-			maybeStop(error.message);
-		});
-		this.activeProcess.on("exit", (err) => {
-			if (this._state !== SharedProcessState.Stopped) {
-				this.setState({
-					error: `Exited with ${err}`,
-					state: SharedProcessState.Stopped,
-				});
-			}
-			retry.run(this.retryName, new Error(`Exited with ${err}`));
-		});
-		this.ipcHandler = new StdioIpcHandler(this.activeProcess);
-		this.ipcHandler.once("handshake:hello", () => {
-			const data: {
-				sharedIPCHandle: string;
-				args: Partial<ParsedArgs>;
-				logLevel: Level;
-			} = {
-				args: {
-					"builtin-extensions-dir": this.builtInExtensionsDir,
-					"user-data-dir": this.userDataDir,
-					"extensions-dir": extensionsDir,
-				},
-				logLevel: this.logger.level,
-				sharedIPCHandle: this.socketPath,
-			};
-			this.ipcHandler!.send("handshake:hey there", "", data);
-		});
-		this.ipcHandler.once("handshake:im ready", () => {
-			resolved = true;
-			retry.recover(this.retryName);
-			this.setState({
-				state: SharedProcessState.Ready,
-			});
-		});
-		this.activeProcess.stderr.on("data", (data) => {
-			this.logger.error("stderr", field("data", data.toString()));
-			maybeStop(data.toString());
-		});
-	}
-
 	public dispose(): void {
+		this.disposed = true;
 		if (this.ipcHandler) {
 			this.ipcHandler.send("handshake:goodbye");
 		}
 		this.ipcHandler = undefined;
 	}
 
+	/**
+	 * Start and connect to the shared process.
+	 */
+	private async connect(): Promise<void> {
+		this.setState({ state: SharedProcessState.Starting });
+		const activeProcess = await this.restart();
+
+		activeProcess.on("exit", (exitCode) => {
+			const error = new Error(`Exited with ${exitCode}`);
+			this.setState({
+				error: error.message,
+				state: SharedProcessState.Stopped,
+			});
+			if (!this.disposed) {
+				this.retry.run(error);
+			}
+		});
+
+		this.setState({ state: SharedProcessState.Ready });
+	}
+
+	/**
+	 * Restart the shared process. Kill existing process if running. Resolve when
+	 * the shared process is ready and reject when it errors or dies before being
+	 * ready.
+	 */
+	private async restart(): Promise<ChildProcess> {
+		if (this.activeProcess && !this.activeProcess.killed) {
+			this.activeProcess.kill();
+		}
+
+		const backupsDir = path.join(this.userDataDir, "Backups");
+		await Promise.all([
+			fse.mkdirp(backupsDir),
+		]);
+
+		const workspacesFile = path.join(backupsDir, "workspaces.json");
+		if (!fs.existsSync(workspacesFile)) {
+			fs.appendFileSync(workspacesFile, "");
+		}
+
+		const activeProcess = forkModule("vs/code/electron-browser/sharedProcess/sharedProcessMain", [], {
+			env: {
+				VSCODE_ALLOW_IO: "true",
+				VSCODE_LOGS: process.env.VSCODE_LOGS,
+			},
+		}, this.userDataDir);
+		this.activeProcess = activeProcess;
+
+		await new Promise((resolve, reject): void => {
+			const doReject = (error: Error | number | null): void => {
+				if (error === null) {
+					error = new Error("Exited unexpectedly");
+				} else if (typeof error === "number") {
+					error = new Error(`Exited with ${error}`);
+				}
+				activeProcess.removeAllListeners();
+				this.setState({
+					error: error.message,
+					state: SharedProcessState.Stopped,
+				});
+				reject(error);
+			};
+
+			activeProcess.on("error", doReject);
+			activeProcess.on("exit", doReject);
+
+			activeProcess.stdout.on("data", (data) => {
+				logger.trace(data.toString());
+			});
+
+			activeProcess.stderr.on("data", (data) => {
+				// Warn instead of error to prevent panic. It's unlikely stderr here is
+				// about anything critical to the functioning of the editor.
+				logger.warn(data.toString());
+			});
+
+			this.ipcHandler = new StdioIpcHandler(activeProcess);
+			this.ipcHandler.once("handshake:hello", () => {
+				const data: {
+					sharedIPCHandle: string;
+					args: Partial<ParsedArgs>;
+					logLevel: Level;
+				} = {
+					args: {
+						"builtin-extensions-dir": this.builtInExtensionsDir,
+						"user-data-dir": this.userDataDir,
+						"extensions-dir": this.extensionsDir,
+					},
+					logLevel: this.logger.level,
+					sharedIPCHandle: this.socketPath,
+				};
+				this.ipcHandler!.send("handshake:hey there", "", data);
+			});
+			this.ipcHandler.once("handshake:im ready", () => {
+				activeProcess.removeListener("error", doReject);
+				activeProcess.removeListener("exit", doReject);
+				resolve();
+			});
+		});
+
+		return activeProcess;
+	}
+
+	/**
+	 * Set the internal shared process state and emit the state event.
+	 */
 	private setState(event: SharedProcessEvent): void {
 		this._state = event.state;
 		this.onStateEmitter.emit(event);

packages/server/yarn.lock

@@ -7,10 +7,10 @@
   resolved "https://registry.yarnpkg.com/@coder/logger/-/logger-1.0.3.tgz#e0e1ae5496fde5a3c6ef3d748fdfb26a55add8b8"
   integrity sha512-1o5qDZX2VZUNnzgz5KfAdMnaqaX6FNeTs0dUdg73MRHfQW94tFTIryFC1xTTCuzxGDjVHOHkaUAI4uHA2bheOA==
 
-"@coder/nbin@^1.0.4":
+"@coder/nbin@^1.0.7":
-  version "1.0.4"
+  version "1.0.7"
-  resolved "https://registry.yarnpkg.com/@coder/nbin/-/nbin-1.0.4.tgz#13a3d110fe116ed5d5fdbd1384f0335745dfd859"
+  resolved "https://registry.yarnpkg.com/@coder/nbin/-/nbin-1.0.7.tgz#fc6adeb8366bf9d7dc7c301ce0be9e741eccf14b"
-  integrity sha512-mtd5hzPHWBwKpTCYdJdLdiY4CFCEb8HUtv3NgH8SSLFiPDwY7H1UlpqeamIty27NZ+9NLnrBd/DfaE3aVo7rxQ==
+  integrity sha512-HkCFJnYyFuPaAjk6O8IcafEEBYlHG63SqxgwB0QSyUGwjq/hUekgB23BnKmywbcxNIuX26b9j2AGWt/DBdJlXA==
   dependencies:
     "@coder/logger" "^1.0.3"
     fs-extra "^7.0.1"

packages/vscode/src/dialog.scss

@@ -2,6 +2,7 @@
 	--primary: #2A2E37;
 	--border: black;
 	--faded: #a0a1a5;
+	--disabled: #888;
 	--header-background: #161616;
 	--header-foreground: white;
 	--list-active-selection-background: rgb(0, 120, 160);
@@ -101,6 +102,12 @@
 				background-color: var(--list-active-selection-background);
 				color: var(--list-active-selection-foreground);
 			}
+
+			&.disabled, &.disabled:hover {
+				background-color: var(--primary);
+				color: var(--disabled);
+				cursor: initial;
+			}
 		}
 	}
 
@@ -134,6 +141,11 @@
 				color: white;
 			}
 		}
+
+		button[disabled], button[disabled]:hover {
+			color: var(--disabled);
+			cursor: initial;
+		}
 	}
 }
 

packages/vscode/src/dialog.ts

@@ -16,6 +16,9 @@ import { IThemeService } from "vs/platform/theme/common/themeService";
 import { workbench } from "./workbench";
 import "./dialog.scss";
 
+/**
+ * Describes the type of dialog to show.
+ */
 export enum DialogType {
 	NewFolder,
 	Save,
@@ -68,8 +71,12 @@ interface DialogEntry {
 	readonly isDirectory: boolean;
 	readonly size: number;
 	readonly lastModified: string;
+	readonly isDisabled?: boolean;
 }
 
+/**
+ * Open and save dialogs.
+ */
 class Dialog {
 	private _path: string | undefined;
 
@@ -108,7 +115,7 @@ class Dialog {
 		this.root.style.width = "850px";
 		this.root.style.height = "600px";
 		this.background.appendChild(this.root);
-		(document.getElementById("workbench.main.container") || document.body).appendChild(this.background);
+		(document.querySelector(".monaco-workbench") || document.body).appendChild(this.background);
 		this.root.classList.add("dialog");
 
 		const setProperty = (vari: string, id: string): void => {
@@ -265,8 +272,7 @@ class Dialog {
 			}
 			if (element.isDirectory) {
 				this.path = element.fullPath;
-			} else {
+			} else if (!(this.options as OpenDialogOptions).properties.openDirectory) {
-				// Open
 				this.selectEmitter.emit(element.fullPath);
 			}
 		});
@@ -282,12 +288,18 @@ class Dialog {
 		});
 		buttonsNode.appendChild(cancelBtn);
 		const confirmBtn = document.createElement("button");
-		confirmBtn.innerText = "Confirm";
+		const openFile = (this.options as OpenDialogOptions).properties.openFile;
+		confirmBtn.innerText = openFile ? "Open" : "Confirm";
 		confirmBtn.addEventListener("click", () => {
-			if (this._path) {
+			if (this._path && !openFile) {
 				this.selectEmitter.emit(this._path);
 			}
 		});
+		// Since a single click opens a file, the only time this button can be
+		// used is on a directory, which is invalid for opening files.
+		if (openFile) {
+			confirmBtn.disabled = true;
+		}
 		buttonsNode.appendChild(confirmBtn);
 		this.root.appendChild(buttonsNode);
 		this.entryList.layout();
@@ -303,6 +315,9 @@ class Dialog {
 		return this.errorEmitter.event;
 	}
 
+	/**
+	 * Remove the dialog.
+	 */
 	public dispose(): void {
 		this.selectEmitter.dispose();
 		this.errorEmitter.dispose();
@@ -310,6 +325,9 @@ class Dialog {
 		this.background.remove();
 	}
 
+	/**
+	 * Build and insert the path shown at the top of the dialog.
+	 */
 	private buildPath(): void {
 		while (this.pathNode.lastChild) {
 			this.pathNode.removeChild(this.pathNode.lastChild);
@@ -376,6 +394,9 @@ class Dialog {
 		return (<any>this.entryList).typeFilterController.filter._pattern;
 	}
 
+	/**
+	 * List the files and return dialog entries.
+	 */
 	private async list(directory: string): Promise<ReadonlyArray<DialogEntry>> {
 		const paths = (await util.promisify(fs.readdir)(directory)).sort();
 		const stats = await Promise.all(paths.map(p => util.promisify(fs.stat)(path.join(directory, p))));
@@ -386,6 +407,8 @@ class Dialog {
 			isDirectory: stat.isDirectory(),
 			lastModified: stat.mtime.toDateString(),
 			size: stat.size,
+			// If we are opening a directory, show files as disabled.
+			isDisabled: !stat.isDirectory() && (this.options as OpenDialogOptions).properties.openDirectory,
 		}));
 	}
 }
@@ -397,11 +420,17 @@ interface DialogEntryData {
 	label: HighlightedLabel;
 }
 
+/**
+ * Rendering for the different parts of a dialog entry.
+ */
 class DialogEntryRenderer implements ITreeRenderer<DialogEntry, string, DialogEntryData> {
 	public get templateId(): string {
 		return "dialog-entry";
 	}
 
+	/**
+	 * Append and return containers for each part of the dialog entry.
+	 */
 	public renderTemplate(container: HTMLElement): DialogEntryData {
 		addClass(container, "dialog-entry");
 		addClass(container, "dialog-grid");
@@ -422,6 +451,9 @@ class DialogEntryRenderer implements ITreeRenderer<DialogEntry, string, DialogEn
 		};
 	}
 
+	/**
+	 * Render a dialog entry.
+	 */
 	public renderElement(node: ITreeNode<DialogEntry, string>, _index: number, templateData: DialogEntryData): void {
 		templateData.icon.className = "dialog-entry-icon monaco-icon-label";
 		const classes = getIconClasses(
@@ -444,8 +476,19 @@ class DialogEntryRenderer implements ITreeRenderer<DialogEntry, string, DialogEn
 		}] : []);
 		templateData.size.innerText = node.element.size.toString();
 		templateData.lastModified.innerText = node.element.lastModified;
+
+		// We know this exists because we created the template.
+		const entryContainer = templateData.label.element.parentElement!.parentElement!.parentElement!;
+		if (node.element.isDisabled) {
+			entryContainer.classList.add("disabled");
+		} else {
+			entryContainer.classList.remove("disabled");
+		}
 	}
 
+	/**
+	 * Does nothing (not implemented).
+	 */
 	public disposeTemplate(_templateData: DialogEntryData): void {
 		// throw new Error("Method not implemented.");
 	}

packages/vscode/src/fill/environmentService.ts

@@ -8,7 +8,7 @@ export class EnvironmentService extends environment.EnvironmentService {
 	}
 
 	public get extensionsPath(): string {
-		return path.join(paths.getAppDataPath(), "extensions");
+		return paths.getExtensionsDirectory();
 	}
 }
 

packages/vscode/src/fill/menuRegistry.ts

@@ -1,19 +1,36 @@
-import { logger } from "@coder/logger";
 import { IDisposable } from "vs/base/common/lifecycle";
 import * as actions from "vs/platform/actions/common/actions";
+import { CloseWorkspaceAction } from "vs/workbench/browser/actions/workspaceActions";
+import { OpenProcessExplorer } from "vs/workbench/contrib/issue/electron-browser/issueActions";
 import { ToggleDevToolsAction } from "vs/workbench/electron-browser/actions/developerActions";
+import { OpenPrivacyStatementUrlAction, OpenRequestFeatureUrlAction, OpenTwitterUrlAction } from "vs/workbench/electron-browser/actions/helpActions";
+import { CloseCurrentWindowAction, NewWindowAction, ShowAboutDialogAction } from "vs/workbench/electron-browser/actions/windowActions";
+
+const toSkip = [
+	ToggleDevToolsAction.ID,
+	OpenTwitterUrlAction.ID,
+	OpenPrivacyStatementUrlAction.ID,
+	ShowAboutDialogAction.ID,
+	OpenProcessExplorer.ID,
+	OpenRequestFeatureUrlAction.ID,
+	NewWindowAction.ID,
+	CloseCurrentWindowAction.ID,
+	CloseWorkspaceAction.ID,
+
+	// Unfortunately referenced as a string
+	"update.showCurrentReleaseNotes",
+	"workbench.action.openIssueReporter",
+];
 
 // Intercept appending menu items so we can skip items that won't work.
 const originalAppend = actions.MenuRegistry.appendMenuItem.bind(actions.MenuRegistry);
 actions.MenuRegistry.appendMenuItem = (id: actions.MenuId, item: actions.IMenuItem | actions.ISubmenuItem): IDisposable => {
 	if (actions.isIMenuItem(item)) {
-		switch (item.command.id) {
+		if (toSkip.indexOf(item.command.id) !== -1) {
-			case ToggleDevToolsAction.ID: // There appears to be no way to toggle this programmatically.
+			// Skip instantiation
-				logger.debug(`Skipping unsupported menu item ${item.command.id}`);
+			return {
-
+				dispose: (): void => undefined,
-				return {
+			};
-					dispose: (): void => undefined,
-				};
 		}
 	}
 

packages/vscode/src/fill/paste.ts

@@ -2,8 +2,8 @@ import * as nls from "vs/nls";
 import { Action } from "vs/base/common/actions";
 import { TERMINAL_COMMAND_ID } from "vs/workbench/contrib/terminal/common/terminalCommands";
 import { ITerminalService } from "vs/workbench/contrib/terminal/common/terminal";
-import * as actions from "vs/workbench/contrib/terminal/electron-browser/terminalActions";
+import * as actions from "vs/workbench/contrib/terminal/browser/terminalActions";
-import * as instance from "vs/workbench/contrib/terminal/electron-browser/terminalInstance";
+import * as instance from "vs/workbench/contrib/terminal/browser/terminalInstance";
 import { client } from "../client";
 
 const getLabel = (key: string, enabled: boolean): string => {

packages/vscode/src/fill/paths.ts

@@ -4,6 +4,7 @@ class Paths {
 	private _appData: string | undefined;
 	private _defaultUserData: string | undefined;
 	private _socketPath: string | undefined;
+	private _extensionsDirectory: string | undefined;
 	private _builtInExtensionsDirectory: string | undefined;
 	private _workingDirectory: string | undefined;
 
@@ -31,6 +32,14 @@ class Paths {
 		return this._socketPath;
 	}
 
+	public get extensionsDirectory(): string {
+		if (!this._extensionsDirectory) {
+			throw new Error("trying to access extensions directory before it has been set");
+		}
+
+		return this._extensionsDirectory;
+	}
+
 	public get builtInExtensionsDirectory(): string {
 		if (!this._builtInExtensionsDirectory) {
 			throw new Error("trying to access builtin extensions directory before it has been set");
@@ -52,6 +61,7 @@ class Paths {
 		this._appData = data.dataDirectory;
 		this._defaultUserData = data.dataDirectory;
 		this._socketPath = sharedData.socketPath;
+		this._extensionsDirectory = data.extensionsDirectory;
 		this._builtInExtensionsDirectory = data.builtInExtensionsDirectory;
 		this._workingDirectory = data.workingDirectory;
 	}
@@ -61,5 +71,6 @@ export const _paths = new Paths();
 export const getAppDataPath = (): string => _paths.appData;
 export const getDefaultUserDataPath = (): string => _paths.defaultUserData;
 export const getWorkingDirectory = (): string => _paths.workingDirectory;
+export const getExtensionsDirectory = (): string => _paths.extensionsDirectory;
 export const getBuiltInExtensionsDirectory = (): string => _paths.builtInExtensionsDirectory;
 export const getSocketPath = (): string => _paths.socketPath;

packages/vscode/src/fill/product.ts

@@ -4,6 +4,14 @@ import { IProductConfiguration } from "vs/platform/product/node/product";
 class Product implements IProductConfiguration {
 	public nameShort = "code-server";
 	public nameLong = "code-server";
+	public documentationUrl = "https://code.visualstudio.com/docs";
+	public keyboardShortcutsUrlMac = "https://code.visualstudio.com/shortcuts/keyboard-shortcuts-macos.pdf";
+	public keyboardShortcutsUrlLinux = "https://code.visualstudio.com/shortcuts/keyboard-shortcuts-linux.pdf";
+	public keyboardShortcutsUrlWin = "https://code.visualstudio.com/shortcuts/keyboard-shortcuts-windows.pdf";
+	public introductoryVideosUrl = "https://code.visualstudio.com/docs/getstarted/introvideos";
+	public tipsAndTricksUrl = "https://code.visualstudio.com/docs/getstarted/tips-and-tricks";
+	public twitterUrl = "https://twitter.com/code";
+	public licenseUrl = "https://github.com/codercom/code-server/blob/master/LICENSE";
 
 	private _dataFolderName: string | undefined;
 	public get dataFolderName(): string {

packages/vscode/src/fill/storageDatabase.ts

@@ -11,6 +11,8 @@ import { IStorageService, WillSaveStateReason } from "vs/platform/storage/common
 import * as paths from "./paths";
 import { workbench } from "../workbench";
 
+// tslint:disable completed-docs
+
 class StorageDatabase implements workspaceStorage.IStorageDatabase {
 	public readonly onDidChangeItemsExternal = Event.None;
 	private readonly items = new Map<string, string>();
@@ -26,7 +28,8 @@ class StorageDatabase implements workspaceStorage.IStorageDatabase {
 			}
 
 			this.triggerFlush(WillSaveStateReason.SHUTDOWN);
-			navigator.sendBeacon(`/resource${this.path}`, this.content);
+			const resourceBaseUrl = location.pathname.replace(/\/$/, "") + "/resource";
+			navigator.sendBeacon(`${resourceBaseUrl}/${this.path}`, this.content);
 		});
 	}
 

packages/vscode/src/fill/windowsService.ts

@@ -1,21 +1,32 @@
 import * as electron from "electron";
 import { Emitter } from "@coder/events";
-import * as windowsIpc from "vs/platform/windows/node/windowsIpc";
+import { logger } from "@coder/logger";
-import { IWindowsService, INativeOpenDialogOptions, MessageBoxOptions, SaveDialogOptions, OpenDialogOptions, IMessageBoxResult, IDevToolsOptions, IEnterWorkspaceResult, CrashReporterStartOptions, INewWindowOptions, IOpenFileRequest, IAddFoldersRequest } from "vs/platform/windows/common/windows";
+import { IWindowsService, INativeOpenDialogOptions, MessageBoxOptions, SaveDialogOptions, OpenDialogOptions, IMessageBoxResult, IDevToolsOptions, IEnterWorkspaceResult, CrashReporterStartOptions, INewWindowOptions, IOpenFileRequest, IAddFoldersRequest, IURIToOpen, IOpenSettings } from "vs/platform/windows/common/windows";
 import { ParsedArgs } from "vs/platform/environment/common/environment";
 import { IWorkspaceIdentifier, IWorkspaceFolderCreationData, ISingleFolderWorkspaceIdentifier } from "vs/platform/workspaces/common/workspaces";
 import { URI } from "vs/base/common/uri";
-import { IRecentlyOpened } from "vs/platform/history/common/history";
+import { IRecentlyOpened, IRecent } from "vs/platform/history/common/history";
 import { ISerializableCommandAction } from "vs/platform/actions/common/actions";
 import { client } from "../client";
 import { showOpenDialog } from "../dialog";
 import { workbench } from "../workbench";
 
+// tslint:disable completed-docs
+
+// VS Code overrides window.open to call openExternal, but we then call
+// window.open which results in an infinite loop. Store the function but also
+// make it unable to be set (doesn't work otherwise).
+const windowOpen = window.open;
+Object.defineProperty(window, "open", {
+	set: (): void => { /* Not allowed. */ },
+	get: (): Function => windowOpen,
+});
+
 /**
  * Instead of going to the shared process, we'll directly run these methods on
  * the client. This setup means we can only control the current window.
  */
-class WindowsService implements IWindowsService {
+export class WindowsService implements IWindowsService {
 	// tslint:disable-next-line no-any
 	public _serviceBrand: any;
 
@@ -36,9 +47,9 @@ class WindowsService implements IWindowsService {
 	private readonly window = new electron.BrowserWindow();
 
 	// Dialogs
-	public async pickFileFolderAndOpen(_options: INativeOpenDialogOptions): Promise<void> {
+	public async pickFileFolderAndOpen(options: INativeOpenDialogOptions): Promise<void> {
 		showOpenDialog({
-			...(_options.dialogOptions || {}),
+			...(options.dialogOptions || {}),
 			properties: {
 				openFile: true,
 				openDirectory: true,
@@ -51,13 +62,13 @@ class WindowsService implements IWindowsService {
 				}],
 			} as IOpenFileRequest);
 		}).catch((ex) => {
-			//
+			logger.error(ex.message);
 		});
 	}
 
-	public async pickFileAndOpen(_options: INativeOpenDialogOptions): Promise<void> {
+	public async pickFileAndOpen(options: INativeOpenDialogOptions): Promise<void> {
 		showOpenDialog({
-			...(_options.dialogOptions || {}),
+			...(options.dialogOptions || {}),
 			properties: {
 				openFile: true,
 			},
@@ -69,26 +80,32 @@ class WindowsService implements IWindowsService {
 				}],
 			} as IOpenFileRequest);
 		}).catch((ex) => {
-			//
+			logger.error(ex.message);
 		});
 	}
 
-	public async pickFolderAndOpen(_options: INativeOpenDialogOptions): Promise<void> {
+	public async pickFolderAndOpen(options: INativeOpenDialogOptions): Promise<void> {
+		if (!options.dialogOptions) {
+			options.dialogOptions = {};
+		}
+		if (!options.dialogOptions.title) {
+			options.dialogOptions.title = "Open Folder";
+		}
 		showOpenDialog({
-			...(_options.dialogOptions || {}),
+			...(options.dialogOptions || {}),
 			properties: {
 				openDirectory: true,
 			},
 		}).then((path) => {
 			workbench.workspace = URI.file(path);
 		}).catch((ex) => {
-			//
+			logger.error(ex.message);
 		});
 	}
 
-	public async pickWorkspaceAndOpen(_options: INativeOpenDialogOptions): Promise<void> {
+	public async pickWorkspaceAndOpen(options: INativeOpenDialogOptions): Promise<void> {
 		showOpenDialog({
-			...(_options.dialogOptions || {}),
+			...(options.dialogOptions || {}),
 			properties: {
 				openDirectory: true,
 			},
@@ -98,7 +115,7 @@ class WindowsService implements IWindowsService {
 				foldersToAdd: [URI.file(path)],
 			} as IAddFoldersRequest);
 		}).catch((ex) => {
-			//
+			logger.error(ex.message);
 		});
 	}
 
@@ -121,16 +138,14 @@ class WindowsService implements IWindowsService {
 		});
 	}
 
-	public showOpenDialog(windowId: number, options: OpenDialogOptions): Promise<string[]> {
+	public async showOpenDialog(_windowId: number, options: OpenDialogOptions): Promise<string[]> {
-		return showOpenDialog({
+		return [await showOpenDialog({
 			...(options || {}),
 			properties: {
 				openDirectory: true,
 				openFile: true,
 			},
-		}).then((path) => {
+		})];
-			return [path];
-		});
 	}
 
 	public reloadWindow(windowId: number, _args?: ParsedArgs): Promise<void> {
@@ -149,14 +164,14 @@ class WindowsService implements IWindowsService {
 		throw new Error("not implemented");
 	}
 
-	public enterWorkspace(_windowId: number, _path: URI): Promise<IEnterWorkspaceResult> {
+	public enterWorkspace(_windowId: number, uri: URI): Promise<IEnterWorkspaceResult> {
-		if (_path.path.endsWith(".json")) {
+		if (uri.path.endsWith(".json")) {
 			workbench.workspace = {
 				id: "Untitled",
-				configPath: _path.path,
+				configPath: uri,
 			};
 		} else {
-			workbench.workspace = _path;
+			workbench.workspace = uri;
 		}
 
 		return undefined!;
@@ -180,7 +195,7 @@ class WindowsService implements IWindowsService {
 		return Promise.resolve(this.getWindowById(windowId).setRepresentedFilename(fileName));
 	}
 
-	public addRecentlyOpened(_files: URI[]): Promise<void> {
+	public addRecentlyOpened(_files: IRecent[]): Promise<void> {
 		throw new Error("not implemented");
 	}
 
@@ -284,7 +299,7 @@ class WindowsService implements IWindowsService {
 	}
 
 	// Global methods
-	public openWindow(_windowId: number, _paths: URI[], _options?: { forceNewWindow?: boolean, forceReuseWindow?: boolean, forceOpenWorkspaceAsFile?: boolean, args?: ParsedArgs }): Promise<void> {
+	public openWindow(_windowId: number, _uris: IURIToOpen[], _options?: IOpenSettings): Promise<void> {
 		throw new Error("not implemented");
 	}
 
@@ -308,8 +323,8 @@ class WindowsService implements IWindowsService {
 		throw new Error("not implemented");
 	}
 
-	public async showItemInFolder(_path: string): Promise<void> {
+	public async showItemInFolder(uri: URI): Promise<void> {
-		workbench.workspace = URI.file(_path);
+		workbench.workspace = uri;
 	}
 
 	public getActiveWindowId(): Promise<number | undefined> {
@@ -343,7 +358,3 @@ class WindowsService implements IWindowsService {
 		return this.window;
 	}
 }
-
-const target = windowsIpc as typeof windowsIpc;
-// @ts-ignore TODO: don't ignore it.
-target.WindowsChannelClient = WindowsService;

packages/vscode/src/fill/workbenchRegistry.ts

@@ -5,7 +5,7 @@ import { IWorkbenchActionRegistry, Extensions } from "vs/workbench/common/action
 import { SyncActionDescriptor } from "vs/platform/actions/common/actions";
 import { ContextKeyExpr } from "vs/platform/contextkey/common/contextkey";
 import { ToggleDevToolsAction } from "vs/workbench/electron-browser/actions/developerActions";
-import { TerminalPasteAction } from "vs/workbench/contrib/terminal/electron-browser/terminalActions";
+import { TerminalPasteAction } from "vs/workbench/contrib/terminal/browser/terminalActions";
 import { KEYBINDING_CONTEXT_TERMINAL_FOCUS } from "vs/workbench/contrib/terminal/common/terminal";
 import { KeyCode, KeyMod } from "vs/base/common/keyCodes";
 import { workbench } from "../workbench";

packages/vscode/src/workbench.ts

@@ -1,5 +1,6 @@
 import * as os from "os";
 import { IProgress, INotificationHandle } from "@coder/ide";
+import { logger } from "@coder/logger";
 import { client } from "./client";
 
 import "./fill/platform";
@@ -29,11 +30,20 @@ import { RawContextKey, IContextKeyService } from "vs/platform/contextkey/common
 import { ServiceCollection } from "vs/platform/instantiation/common/serviceCollection";
 import { URI } from "vs/base/common/uri";
 
+/**
+ * Initializes VS Code and provides a way to call into general client
+ * functionality.
+ */
 export class Workbench {
+	public readonly retry = client.retry;
+
 	private readonly windowId = parseInt(new Date().toISOString().replace(/[-:.TZ]/g, ""), 10);
 	private _serviceCollection: ServiceCollection | undefined;
 	private _clipboardContextKey: RawContextKey<boolean> | undefined;
 
+	/**
+	 * Handle a drop event on the file explorer.
+	 */
 	public async handleExternalDrop(target: ExplorerItem | ExplorerModel, originalEvent: DragEvent): Promise<void> {
 		await client.upload.uploadDropped(
 			originalEvent,
@@ -41,11 +51,14 @@ export class Workbench {
 		);
 	}
 
+	/**
+	 * Handle a drop event on the editor.
+	 */
 	public handleDrop(event: DragEvent, resolveTargetGroup: () => IEditorGroup, afterDrop: (targetGroup: IEditorGroup) => void, targetIndex?: number): void {
-		client.upload.uploadDropped(event, URI.file(paths.getWorkingDirectory())).then((paths) => {
+		client.upload.uploadDropped(event, URI.file(paths.getWorkingDirectory())).then(async (paths) => {
 			const uris = paths.map((p) => URI.file(p));
 			if (uris.length) {
-				(this.serviceCollection.get(IWindowsService) as IWindowsService).addRecentlyOpened(uris);
+				await (this.serviceCollection.get(IWindowsService) as IWindowsService).addRecentlyOpened(uris);
 			}
 
 			const editors: IResourceEditor[] = uris.map(uri => ({
@@ -57,10 +70,10 @@ export class Workbench {
 			}));
 
 			const targetGroup = resolveTargetGroup();
-
+			await (this.serviceCollection.get(IEditorService) as IEditorService).openEditors(editors, targetGroup);
-			(this.serviceCollection.get(IEditorService) as IEditorService).openEditors(editors, targetGroup).then(() => {
+			afterDrop(targetGroup);
-				afterDrop(targetGroup);
+		}).catch((error) => {
-			});
+			logger.error(error.message);
 		});
 	}
 
@@ -115,6 +128,14 @@ export class Workbench {
 
 	public set serviceCollection(collection: ServiceCollection) {
 		this._serviceCollection = collection;
+
+		const contextKeys = this.serviceCollection.get(IContextKeyService) as IContextKeyService;
+		const bounded = this.clipboardContextKey.bindTo(contextKeys);
+		client.clipboard.onPermissionChange((enabled) => {
+			bounded.set(enabled);
+		});
+		client.clipboard.initialize();
+
 		client.progressService = {
 			start: <T>(title: string, task: (progress: IProgress) => Promise<T>, onCancel: () => void): Promise<T> => {
 				let lastProgress = 0;
@@ -164,6 +185,9 @@ export class Workbench {
 		};
 	}
 
+	/**
+	 * Start VS Code.
+	 */
 	public async initialize(): Promise<void> {
 		this._clipboardContextKey = new RawContextKey("nativeClipboard", client.clipboard.isEnabled);
 
@@ -210,12 +234,6 @@ export class Workbench {
 				return;
 			}
 		}
-		const contextKeys = this.serviceCollection.get(IContextKeyService) as IContextKeyService;
-		const bounded = this.clipboardContextKey.bindTo(contextKeys);
-		client.clipboard.onPermissionChange((enabled) => {
-			bounded.set(enabled);
-		});
-		client.clipboard.initialize();
 	}
 }
 

packages/vscode/webpack.bootstrap.config.js

@@ -36,7 +36,8 @@ module.exports = merge(
 					loader: "ignore-loader",
 				}],
 			}, {
-				test: /((\\|\/)vs(\\|\/)code(\\|\/)electron-main(\\|\/))|((\\|\/)test(\\|\/))|(OSSREADME\.json$)|\/browser\//,
+				// The only thing we need in electron-browser is the shared process (including contrib).
+				test: /((\\|\/)vs(\\|\/)code(\\|\/)electron-main(\\|\/))|((\\|\/)test(\\|\/))|(OSSREADME\.json$)|\/browser\/|\/electron-browser\/(?!sharedProcess\/).+\//,
 				use: [{
 					loader: "ignore-loader",
 				}],
@@ -50,6 +51,7 @@ module.exports = merge(
 				"windows-mutex": path.resolve(fills, "empty.ts"),
 				"windows-process-tree": path.resolve(fills, "empty.ts"),
 				"vscode-windows-registry": path.resolve(fills, "empty.ts"),
+				"vscode-windows-ca-certs": path.resolve(fills, "empty.ts"),
 				"vscode-sqlite3": path.resolve(fills, "empty.ts"),
 				"vs/base/browser/browser": path.resolve(fills, "empty.ts"),
 

packages/web/webpack.config.js

@@ -70,6 +70,7 @@ module.exports = merge(
 			// This seems to be in the wrong place?
 			"vs/workbench/contrib/codeEditor/electron-browser/media/WordWrap_16x.svg": "vs/workbench/contrib/codeEditor/browser/suggestEnabledInput/WordWrap_16x.svg",
 
+			"vs/platform/windows/electron-browser/windowsService": path.join(vsFills, "windowsService.ts"),
 			"vs/base/node/paths": path.join(vsFills, "paths.ts"),
 			"vs/base/common/amd": path.join(vsFills, "amd.ts"),
 			"vs/platform/product/node/package": path.resolve(vsFills, "package.ts"),

scripts/vstar.sh

@@ -0,0 +1,24 @@
+#!/bin/bash
+set -euxo pipefail
+
+# Builds a tarfile containing vscode sourcefiles neccessary for CI.
+# Done outside the CI and uploaded to object storage to reduce CI time.
+
+branch=1.33.1
+dir=/tmp/vstar
+outfile=/tmp/vstar-$branch.tar.gz
+rm -rf $dir
+mkdir -p $dir
+
+cd $dir
+git clone https://github.com/microsoft/vscode --branch $branch --single-branch --depth=1
+cd vscode
+
+yarn
+
+npx gulp vscode-linux-x64 --max-old-space-size=32384
+rm -rf extensions build out* test
+cd ..
+mv *-x64/resources/app/extensions ./extensions
+rm -rf *-x64
+tar -czvf $outfile .

scripts/webpack.client.config.js

@@ -30,13 +30,16 @@ module.exports = (options = {}) => merge(
 				loader: "sass-loader",
 			}],
 		}, {
-			test: /\.(svg|png|ttf|woff|eot|woff2)$/,
+			test: /\.(png|ttf|woff|eot|woff2)$/,
 			use: [{
 				loader: "file-loader",
 				options: {
 					name: "[path][name].[ext]",
 				},
 			}],
+		}, {
+			test: /\.svg$/,
+			loader: 'url-loader'
 		}],
 	},
 	plugins: [

scripts/webpack.general.config.js

@@ -3,6 +3,7 @@ const os = require("os");
 const environment = process.env.NODE_ENV || "development";
 const HappyPack = require("happypack");
 const webpack = require("webpack");
+const TerserPlugin = require("terser-webpack-plugin");
 
 const root = path.join(__dirname, "..");
 
@@ -20,7 +21,7 @@ module.exports = (options = {}) => ({
 					// they are parsed as URIs and will throw errors if not fully formed.
 					// The !! prefix causes it to ignore other loaders (doesn't work).
 					search: "require\\.toUrl\\(",
-					replace: "location.protocol + '//' + location.host + '/' + require('!!file-loader?name=[path][name].[ext]!' + ",
+					replace: "location.protocol + '//' + location.host + location.pathname.replace(/\\/$/,'') + '/' + require('!!file-loader?name=[path][name].[ext]!' + ",
 					flags: "g",
 				}, {
 					search: "require\\.__\\$__nodeRequire",
@@ -107,6 +108,11 @@ module.exports = (options = {}) => ({
 			id: "ts",
 			threads: Math.max(os.cpus().length - 1, 1),
 			loaders: [{
+				path: "cache-loader",
+				query: {
+					cacheDirectory: path.join(__dirname, "..", ".cache"),
+				},
+			}, {
 				path: "ts-loader",
 				query: {
 					happyPackMode: true,
@@ -121,6 +127,14 @@ module.exports = (options = {}) => ({
 			"process.env.VERSION": `"${process.env.VERSION || ""}"`,
 		}),
 	],
+	optimization: {
+		minimizer: [
+			new TerserPlugin({
+				cache: path.join(__dirname, "..", ".cache", "terser"),
+				parallel: true,
+			}),
+		],
+	},
 	stats: {
 		all: false, // Fallback for options not defined.
 		errors: true,

tsconfig.json

@@ -14,7 +14,7 @@
 		"importHelpers": true,
 		"plugins": [
 			{
-				"name": "tslint-language-service"
+				"name": "typescript-tslint-plugin"
 			}
 		],
 		"paths": {

yarn.lock

@@ -24,6 +24,13 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.18.tgz#1d3ca764718915584fcd9f6344621b7672665c67"
   integrity sha512-fh+pAqt4xRzPfqA6eh3Z2y6fyZavRIumvjhaCL753+TVkGKGhpPeyrJG2JftD0T9q4GF00KjefsQ+PQNDdWQaQ==
 
+"@types/tar@^4.0.0":
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/@types/tar/-/tar-4.0.0.tgz#e3239d969eeb693a012200613860d0eb871c94f0"
+  integrity sha512-YybbEHNngcHlIWVCYsoj7Oo1JU9JqONuAlt1LlTH/lmL8BMhbzdFUgReY87a05rY1j8mfK47Del+TCkaLAXwLw==
+  dependencies:
+    "@types/node" "*"
+
 "@types/trash@^4.3.1":
   version "4.3.1"
   resolved "https://registry.yarnpkg.com/@types/trash/-/trash-4.3.1.tgz#4880ff17c4eb467f1a26774ea6328428403b5c57"
@@ -723,6 +730,17 @@ cache-base@^1.0.1:
     union-value "^1.0.0"
     unset-value "^1.0.0"
 
+cache-loader@^2.0.1:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/cache-loader/-/cache-loader-2.0.1.tgz#5758f41a62d7c23941e3c3c7016e6faeb03acb07"
+  integrity sha512-V99T3FOynmGx26Zom+JrVBytLBsmUCzVG2/4NnUKgvXN4bEV42R1ERl1IyiH/cvFIDA1Ytq2lPZ9tXDSahcQpQ==
+  dependencies:
+    loader-utils "^1.1.0"
+    mkdirp "^0.5.1"
+    neo-async "^2.6.0"
+    normalize-path "^3.0.0"
+    schema-utils "^1.0.0"
+
 camel-case@3.0.x:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/camel-case/-/camel-case-3.0.0.tgz#ca3c3688a4e9cf3a4cda777dc4dcbc713249cf73"
@@ -916,6 +934,11 @@ commander@^2.12.1, commander@^2.18.0:
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.19.0.tgz#f6198aa84e5b83c46054b94ddedbfed5ee9ff12a"
   integrity sha512-6tvAOO+D6OENvRAh524Dh9jcfKTYDQAqvqezbCW82xj5X0pSrcpxtvRKHLG0yBY6SD7PSDrJaj+0AiOcKVd1Xg==
 
+commander@^2.19.0:
+  version "2.20.0"
+  resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.0.tgz#d58bb2b5c1ee8f87b0d340027e9e94e222c5a422"
+  integrity sha512-7j2y+40w61zy6YC2iRNpUe/NwhNyoXrYpHMrSunaMG64nRnaf96zO/KMQR4OyN/UnE5KLyEBnKHd4aG3rskjpQ==
+
 commondir@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
@@ -3121,7 +3144,7 @@ mime@1.4.1:
   resolved "https://registry.yarnpkg.com/mime/-/mime-1.4.1.tgz#121f9ebc49e3766f311a76e1fa1c8003c4b03aa6"
   integrity sha512-KI1+qOZu5DcW6wayYHSzR/tXKCDC5Om4s1z2QJjDULzLcmf3DvzS7oluY4HCTrc+9FiKmWUgeNLg7W3uIQvxtQ==
 
-mime@^2.3.1:
+mime@^2.0.3, mime@^2.3.1:
   version "2.4.0"
   resolved "https://registry.yarnpkg.com/mime/-/mime-2.4.0.tgz#e051fd881358585f3279df333fe694da0bcffdd6"
   integrity sha512-ikBcWwyqXQSHKtciCcctu9YfPbFYZ4+gbHEmE0Q8jzcTYQg5dHCr3g2wwAZjPoJfQVXZq6KXAjpXOTf5/cjT7w==
@@ -3305,7 +3328,7 @@ negotiator@0.6.1:
   resolved "https://registry.yarnpkg.com/negotiator/-/negotiator-0.6.1.tgz#2b327184e8992101177b28563fb5e7102acd0ca9"
   integrity sha1-KzJxhOiZIQEXeyhWP7XnECrNDKk=
 
-neo-async@^2.5.0:
+neo-async@^2.5.0, neo-async@^2.6.0:
   version "2.6.0"
   resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.0.tgz#b9d15e4d71c6762908654b5183ed38b753340835"
   integrity sha512-MFh0d/Wa7vkKO3Y3LlacqAEeHK0mckVqzDieUKTT+KGxi+zIpeVsFxymkIiRpbpDziHc290Xr9A1O4Om7otoRA==
@@ -3452,6 +3475,11 @@ normalize-path@^2.1.1:
   dependencies:
     remove-trailing-separator "^1.0.1"
 
+normalize-path@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/normalize-path/-/normalize-path-3.0.0.tgz#0dcd69ff23a1c9b11fd0978316644a0388216a65"
+  integrity sha512-6eZs5Ls3WtCisHWp9S2GUy8dqkpGi4BVSz3GaqiE6ezub0512ESztXUwUB6C6IKbQkY2Pnb/mD4WYojCRwcwLA==
+
 npm-bundled@^1.0.1:
   version "1.0.5"
   resolved "https://registry.yarnpkg.com/npm-bundled/-/npm-bundled-1.0.5.tgz#3c1732b7ba936b3a10325aef616467c0ccbcc979"
@@ -4625,6 +4653,14 @@ source-map-support@^0.5.6, source-map-support@~0.5.6:
     buffer-from "^1.0.0"
     source-map "^0.6.0"
 
+source-map-support@~0.5.10:
+  version "0.5.11"
+  resolved "https://registry.yarnpkg.com/source-map-support/-/source-map-support-0.5.11.tgz#efac2ce0800355d026326a0ca23e162aeac9a4e2"
+  integrity sha512-//sajEx/fGL3iw6fltKMdPvy8kL3kJ2O3iuYlRoT3k9Kb4BjOoZ+BZzaNHeuaruSt+Kf3Zk9tnfAQg9/AJqUVQ==
+  dependencies:
+    buffer-from "^1.0.0"
+    source-map "^0.6.0"
+
 source-map-url@^0.4.0:
   version "0.4.0"
   resolved "https://registry.yarnpkg.com/source-map-url/-/source-map-url-0.4.0.tgz#3e935d7ddd73631b97659956d55128e87b5084a3"
@@ -4924,7 +4960,7 @@ tar@^2.0.0:
     fstream "^1.0.2"
     inherits "2"
 
-tar@^4:
+tar@^4, tar@^4.4.8:
   version "4.4.8"
   resolved "https://registry.yarnpkg.com/tar/-/tar-4.4.8.tgz#b19eec3fde2a96e64666df9fdb40c5ca1bc3747d"
   integrity sha512-LzHF64s5chPQQS0IYBn9IN5h3i98c12bo4NCO7e0sGM2llXQ3p2FGC5sdENN4cTW48O915Sh+x+EXx7XW96xYQ==
@@ -4951,6 +4987,29 @@ terser-webpack-plugin@^1.1.0:
     webpack-sources "^1.1.0"
     worker-farm "^1.5.2"
 
+terser-webpack-plugin@^1.2.3:
+  version "1.2.3"
+  resolved "https://registry.yarnpkg.com/terser-webpack-plugin/-/terser-webpack-plugin-1.2.3.tgz#3f98bc902fac3e5d0de730869f50668561262ec8"
+  integrity sha512-GOK7q85oAb/5kE12fMuLdn2btOS9OBZn4VsecpHDywoUC/jLhSAKOiYo0ezx7ss2EXPMzyEWFoE0s1WLE+4+oA==
+  dependencies:
+    cacache "^11.0.2"
+    find-cache-dir "^2.0.0"
+    schema-utils "^1.0.0"
+    serialize-javascript "^1.4.0"
+    source-map "^0.6.1"
+    terser "^3.16.1"
+    webpack-sources "^1.1.0"
+    worker-farm "^1.5.2"
+
+terser@^3.16.1:
+  version "3.17.0"
+  resolved "https://registry.yarnpkg.com/terser/-/terser-3.17.0.tgz#f88ffbeda0deb5637f9d24b0da66f4e15ab10cb2"
+  integrity sha512-/FQzzPJmCpjAH9Xvk2paiWrFq+5M6aVOf+2KRbwhByISDX/EujxsK+BAvrhb6H+2rtrLCHK9N01wO014vrIwVQ==
+  dependencies:
+    commander "^2.19.0"
+    source-map "~0.6.1"
+    source-map-support "~0.5.10"
+
 terser@^3.8.1:
   version "3.14.1"
   resolved "https://registry.yarnpkg.com/terser/-/terser-3.14.1.tgz#cc4764014af570bc79c79742358bd46926018a32"
@@ -5236,6 +5295,15 @@ urix@^0.1.0:
   resolved "https://registry.yarnpkg.com/urix/-/urix-0.1.0.tgz#da937f7a62e21fec1fd18d49b35c2935067a6c72"
   integrity sha1-2pN/emLiH+wf0Y1Js1wpNQZ6bHI=
 
+url-loader@^1.1.2:
+  version "1.1.2"
+  resolved "https://registry.yarnpkg.com/url-loader/-/url-loader-1.1.2.tgz#b971d191b83af693c5e3fea4064be9e1f2d7f8d8"
+  integrity sha512-dXHkKmw8FhPqu8asTc1puBfe3TehOCo2+RmOOev5suNCIYBcT626kxiWg1NBVkwc4rO8BGa7gP70W7VXuqHrjg==
+  dependencies:
+    loader-utils "^1.1.0"
+    mime "^2.0.3"
+    schema-utils "^1.0.0"
+
 url-parse@^1.4.3:
   version "1.4.4"
   resolved "https://registry.yarnpkg.com/url-parse/-/url-parse-1.4.4.tgz#cac1556e95faa0303691fec5cf9d5a1bc34648f8"