From 9275a814b491122ee24d8ef52c3091f70bb96769 Mon Sep 17 00:00:00 2001
From: Sambo Chea <sombochea@cubetiqs.com>
Date: Fri, 3 Jul 2020 15:01:02 +0700
Subject: [PATCH] Updated and fixed in pagination service impl

---
 ...dServiceImpl.java => AbstractPagingCrudServiceImpl.java} | 6 +++++-
 src/main/java/com/cubetiqs/data/service/CrudService.java    | 6 ++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
 rename src/main/java/com/cubetiqs/data/service/{PagingCrudServiceImpl.java => AbstractPagingCrudServiceImpl.java} (68%)

diff --git a/src/main/java/com/cubetiqs/data/service/PagingCrudServiceImpl.java b/src/main/java/com/cubetiqs/data/service/AbstractPagingCrudServiceImpl.java
similarity index 68%
rename from src/main/java/com/cubetiqs/data/service/PagingCrudServiceImpl.java
rename to src/main/java/com/cubetiqs/data/service/AbstractPagingCrudServiceImpl.java
index 8278b15..c24613b 100644
--- a/src/main/java/com/cubetiqs/data/service/PagingCrudServiceImpl.java
+++ b/src/main/java/com/cubetiqs/data/service/AbstractPagingCrudServiceImpl.java
@@ -1,9 +1,11 @@
 package com.cubetiqs.data.service;
 
+import com.cubetiqs.data.domain.BaseEntity;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.domain.Sort;
 
+import java.io.Serializable;
 import java.util.List;
 
 /**
@@ -16,7 +18,9 @@ import java.util.List;
  * @since 1.0
  */
 @NoServiceBean
-public class PagingCrudServiceImpl<T, ID> extends AbstractCrudServiceImpl<T, ID> implements PagingCrudService<T, ID> {
+public abstract class AbstractPagingCrudServiceImpl<T extends BaseEntity<ID>, ID extends Serializable>
+        extends AbstractCrudServiceImpl<T, ID>
+        implements PagingCrudService<T, ID> {
     @Override
     public Page<T> findAll(Pageable pageable) {
         return getRepository().findAll(pageable);
diff --git a/src/main/java/com/cubetiqs/data/service/CrudService.java b/src/main/java/com/cubetiqs/data/service/CrudService.java
index 8c3e73c..ccd9e27 100644
--- a/src/main/java/com/cubetiqs/data/service/CrudService.java
+++ b/src/main/java/com/cubetiqs/data/service/CrudService.java
@@ -65,5 +65,11 @@ public interface CrudService<T, ID> extends BaseService<T, ID> {
      */
     void deleteAll(List<ID> ids);
 
+    /**
+     * Check entity exists within ID
+     *
+     * @param id ID
+     * @return boolean
+     */
     boolean existsById(ID id);
 }