Polish gh-31

2020-05-17 19:34:53 -04:00
parent fa5c3510a9
commit 26c3941a20
6 changed files with 81 additions and 102 deletions
--- a/samples/boot/minimal/src/test/java/sample/JwkSetEndpointFilterTests.java
+++ b/samples/boot/minimal/src/test/java/sample/JwkSetEndpointFilterTests.java
@@ -13,31 +13,17 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-
 package sample;

-import static org.assertj.core.api.Assertions.assertThatThrownBy;
-import static org.hamcrest.Matchers.is;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.only;
-import static org.mockito.Mockito.verify;
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
-import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
-import static sample.JwkSetEndpointFilter.WELL_KNOWN_JWK_URIS;
-
-import javax.servlet.FilterChain;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
+import com.nimbusds.jose.JOSEException;
+import com.nimbusds.jose.jwk.JWK;
+import com.nimbusds.jose.jwk.JWKSet;
+import com.nimbusds.jose.jwk.KeyUse;
+import com.nimbusds.jose.jwk.gen.RSAKeyGenerator;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInstance;
 import org.junit.jupiter.api.TestInstance.Lifecycle;
-import org.mockito.Mockito;
 import org.springframework.mock.web.MockHttpServletRequest;
 import org.springframework.mock.web.MockHttpServletResponse;
 import org.springframework.test.web.servlet.MockMvc;
@@ -45,36 +31,48 @@ import org.springframework.test.web.servlet.setup.MockMvcBuilders;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;

-import com.nimbusds.jose.JOSEException;
-import com.nimbusds.jose.jwk.JWK;
-import com.nimbusds.jose.jwk.JWKSet;
-import com.nimbusds.jose.jwk.KeyUse;
-import com.nimbusds.jose.jwk.gen.RSAKeyGenerator;
+import javax.servlet.FilterChain;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.hamcrest.Matchers.is;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.only;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoInteractions;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+import static sample.JwkSetEndpointFilter.DEFAULT_JWK_SET_URI;

@TestInstance(Lifecycle.PER_CLASS)
-public class JwkSetEndpointFilterTest {
-
-	private MockMvc mvc;
-	private JWKSet jwkSet;
+public class JwkSetEndpointFilterTests {
 	private JWK jwk;
+	private JWKSet jwkSet;
 	private JwkSetEndpointFilter filter;
+	private MockMvc mvc;

 	@BeforeAll
 	void setup() throws JOSEException {
 		this.jwk = new RSAKeyGenerator(2048).keyID("endpoint-test").keyUse(KeyUse.SIGNATURE).generate();
-		this.jwkSet = new JWKSet(jwk);
-		this.filter = new JwkSetEndpointFilter(jwkSet);
-		this.mvc = MockMvcBuilders.standaloneSetup(new FakeController()).addFilters(filter).alwaysDo(print()).build();
+		this.jwkSet = new JWKSet(this.jwk);
+		this.filter = new JwkSetEndpointFilter(this.jwkSet);
+		this.mvc = MockMvcBuilders.standaloneSetup(new HelloController()).addFilters(this.filter).alwaysDo(print()).build();
 	}

 	@Test
-	void constructorWhenJsonWebKeySetIsNullThrowIllegalArgumentException() {
-		assertThatThrownBy(() -> new JwkSetEndpointFilter(null)).isInstanceOf(IllegalArgumentException.class);
+	void constructorWhenJWKSetNullThenThrowIllegalArgumentException() {
+		assertThatThrownBy(() -> new JwkSetEndpointFilter(null))
+				.isInstanceOf(IllegalArgumentException.class);
 	}

 	@Test
-	void doFilterWhenPathMatches() throws Exception {
-		String requestUri = WELL_KNOWN_JWK_URIS;
+	void doFilterWhenRequestMatchesThenProcess() throws Exception {
+		String requestUri = DEFAULT_JWK_SET_URI;
 		MockHttpServletRequest request = new MockHttpServletRequest("GET", requestUri);
 		request.setServletPath(requestUri);

@@ -83,13 +81,12 @@ public class JwkSetEndpointFilterTest {

 		this.filter.doFilter(request, response, filterChain);

-		verify(filterChain, never()).doFilter(Mockito.any(HttpServletRequest.class),
-				Mockito.any(HttpServletResponse.class));
+		verifyNoInteractions(filterChain);
 	}

 	@Test
-	void doFilterWhenPathDoesNotMatch() throws Exception {
-		String requestUri = "/stuff/" + WELL_KNOWN_JWK_URIS;
+	void doFilterWhenRequestDoesNotMatchThenContinueChain() throws Exception {
+		String requestUri = "/path";
 		MockHttpServletRequest request = new MockHttpServletRequest("GET", requestUri);
 		request.setServletPath(requestUri);

@@ -98,30 +95,34 @@ public class JwkSetEndpointFilterTest {

 		this.filter.doFilter(request, response, filterChain);

-		verify(filterChain, only()).doFilter(Mockito.any(HttpServletRequest.class),
-				Mockito.any(HttpServletResponse.class));
+		verify(filterChain, only()).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class));
 	}

 	@Test
-	void testResponseIfRequestMatches() throws Exception {
-		mvc.perform(get(WELL_KNOWN_JWK_URIS)).andDo(print()).andExpect(status().isOk())
-				.andExpect(jsonPath("$.keys").isArray()).andExpect(jsonPath("$.keys").isNotEmpty())
-				.andExpect(jsonPath("$.keys[0].kid").value(jwk.getKeyID()))
-				.andExpect(jsonPath("$.keys[0].kty").value(jwk.getKeyType().toString()));
+	void requestWhenMatchesThenResponseContainsKeys() throws Exception {
+		this.mvc.perform(get(DEFAULT_JWK_SET_URI))
+				.andDo(print())
+				.andExpect(status().isOk())
+				.andExpect(jsonPath("$.keys").isArray())
+				.andExpect(jsonPath("$.keys").isNotEmpty())
+				.andExpect(jsonPath("$.keys[0].kid").value(this.jwk.getKeyID()))
+				.andExpect(jsonPath("$.keys[0].kty").value(this.jwk.getKeyType().toString()));
 	}

 	@Test
-	void testResponseIfNotRequestMatches() throws Exception {
-		mvc.perform(get("/fake")).andDo(print()).andExpect(status().isOk())
-				.andExpect(content().string(is("fake")));
+	void requestWhenDoesNotMatchThenResponseContainsOther() throws Exception {
+		this.mvc.perform(get("/hello"))
+				.andDo(print())
+				.andExpect(status().isOk())
+				.andExpect(content().string(is("hello")));
 	}

 	@RestController
-	class FakeController {
+	static class HelloController {

-		@RequestMapping("/fake")
-		public String hello() {
-			return "fake";
+		@RequestMapping("/hello")
+		String hello() {
+			return "hello";
 		}
 	}
 }
--- a/samples/boot/minimal/src/test/java/sample/MinimalAuthorizationServerApplicationTests.java
+++ b/samples/boot/minimal/src/test/java/sample/MinimalAuthorizationServerApplicationTests.java
@@ -15,29 +15,27 @@
 */
 package sample;

-import static org.assertj.core.api.Assertions.assertThat;
-import static org.springframework.http.HttpStatus.OK;
-
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
 import org.springframework.boot.web.server.LocalServerPort;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.client.RestTemplate;

+import static org.assertj.core.api.Assertions.assertThat;
+
@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)
 public class MinimalAuthorizationServerApplicationTests {
-
 	private RestTemplate rest = new RestTemplate();

 	@LocalServerPort
 	private int serverPort;

 	@Test
-	void verifyJwkSetEndpointFilterAccessibleWithoutAuthentication() {
-		ResponseEntity<String> responseEntity = rest.getForEntity(
-				"http://localhost:" + serverPort + JwkSetEndpointFilter.WELL_KNOWN_JWK_URIS, String.class);
-		assertThat(responseEntity.getStatusCode()).isEqualTo(OK);
+	void requestWhenNotAuthenticatedThenJwkSetEndpointStillAccessible() {
+		ResponseEntity<String> responseEntity = this.rest.getForEntity(
+				"http://localhost:" + this.serverPort + JwkSetEndpointFilter.DEFAULT_JWK_SET_URI, String.class);
+		assertThat(responseEntity.getStatusCode()).isEqualTo(HttpStatus.OK);
 	}
-
 }