From d2c1130efdab9996b885aca48ed6ef57e6b1e15c Mon Sep 17 00:00:00 2001 From: Thomas Klein Date: Sat, 12 Oct 2019 19:59:47 +0200 Subject: [PATCH] fix: removed tsignore for AppContext (#188) --- src/App/App.tsx | 27 ++++++++++++++++++--------- src/pages/home/Home.tsx | 3 ++- src/router.tsx | 9 ++++----- 3 files changed, 24 insertions(+), 15 deletions(-) diff --git a/src/App/App.tsx b/src/App/App.tsx index d9f82fc..fd0e8ba 100644 --- a/src/App/App.tsx +++ b/src/App/App.tsx @@ -14,21 +14,30 @@ import '../utils/styles/global'; import 'normalize.css'; import Footer from '../components/Footer'; import { FormError } from '../components/Login/Login'; +import { PackageInterface } from '../components/Package/Package'; -export const AppContext = React.createContext<{}>({}); -export const AppContextProvider = AppContext.Provider; -export const AppContextConsumer = AppContext.Consumer; - -export interface AppStateInterface { - error?: FormError; +interface AppContextData { logoUrl: string; + scope: string; + isUserLoggedIn: boolean; + packages: PackageInterface[]; user: { username?: string; }; - scope: string; +} +export const AppContext = React.createContext({ + logoUrl: window.VERDACCIO_LOGO, + user: {}, + scope: window.VERDACCIO_SCOPE || '', + isUserLoggedIn: false, + packages: [], +}); +const AppContextProvider = AppContext.Provider; +export const AppContextConsumer = AppContext.Consumer; + +export interface AppStateInterface extends AppContextData { + error?: FormError; showLoginModal: boolean; - isUserLoggedIn: boolean; - packages: any[]; isLoading: boolean; } export default class App extends Component<{}, AppStateInterface> { diff --git a/src/pages/home/Home.tsx b/src/pages/home/Home.tsx index cdc08e9..dc94812 100644 --- a/src/pages/home/Home.tsx +++ b/src/pages/home/Home.tsx @@ -1,10 +1,11 @@ import React from 'react'; import PackageList from '../../components/PackageList'; +import { PackageInterface } from '../../components/Package/Package'; interface Props { isUserLoggedIn: boolean; - packages: []; + packages: PackageInterface[]; } const Home: React.FC = ({ packages }) => ( diff --git a/src/router.tsx b/src/router.tsx index ab71e07..a48d5e5 100644 --- a/src/router.tsx +++ b/src/router.tsx @@ -4,7 +4,7 @@ import React, { Component, ReactElement } from 'react'; import { Router, Route, Switch } from 'react-router-dom'; import { createBrowserHistory } from 'history'; -import { AppContextConsumer, AppStateInterface } from './App/App'; +import { AppContextConsumer } from './App/App'; import Header from './components/Header'; const history = createBrowserHistory({ @@ -44,7 +44,7 @@ class RouterApp extends Component { return ( - {function renderConsumerVersionPage({ logoUrl, scope = '', user }: Partial) { + {function renderConsumerVersionPage({ logoUrl, scope = '', user }) { return
; }} @@ -54,8 +54,7 @@ class RouterApp extends Component { public renderHomePage = (): ReactElement => { return ( - {function renderConsumerVersionPage({ isUserLoggedIn, packages }: Partial) { - // @ts-ignore + {function renderConsumerVersionPage({ isUserLoggedIn, packages }) { return ; }} @@ -65,7 +64,7 @@ class RouterApp extends Component { public renderVersionPage = (routerProps): ReactElement => { return ( - {function renderConsumerVersionPage({ isUserLoggedIn }: Partial) { + {function renderConsumerVersionPage({ isUserLoggedIn }) { return ; }}