cubetiq/verdaccio-ui
1
0
Fork 0
forked from sombochea/verdaccio-ui
Code Issues Pull Requests Releases Wiki Activity

fix(#300): correctly reference registry url from options

Browse Source
This commit is contained in:
Michael Mok 2019-11-25 02:43:19 +08:00 committed by Priscila Oliveira
parent 0d9232a92c
commit ee74474811
4 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jest/jestEnvironment.js
View File

@ -1 +1 @@
require.requireActual('babel/polyfill'); jest.requireActual('babel/polyfill');

5
jest/setup.ts
View File

@ -7,14 +7,13 @@ import { configure } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16'; import Adapter from 'enzyme-adapter-react-16';
import { GlobalWithFetchMock } from 'jest-fetch-mock'; import { GlobalWithFetchMock } from 'jest-fetch-mock';
// @ts-ignore : Only a void function can be called with the 'new' keyword
configure({ adapter: new Adapter() }); configure({ adapter: new Adapter() });
// @ts-ignore : Property '__APP_VERSION__' does not exist on type 'Global'. // @ts-ignore : Property '__APP_VERSION__' does not exist on type 'Global'.
global.__APP_VERSION__ = '1.0.0'; global.__APP_VERSION__ = '1.0.0';
// @ts-ignore : Property '__VERDACCIO_BASENAME_UI_OPTIONS' does not exist on type 'Global'. // @ts-ignore : Property '__VERDACCIO_BASENAME_UI_OPTIONS' does not exist on type 'Global'.
global.__VERDACCIO_BASENAME_UI_OPTIONS = {}; global.__VERDACCIO_BASENAME_UI_OPTIONS = { base: 'http://localhost' };
// @ts-ignore : Property 'VERDACCIO_API_URL' does not exist on type 'Global'.
global.VERDACCIO_API_URL = 'https://verdaccio.tld'; global.VERDACCIO_API_URL = 'https://verdaccio.tld';
const customGlobal: GlobalWithFetchMock = global as GlobalWithFetchMock; const customGlobal: GlobalWithFetchMock = global as GlobalWithFetchMock;

10
src/utils/url.test.ts
View File

@ -17,14 +17,18 @@ describe('utils', () => {
expect(isEmail('')).toBeFalsy(); expect(isEmail('')).toBeFalsy();
}); });
test('getRegistryURL() - should keep slash if location is a sub directory', () => { test('getRegistryURL() - should not change when location change', () => {
expect(getRegistryURL()).toBe('http://localhost');
history.pushState({}, 'page title', '/-/web/detail'); history.pushState({}, 'page title', '/-/web/detail');
expect(getRegistryURL()).toBe('http://localhost/-/web/detail'); expect(getRegistryURL()).toBe('http://localhost');
history.pushState({}, 'page title', '/'); history.pushState({}, 'page title', '/');
}); });
test('getRegistryURL() - should not add slash if location is not a sub directory', () => { test('getRegistryURL() - should change when UI options change', () => {
expect(getRegistryURL()).toBe('http://localhost'); expect(getRegistryURL()).toBe('http://localhost');
window.__VERDACCIO_BASENAME_UI_OPTIONS.base = 'http://localhost/test';
expect(getRegistryURL()).toBe('http://localhost/test');
window.__VERDACCIO_BASENAME_UI_OPTIONS.base = 'http://localhost';
}); });
}); });

3
src/utils/url.ts
View File

@ -15,8 +15,7 @@ export function isEmail(email: string): boolean {
} }
export function getRegistryURL(): string { export function getRegistryURL(): string {
// Don't add slash if it's not a sub directory return window.__VERDACCIO_BASENAME_UI_OPTIONS.base;
return `${location.origin}${location.pathname === '/' ? '' : location.pathname}`;
} }
export function extractFileName(url: string): string { export function extractFileName(url: string): string {