sombochea/system-design-primer
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix coding errors (#149)

Browse Source
This commit is contained in:
cclauss 2018-04-25 19:19:04 -06:00 committed by Donne Martin
parent bb49172d92
commit fb6624215a
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
solutions/system_design/mint/mint_mapreduce.py
View File

@ -35,7 +35,7 @@ class SpendingByCategory(MRJob):
if period == self.current_year_month(): if period == self.current_year_month():
yield (period, category), amount yield (period, category), amount
def reducer(self, key, value): def reducer(self, key, values):
"""Sum values for each key. """Sum values for each key.
(2016-01, shopping), 125 (2016-01, shopping), 125

2
solutions/system_design/pastebin/pastebin.py
View File

@ -26,7 +26,7 @@ class HitCounts(MRJob):
period = self.extract_year_month(line) period = self.extract_year_month(line)
yield (period, url), 1 yield (period, url), 1
def reducer(self, key, value): def reducer(self, key, values):
"""Sum values for each key. """Sum values for each key.
(2016-01, url0), 2 (2016-01, url0), 2

6
solutions/system_design/sales_rank/sales_rank_mapreduce.py
View File

@ -9,7 +9,7 @@ class SalesRanker(MRJob):
"""Return True if timestamp is within past week, False otherwise.""" """Return True if timestamp is within past week, False otherwise."""
... ...
def mapper(self, _ line): def mapper(self, _, line):
"""Parse each log line, extract and transform relevant lines. """Parse each log line, extract and transform relevant lines.
Emit key value pairs of the form: Emit key value pairs of the form:
@ -25,7 +25,7 @@ class SalesRanker(MRJob):
if self.within_past_week(timestamp): if self.within_past_week(timestamp):
yield (category, product_id), quantity yield (category, product_id), quantity
def reducer(self, key, value): def reducer(self, key, values):
"""Sum values for each key. """Sum values for each key.
(foo, p1), 2 (foo, p1), 2
@ -74,4 +74,4 @@ class SalesRanker(MRJob):
if __name__ == '__main__': if __name__ == '__main__':
HitCounts.run() SalesRanker.run()