mirror of
https://github.com/SomboChea/ui
synced 2026-01-19 09:36:30 +07:00
feat: login Dialog Component - Replaced class by func. comp + added react-hook-form (#341)
* refactor: convert class to func * refactor: changed login form logic * refactor: conver to testing-library tests * refactor: moved dependency * refactor: replaced uglifyjs-webpack-plugin by terser-webpack-plugin * fix: fixed e2e errors * fix: fixed e2e test * Delete settings.json * fix: vscode settings rollback * refactor: rollback webpack config * refactor: updated eslint rule * fix: removed --fix * refactor: incresed the bundle size
This commit is contained in:
committed by
Juan Picado @jotadeveloper
parent
501845b5f8
commit
42d3bb8508
@@ -59,7 +59,6 @@ describe('makeLogin', (): void => {
|
||||
const result = {
|
||||
error: {
|
||||
description: "Username or password can't be empty!",
|
||||
title: 'Unable to login',
|
||||
type: 'error',
|
||||
},
|
||||
};
|
||||
@@ -77,8 +76,7 @@ describe('makeLogin', (): void => {
|
||||
test('makeLogin - login should failed with 401', async () => {
|
||||
const result = {
|
||||
error: {
|
||||
description: 'bad username/password, access denied',
|
||||
title: 'Unable to login',
|
||||
description: 'Unable to sign in',
|
||||
type: 'error',
|
||||
},
|
||||
};
|
||||
@@ -91,7 +89,6 @@ describe('makeLogin', (): void => {
|
||||
test('makeLogin - login should failed with when no data is sent', async () => {
|
||||
const result = {
|
||||
error: {
|
||||
title: 'Unable to login',
|
||||
type: 'error',
|
||||
description: "Username or password can't be empty!",
|
||||
},
|
||||
|
||||
@@ -47,7 +47,6 @@ export interface LoginBody {
|
||||
}
|
||||
|
||||
export interface LoginError {
|
||||
title: string;
|
||||
type: string;
|
||||
description: string;
|
||||
}
|
||||
@@ -56,7 +55,6 @@ export async function makeLogin(username?: string, password?: string): Promise<L
|
||||
// checks isEmpty
|
||||
if (isEmpty(username) || isEmpty(password)) {
|
||||
const error = {
|
||||
title: 'Unable to login',
|
||||
type: 'error',
|
||||
description: "Username or password can't be empty!",
|
||||
};
|
||||
@@ -77,10 +75,10 @@ export async function makeLogin(username?: string, password?: string): Promise<L
|
||||
};
|
||||
return result;
|
||||
} catch (e) {
|
||||
console.error('login error', e.message);
|
||||
const error = {
|
||||
title: 'Unable to login',
|
||||
type: 'error',
|
||||
description: e.error,
|
||||
description: 'Unable to sign in',
|
||||
};
|
||||
return { error };
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user