From d4f2720994c36196218b196737022fdd258a4232 Mon Sep 17 00:00:00 2001 From: Alfonso Austin <22054505+agar23@users.noreply.github.com> Date: Tue, 14 Jan 2020 01:43:31 -0500 Subject: [PATCH] chore(build): add missing export (#417) Co-authored-by: Juan Picado @jotadeveloper --- src/muiComponents/Text/Text.tsx | 9 +++------ src/muiComponents/Text/TextConfig.ts | 7 +++++++ src/muiComponents/Text/index.ts | 3 ++- src/pages/Version/context.ts | 20 +------------------- src/pages/Version/index.ts | 10 +++------- src/pages/Version/version-config.ts | 19 +++++++++++++++++++ 6 files changed, 35 insertions(+), 33 deletions(-) create mode 100644 src/muiComponents/Text/TextConfig.ts create mode 100644 src/pages/Version/version-config.ts diff --git a/src/muiComponents/Text/Text.tsx b/src/muiComponents/Text/Text.tsx index fe64d52..5ee100e 100644 --- a/src/muiComponents/Text/Text.tsx +++ b/src/muiComponents/Text/Text.tsx @@ -1,13 +1,10 @@ import React, { forwardRef } from 'react'; -import { default as MaterialUITypography, TypographyProps } from '@material-ui/core/Typography'; +import { default as MaterialUITypography } from '@material-ui/core/Typography'; + +import { TextProps } from './TextConfig'; -type TextType = 'subtitle1' | 'subtitle2' | 'body1' | 'body2'; type TextRef = HTMLElementTagNameMap[keyof HTMLElementTagNameMap]; -export interface TextProps extends Omit { - variant?: TextType; -} - // The reference is already from type of the Component, so the any below is not a problem const Text = forwardRef(function Text(props, ref) { return ; diff --git a/src/muiComponents/Text/TextConfig.ts b/src/muiComponents/Text/TextConfig.ts new file mode 100644 index 0000000..280387d --- /dev/null +++ b/src/muiComponents/Text/TextConfig.ts @@ -0,0 +1,7 @@ +import { TypographyProps } from '@material-ui/core/Typography'; + +type TextType = 'subtitle1' | 'subtitle2' | 'body1' | 'body2'; + +export interface TextProps extends Omit { + variant?: TextType; +} diff --git a/src/muiComponents/Text/index.ts b/src/muiComponents/Text/index.ts index d816459..b0b7dac 100644 --- a/src/muiComponents/Text/index.ts +++ b/src/muiComponents/Text/index.ts @@ -1 +1,2 @@ -export { default, TextProps } from './Text'; +export { default } from './Text'; +export { TextProps } from './TextConfig'; diff --git a/src/pages/Version/context.ts b/src/pages/Version/context.ts index 8b063be..9d14e65 100644 --- a/src/pages/Version/context.ts +++ b/src/pages/Version/context.ts @@ -1,24 +1,6 @@ import { createContext, Consumer, Provider } from 'react'; -import { PackageMetaInterface } from '../../../types/packageMeta'; -export interface DetailContextProps { - packageMeta: PackageMetaInterface; - packageVersion?: string; - readMe: string; - packageName: string; - enableLoading: () => void; - isLoading: boolean; - hasNotBeenFound: boolean; -} - -export interface VersionPageConsumerProps { - packageMeta: PackageMetaInterface; - readMe: string; - packageName: string; - packageVersion?: string; - // FIXME: looking for the appropiated type here - enableLoading: any; -} +import { DetailContextProps, VersionPageConsumerProps } from './version-config'; export const DetailContext = createContext>({}); diff --git a/src/pages/Version/index.ts b/src/pages/Version/index.ts index 91cc27a..aec9f83 100644 --- a/src/pages/Version/index.ts +++ b/src/pages/Version/index.ts @@ -1,8 +1,4 @@ -export { - DetailContext, - DetailContextConsumer, - DetailContextProvider, - DetailContextProps, - VersionPageConsumerProps, -} from './context'; +export { DetailContext, DetailContextConsumer, DetailContextProvider } from './context'; +export { VersionPageConsumerProps, DetailContextProps } from './version-config'; + export { default } from './Version'; diff --git a/src/pages/Version/version-config.ts b/src/pages/Version/version-config.ts new file mode 100644 index 0000000..9c899bc --- /dev/null +++ b/src/pages/Version/version-config.ts @@ -0,0 +1,19 @@ +import { PackageMetaInterface } from '../../../types/packageMeta'; + +export interface DetailContextProps { + enableLoading: () => void; + hasNotBeenFound: boolean; + isLoading: boolean; + packageMeta: PackageMetaInterface; + packageName: string; + packageVersion?: string; + readMe: string; +} + +export interface VersionPageConsumerProps { + enableLoading: () => void; + packageMeta: PackageMetaInterface; + packageName: string; + packageVersion?: string; + readMe: string; +}