cubetiq/code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3263 from cdr/jsjoeio/fix-e2e-test

Browse Source 
fix(testing): reduce flakiness of terminal.test.ts and use 1 worker for e2e tests
This commit is contained in:
Joe Previte 2021-04-30 15:38:32 -07:00 committed by GitHub
commit 8e6c10e7ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/config.ts
View File

@ -52,6 +52,7 @@ const config: Config = {
testDir: path.join(__dirname, "e2e"), // Search for tests in this directory. testDir: path.join(__dirname, "e2e"), // Search for tests in this directory.
timeout: 60000, // Each test is given 60 seconds. timeout: 60000, // Each test is given 60 seconds.
retries: 3, // Retry failing tests 2 times retries: 3, // Retry failing tests 2 times
workers: 1,
} }
if (process.env.CI) { if (process.env.CI) {

2
test/e2e/terminal.test.ts
View File

@ -50,7 +50,7 @@ test.describe("Integrated Terminal", () => {
await codeServer.focusTerminal() await codeServer.focusTerminal()
await page.waitForLoadState("load") await page.waitForLoadState("load")
await page.keyboard.type(`echo '${testString}' > '${tmpFile}'`) await page.keyboard.type(`echo ${testString} > ${tmpFile}`)
await page.keyboard.press("Enter") await page.keyboard.press("Enter")
// It may take a second to process // It may take a second to process
await page.waitForTimeout(1000) await page.waitForTimeout(1000)

5
yarn.lock
View File

@ -3141,11 +3141,6 @@ eslint-plugin-import@^2.18.2:
resolve "^1.17.0" resolve "^1.17.0"
tsconfig-paths "^3.9.0" tsconfig-paths "^3.9.0"
eslint-plugin-jest-playwright@^0.2.1:
version "0.2.1"
resolved "https://registry.yarnpkg.com/eslint-plugin-jest-playwright/-/eslint-plugin-jest-playwright-0.2.1.tgz#8778fee9d5915132a03d94370d3eea0a7ddd08f3"
integrity sha512-BicKUJUpVPsLbHN8c5hYaZn6pv8PCMjBGHXUfvlY1p75fh4APVfX2gTK14HuiR8/Bv3fKBQu5MTaqCro4E3OHg==
eslint-plugin-prettier@^3.1.0: eslint-plugin-prettier@^3.1.0:
version "3.4.0" version "3.4.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.4.0.tgz#cdbad3bf1dbd2b177e9825737fe63b476a08f0c7" resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.4.0.tgz#cdbad3bf1dbd2b177e9825737fe63b476a08f0c7"